From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.5822.1618299547481069728 for ; Tue, 13 Apr 2021 00:39:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nJovBSWF; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: yuwei.chen@intel.com) IronPort-SDR: QYaRiCDiewUQoIUrpbdNjkbz31o1vose6s6uvAl0c/uoiVl3ows2z1pluM9bnGUaWc9BZI/oWP Xm49OaN+tIUw== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="181487349" X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="181487349" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 00:39:06 -0700 IronPort-SDR: 2Usrl/EzVVRW1AGWkA4MOgQnYLVhVhJXFyYesRw2dLboNdflOKbin/u9TnBQud5qgIW60fwlGm UU3Y4CsTofgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="460487951" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 13 Apr 2021 00:39:06 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 13 Apr 2021 00:39:06 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 13 Apr 2021 00:39:06 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 13 Apr 2021 00:39:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OP4GKYxBNPPw7RoUwn/87dBFRbQ8cQcYUCtlD9lnu9/PpzdEm8XXxPrKTNzJmbNMxsCIo7UxgR9A65hqufebWHjz+Fy7RdAznTPQg7/9IMXItIe5VPfUBFmTYZxV+WjhDlhHWSZXye3fHhuf5MXoBZO96cfMzIErAB3IRyeXMPZT0u2Y43ZHMcbCttZxlktzIQJTKKfycSxDXtbDsUvWHZ5+AnLa7DNQiTP12RibK9jlF3FvD4HjbgKC+z/eUVjGyhLCsFpIydK1zZaqVXHeABmXFjtbKjt0md9VwDnGMb9N+WuZI/rWOnzui75Wh4DS3khLq/IpeD0pnnw87CjrCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lc8PmS55++JStQfnj18nuUL9F+Dkjah8SXcD4dFg6fM=; b=kzzETZVzMBTVvVup8O+Env3RuhHUiZO36kAst6rykMKynO7VY0xMJ61qLl2zRNLBmxQnFa3QyBFqllH+1P27SY5lbIeX4aoqq2Miee3GqlIs4i+LxjArcfQtpz+Nzi/8rFojtSIVuP8NR9cQU1FBbO0ukZWUdYfKcgPCogNmt5631C6fULazpLmaX3ozFwaf0KQkLPiqhJnCD9gUDtGgKDt6sB8DL84zwpCSRx9aGWySpElRd2CmRKkNVzrBYcg8JJdpl29iRVii6IrBtnYdaOKgwer+G/adVEupWnYtNN+NPmp2e1G2k5J5zKqDDKhaLfXOxO9t2kcFxp6PzXBkMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lc8PmS55++JStQfnj18nuUL9F+Dkjah8SXcD4dFg6fM=; b=nJovBSWFK9N6Ri7usEnyEQtd+sza+mlujxy/qOTOkXREEwiToP1NePDkkrQou8cCgtK3pagUWyed+q1PTvnlLzhB7jUm7kjxk4vWN1neft7oqgDC+TY639ugvjK3xEu1mn8Y0p1CtDI/OKtn6bgIgkMTu3khovCAvbmoiniEL3k= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM5PR11MB1657.namprd11.prod.outlook.com (2603:10b6:4:c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Tue, 13 Apr 2021 07:39:05 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::8d2a:f371:783f:3a55]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::8d2a:f371:783f:3a55%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 07:39:04 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "Chen, Christine" , "Kinney, Michael D" CC: "Feng, Bob C" , Liming Gao Subject: Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template Thread-Topic: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template Thread-Index: AQHXLYvMh4MR9985ok+lFdBUmG4zyKqwILAAgAHyYPA= Date: Tue, 13 Apr 2021 07:39:04 +0000 Message-ID: References: <20210409220015.1980-1-michael.d.kinney@intel.com> <1674F9256FCB7012.19371@groups.io> In-Reply-To: <1674F9256FCB7012.19371@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85176420-f76a-48e5-f8aa-08d8fe4f36a3 x-ms-traffictypediagnostic: DM5PR11MB1657: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D9+YaXbbCGhsXbvP/cEsK6uRj/m8K13MrOK9cApYcanSC2GyFz3pnRpbVOODd02inju71tMETim/CQes0uri1lpCDcAF0L4j87l44eBBIINwSnvN0nnWNAHo6nz01VOnUq5y3IhhIHCpBIvo416fkAIC8vvXAxXfMi2gzKHzy0ExNz0M8wDUKkDdeCTpsZOfif80+h2cIBStG67SVkpBBDJg8jVH60go6APqYf6GYwJz6p4aBcQ+8WnCqK0Rmd0Et81Wnsc3T2QFgJDUD8la4PeqV52u1bDrC5gVBFOTIhMVjESKZcErzeVlhTCeh/aQ621ODV4X+LH4VKGH8HF2SqLsFr598dlBEdpHbX/olnJgckozwEGiZroT9jxViOSA9uV19wR6vS4i+X1MvWGSCGGqwoFaW8OdMCxvwEv2AjchNsOyYhcoX9fu8e+T2PzC649FhREPdxsM8F+kX7utUt+UFMNsFd1qO5g7EC3MOC6s8NNcxjurHgLflB5YER9Vq8epVo7V16sJXjKTlQr+Zsk4/ah0tqqiHsvdctuFlTQMIzt8M0yCHNoA7bhu5VcDuD4Q3vciWP12z2lHTCBmIm8VVWjgPOStEH383oPGFoNvO5a+axLCNHA6jBvLDdggRRRQ3OXMIem66Ok5jTutXMT3rMF2+B6y4hLJ6N2RsTfehSA5jBnVOw07KGhS6E7XzZAARma4HS6diSNNF8Ai7g/NVq/uLKdoSfXZIYKFXRk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(376002)(366004)(346002)(71200400001)(53546011)(83380400001)(38100700002)(64756008)(186003)(8936002)(66446008)(966005)(76116006)(33656002)(26005)(8676002)(478600001)(66946007)(86362001)(9686003)(5660300002)(4326008)(110136005)(55016002)(6506007)(316002)(54906003)(6636002)(66476007)(66556008)(52536014)(2906002)(7696005)(122000001)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CY3bxDJX8XJSxmfNf0n3EWk7k4HdB9g+47OKLTjVy0StB6ub9v/M03wtUD1W?= =?us-ascii?Q?XyHPvgcwOZr169dqKDmb5kJzjQVIz3E10XJxBej/xtq77evQ/arFm++CtIkL?= =?us-ascii?Q?qtW/JvvzCCiVNd9r6+um4AJb6BDgCnGvpZyq9QG3/vkdcCw0+B/Q0QTNsUYt?= =?us-ascii?Q?lK5AWqBaY56ItmIHKUy8hPRsp0YxO4o0EGCQUb2Qe4RbpiJ6UDY+bTNEKVBe?= =?us-ascii?Q?AiI+GP/ig46knybeNNIibQ+LH4Hy/DNubiCImPMmZY+WEdYygdvgKD0kPf3r?= =?us-ascii?Q?PL5lphUB4IetT0pa/gPDgFUuEJ1FvBb5XyrXA3n1windHYzvgjh9XUr6QOvz?= =?us-ascii?Q?x+1qGptGCH35+krYRRfq7CXgtatcMmhawe7z7nqMmkkCwfwa5u9CHuEl0YNk?= =?us-ascii?Q?oD9UOvjxlsT220UNtf6YQfFI8q6/nCDYeR7N6WyFDqrau9PFdL0n2U7iejGQ?= =?us-ascii?Q?Xzwd7z1t9UXJlKCpvc8dwoaW1su5Eg0AwD/CvLPvBFysaSMc5IG3McyFEiea?= =?us-ascii?Q?Ruz7grkSd4n0hctVkAgaQYZ56i0qQKel4GFBayCBEI8cbiYlTJbG5Hnpe6pi?= =?us-ascii?Q?IJ5ug+gBfeSsgvTGrH37Z0f0WRKW+CKNnkO5xPS5/sKOGFfWaRjy2nOdDPXL?= =?us-ascii?Q?LyFRqItnyIlQP0M7X9Gvs/TGvd8PgnPlKtLTgSMmL2mFgO37HBm+oOzpMX3L?= =?us-ascii?Q?5QBdzhLIgM0CNywFfGuSBz/MMSRG9RWlkT2judqLhXv5ngbn9B1nPBbWlFzy?= =?us-ascii?Q?gAbzfJIu1X6h0eiabtiAHxr4i9aSBj6m5yI9mQvz+T8Nnz0cCTaKsIHLj4UI?= =?us-ascii?Q?uotIBD8+Yg90yBwBplm8FS74yWSOJcQ5MvQUj1zPwD9UWRBPzxYQZp3PGbzs?= =?us-ascii?Q?46pCirmCt8HDXQlWwsJuyvCiFNiqNnHbGzAoOep/4SQH8tB2skHU53g3AvTy?= =?us-ascii?Q?9YhrRAjUiSwzgB3JbP+upCVQX/EUZH5FoLEannRQhePGbdj2W/AeRJwEnVDR?= =?us-ascii?Q?l5a60myIXFZhmuVfriaXzi2CSv4HjvlIq5f7kdX2nIMNhh7p0xVVNNIuk27/?= =?us-ascii?Q?gXGV3AK03nIIO6cV8Ry5ANs8IZlyUbdlFIKw9ZmXfy3lGmPVjylw+y0AMFAm?= =?us-ascii?Q?bfMDD9YBj5XRPiODwn449CloRF9hObPN0/IEf8bTJ3ow/eBepwfBX7TrIDgR?= =?us-ascii?Q?ndIjgmx+c83kYTuqLdaAJ7PZ3OrnCrfRihhgZUVg/9Iwz3WwmNtLKSYclgcI?= =?us-ascii?Q?KgSM9KPQODPeUOSzKnIEkSP5SIkz8npNs19I5jTeUWhnPjqPDY2AZZTE4TF6?= =?us-ascii?Q?zMc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85176420-f76a-48e5-f8aa-08d8fe4f36a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 07:39:04.4222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v4LysPI/ztPlEGaiuj1slg//xtmEJnJSKCwOT8G/Y2gQM5KI2HXvEFZCWz0mkTUbHXKGqYrHe0FJYohrIgDtZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1657 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, I have a minor comment. As you change the '*_MAKE_FLAG' to '*_MAKE_FLAGS',= there will have two same '*_MAKE_FLAGS' for the tool chain. It may be du= plicated. Would it be better if just delete "* _MAKE_FLAG"? Thanks, Christine > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Monday, April 12, 2021 9:48 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Feng, Bob C ; Liming Gao > > Subject: Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typ= os > in tools_def.template >=20 > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Saturday, April 10, 2021 6:00 AM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C ; Liming Gao > > ; Chen, Christine > > Subject: [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in > > tools_def.template > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3313 > > > > Change MAKE_FLAG to MAKE_FLAGS to match required name from EDK II > > Build Specifications for VS20xx tool chains. > > > > Cc: Bob Feng > > Cc: Liming Gao > > Cc: Yuwei Chen > > Signed-off-by: Michael D Kinney > > --- > > BaseTools/Conf/tools_def.template | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template > > b/BaseTools/Conf/tools_def.template > > index 933b3160fd2b..c6c9edf5a0d7 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -1,5 +1,5 @@ > > # > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > reserved.
> > +# Copyright (c) 2006 - 2021, Intel Corporation. All rights > > +reserved.
> > # Portions copyright (c) 2008 - 2009, Apple Inc. All rights > > reserved.
# Portions copyright (c) 2011 - 2019, ARM Ltd. All > > rights reserved.
# Copyright (c) 2015, Hewlett-Packard > > Development Company, L.P.
@@ - > > 531,7 +531,7 @@ NOOPT_VS2008_X64_DLINK_FLAGS =3D /NOLOGO > /NODEFAULTLIB > > /IGNORE:4001 /OPT:REF /OPT > > *_VS2008x86_*_*_FAMILY =3D MSFT > > > > *_VS2008x86_*_MAKE_PATH =3D DEF(VS2008x86_BIN)\nmake.exe > > -*_VS2008x86_*_MAKE_FLAG =3D /nologo > > +*_VS2008x86_*_MAKE_FLAGS =3D /nologo > > *_VS2008x86_*_RC_PATH =3D DEF(WINSDK_BIN)\rc.exe > > > > *_VS2008x86_*_MAKE_FLAGS =3D /nologo > > @@ -765,7 +765,7 @@ NOOPT_VS2010_X64_DLINK_FLAGS =3D /NOLOGO > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT > > *_VS2010x86_*_*_FAMILY =3D MSFT > > > > *_VS2010x86_*_MAKE_PATH =3D DEF(VS2010x86_BIN)\nmake.exe > > -*_VS2010x86_*_MAKE_FLAG =3D /nologo > > +*_VS2010x86_*_MAKE_FLAGS =3D /nologo > > *_VS2010x86_*_RC_PATH =3D DEF(WINSDK7x86_BIN)\rc.exe > > > > *_VS2010x86_*_MAKE_FLAGS =3D /nologo > > @@ -999,7 +999,7 @@ NOOPT_VS2012_X64_DLINK_FLAGS =3D /NOLOGO > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT > > *_VS2012x86_*_*_FAMILY =3D MSFT > > > > *_VS2012x86_*_MAKE_PATH =3D DEF(VS2012x86_BIN)\nmake.exe > > -*_VS2012x86_*_MAKE_FLAG =3D /nologo > > +*_VS2012x86_*_MAKE_FLAGS =3D /nologo > > *_VS2012x86_*_RC_PATH =3D DEF(WINSDK71x86_BIN)\rc.exe > > > > *_VS2012x86_*_MAKE_FLAGS =3D /nologo > > @@ -1233,7 +1233,7 @@ NOOPT_VS2013_X64_DLINK_FLAGS =3D /NOLOGO > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT > > *_VS2013x86_*_*_FAMILY =3D MSFT > > > > *_VS2013x86_*_MAKE_PATH =3D DEF(VS2013x86_BIN)\nmake.exe > > -*_VS2013x86_*_MAKE_FLAG =3D /nologo > > +*_VS2013x86_*_MAKE_FLAGS =3D /nologo > > *_VS2013x86_*_RC_PATH =3D DEF(WINSDK8x86_BIN)\rc.exe > > > > *_VS2013x86_*_MAKE_FLAGS =3D /nologo > > @@ -1468,7 +1468,7 @@ NOOPT_VS2015_X64_DLINK_FLAGS =3D /NOLOGO > > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT > > *_VS2015x86_*_*_FAMILY =3D MSFT > > > > *_VS2015x86_*_MAKE_PATH =3D DEF(VS2015x86_BIN)\nmake.exe > > -*_VS2015x86_*_MAKE_FLAG =3D /nologo > > +*_VS2015x86_*_MAKE_FLAGS =3D /nologo > > *_VS2015x86_*_RC_PATH =3D DEF(WINSDK81x86_BIN)\rc.exe > > > > *_VS2015x86_*_MAKE_FLAGS =3D /nologo > > @@ -1586,7 +1586,7 @@ NOOPT_VS2015x86_X64_DLINK_FLAGS =3D > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF > > *_VS2017_*_*_DLL =3D DEF(VS2017_BIN_HOST) > > > > *_VS2017_*_MAKE_PATH =3D DEF(VS2017_BIN_HOST)\nmake.exe > > -*_VS2017_*_MAKE_FLAG =3D /nologo > > +*_VS2017_*_MAKE_FLAGS =3D /nologo > > *_VS2017_*_RC_PATH =3D DEF(RC_PATH) > > > > *_VS2017_*_MAKE_FLAGS =3D /nologo > > @@ -1749,7 +1749,7 @@ NOOPT_VS2017_AARCH64_DLINK_FLAGS =3D > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF > > *_VS2019_*_*_DLL =3D DEF(VS2019_BIN_HOST) > > > > *_VS2019_*_MAKE_PATH =3D DEF(VS2019_BIN_HOST)\nmake.exe > > -*_VS2019_*_MAKE_FLAG =3D /nologo > > +*_VS2019_*_MAKE_FLAGS =3D /nologo > > *_VS2019_*_RC_PATH =3D DEF(RC_PATH) > > > > *_VS2019_*_MAKE_FLAGS =3D /nologo > > -- > > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20