From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.11126.1594888010077877631 for ; Thu, 16 Jul 2020 01:26:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=JPBg57PF; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: yuwei.chen@intel.com) IronPort-SDR: 9+o4i3yVleCY+wpBcYuTHj3qKJWTr55wl9U8YwZA3rm9gz4SkKC8UyLqxDrINvwxsIRvPICY5n E1SCl56yt3Nw== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="214075718" X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="214075718" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 01:26:49 -0700 IronPort-SDR: TMtODQAvPMtwo9M3+FnU7+Q/OtHx46TKanZQCbHjNUIiBFGryTGa5Odv0GeOTtGuKLlNTRJQ+L Skm0ftrjhRzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="430419213" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 16 Jul 2020 01:26:49 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 01:26:49 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 01:26:48 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 01:26:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AllaAFWGCdBnV8Xt9tMQl4+WQUPJVoEdm/5zJWrfKJCSLHEze9AnjHkvpT2FOUJbwkTqTTTY4NPlAq/AAiTAmpR6jncx56aPYqJE2jrUXwsvqzSjM4iA6QX1hAp5Ia2SWAShEZOzmYgCmg6Z/ZnHpDBXNMGvVbUFc/MLuwROW84w3JrwslkDUdqKM2wpdZEzkeznu9iosas5+4hVctuqQKtHYEMODmYtEfblDOrUaUOjQ49tx3rtH/QkWSB/N4N6LqKOT4ePvZ/lo/IK+MwGjgskTFtVQnmwbxmJBp7lY88Dnmf5nnNveBwBz6wbEkCPL+7el+VXjsIylerPVFy8RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9D1bJhbJhOXTkXFQx8SCdimGHgHr5avZnefb2Ag0bLM=; b=mOvO5vCspANft/upDrTIdS1M6waOTxRei66wmIWdj/P8UXb2A2mbfgNm5I0MAEA6FgEQRtu8TLB1aKuI9vzYx6O5Vt7LVFcVWk+Xm4o8/cuS1LLJtPgLGxjfdLZU1FzrFAttO7sLk7nI5qkuLT3FTMaaTKUnyWdj4ZE8mD8hsrzqvK0cJfMc4dMt+TG+KUpPG3IMLBc6L94mQQQwGCajtj24Qr/kiQHGZAIxRrLPtjBW8Y3GmRC+ON1ND34a2yS6jrZKHxDykVB3OGG3RoCuCtT2SXokQNj86ezJstn6/ZOVabwmCVhuMFKI8EekQ+xioDWksxFblJcYK1MYcES6pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9D1bJhbJhOXTkXFQx8SCdimGHgHr5avZnefb2Ag0bLM=; b=JPBg57PFLbfbRkbgORvDcnZkNO2pocydbewYTw/RJxLE0X+VVTTz2kur1gcxGw+d9cE2nEi/Ad5tE43g/N42ZR9Pia2aMbl0d8l/dW5o+9fNFObU0KNoRNUl3+Tixh0vlFwcs+dfp+CwP4w/3xuIv5Xjlgxd/h3RqUJwO4nNo6M= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM6PR11MB3610.namprd11.prod.outlook.com (2603:10b6:5:139::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 16 Jul 2020 08:26:47 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d%12]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 08:26:47 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "Zhang, Shenglei" Subject: Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Topic: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Thread-Index: AQHWWx8r0D1D7TZY6UycF91kz/0y86kJ32WQ Date: Thu, 16 Jul 2020 08:26:46 +0000 Message-ID: References: <20200716031346.40160-1-shenglei.zhang@intel.com> In-Reply-To: <20200716031346.40160-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9952438e-21d5-4d10-8c83-08d82961fae7 x-ms-traffictypediagnostic: DM6PR11MB3610: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1091; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RLxuASkFJStxjZM/zHmoQxPm1VKNfFObc3bPfBxFPMos2jrKk39lxvDIU5D2PTx7E27qWXJc0paItjTh21HLtZPZOnxx+Ai4eGmPRc5PpqLWuWVK/Up2zlsJpbCdWP0ex2N30YUnTSBZ/WNCoc2aKVvUUMfO8EL/43l0q43nGEPEchyyUJtvJffXj8qoCbhaQBzn8wqBLmqug1jQkSBlxzfpmS//3/mJm55Fs/ipFKlLDn6SzHivD9IUz96B82FIsIRC6qswSfoYDr8zrqYaBxbQOq37wizydi5VrxDZyjdBDst0ctDY1xdwBMA+zdafZgcXL/q9+UxQ1X5+4rWqyLTyC6QUl/GaVpl5O2b9e1VkpAA0AOwDejWKJ+h0SKzyF8JxK1oP2Y6bUolWglAhKe8klehDQdAK/MA53O12FWXCZmWf239YViUcvGxlSYQwPThgw+pW7VrBp+4wAUjlq9ZHuwulpluUWqK/JAPdGv0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(52536014)(83380400001)(8676002)(8936002)(186003)(9686003)(5660300002)(86362001)(26005)(55016002)(66476007)(64756008)(7696005)(6506007)(53546011)(478600001)(66556008)(2906002)(33656002)(966005)(71200400001)(66446008)(110136005)(316002)(6636002)(66946007)(76116006)(13513002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: CczJzkTf3RFeMUYjt+r1gtts/6sjL+uPbmfbTb/NVvF97AIBERpmGz0bdHHvocqO9eL2dF4QMAplgCifmIByjRD8L0IQJWFrFQOqT+45Yv0m+s9eOLCaShq6jwYVii9ssMhmfQVLKT4Spd+WjHce1kJlgV8g3z/9iNPiXP+7Zo9MX1JS5e0dXGBYE9fDWWowr7+0nZ4NtrdibZUOiQc5YZxOMFFwLG2BKPs37sqhLxuT1M/5rF+9csqbLFzVI0NID/7QTVb2Otv2o5YEY9uHvVIaqPsKV0cThOeAgWneq3MXIiTB0GQssd2caSE6RBulXYRG0wuEih6h1tMRyH9l+VCPElLPQc6VOwcCtMTZ13unThCLDqEzoNCY0jxzTpEmxM4KNUuRIQwjT78X5FHBRtvaTfSoB5mFZgsKQ9lUIzGmTEshrIHJ+3q2W8GlspHKjgaiIJP41dunwGkd+asMI9eK9EOnf0qouzmCtALMXqhGtFrCWLki0lb241Zwr/0H MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9952438e-21d5-4d10-8c83-08d82961fae7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 08:26:46.9121 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f0REzokLLdEuOG7tSZk2x+snMzngoWm5L/5HdKschGLKd1yeIjyxP4Xuw7h24m56JT62vURF4CYY7G9SXKprhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3610 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check > for user name in xxx-by >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 > Current PatchCheck.py checks each line to ensure line's length is not la= rger > than 76. But there's a case that length of user's name is much longer th= an > that number. So enhance the script to handle this case. >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >=3D 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 charac= ters > # > -- > 2.18.0.windows.1 >=20 >=20 >=20