From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4221.1600995377517722426 for ; Thu, 24 Sep 2020 17:56:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=FuiDSx7O; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: yuwei.chen@intel.com) IronPort-SDR: mDmWVN4yHm5NjztlatCNxRYt2dT1LadvKylgPPUHevXIc3ty73rnnQxuYwelwtOlQBUlbTSkS/ QDnHAayqmCqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="149051413" X-IronPort-AV: E=Sophos;i="5.77,300,1596524400"; d="scan'208";a="149051413" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 17:56:15 -0700 IronPort-SDR: S9OUjgrRpoYYUcMuVguU7KdMHXfsAn+FTzEqZEf3/KNufi8CVhWKxDXPYCXFtTqWcm6/ISmutR 13Lvco9pechA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,300,1596524400"; d="scan'208";a="487216923" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 24 Sep 2020 17:56:15 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 24 Sep 2020 17:56:15 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 24 Sep 2020 17:56:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 24 Sep 2020 17:56:14 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 24 Sep 2020 17:56:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6/Ciw0uwO6pIG1VOr7CB30cVYLVk/93ZhJ0qKJi9HT5P0eneiBhZnXdjYim8SkB2EAqx5t4Fwk9g1qnb/z9jqR1y1f09QIYgNSw+zBBnxIu0Todv1ersKdsKI77aENHQFh8FSHH0qUTb1GT3hni53zebfYbO6xD3MitygLwL2+RrwTry+znZLRGoZE7+65R8p9eY3wqFjxa9LIsz32KNj3yiw8BN+DQTOCu/w0lioFVLTO0ve+gskTS5tS0N/eXWs2R8nfHg0F1YLRLkXb5w0SjaClpjGsgBQ7Lpm8lbaQmec1uLBM15z4lQpSgE9kd0bvr2uiWyTVEmOXT92nrCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YdFWK3NnATqAUqLfku9TOMKs8NMph3igd9A3amwN8/U=; b=hORXr+wYs+sh8ha5LoE7ROvLXls7NREWEWgqhm9dSnkQp8XbjH++DxdsnYOVGJQ/dXfGCBw61YuVE3A9g6aDDrcT+I1ZnDO8rIfgan94HXYvjOWYfK5KHvVhyUNAcQeOzg6gSZg+6uZOpkPvJapUkqbCbYFZU5tqa8FbpXCE1YUEfr7HjpHibbMTvtKh/UYKk0VOl7sbbdEl46LWG0doG1FSVLHIhklVh6+GpbTI55Hyk//JVrMbUBwBNSyc+nLfyQgRsV2sc44JCAt8KFxMCKcU4Rrr8FxK8r/1wxpE/ZKEsUX9h0J4Fy5PNjGH1fk6I4f/sI+0uiV4zAQxI/kI5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YdFWK3NnATqAUqLfku9TOMKs8NMph3igd9A3amwN8/U=; b=FuiDSx7Ow55P0QuLKEIGaKaB8OT3ot/KpEwmQVjKATle0vNzGr/wHHGqtFxZClk7x5ac7YOy1ubP1IFnR5jZ4/y3AlXFBQd1TACajC05zc2/2Um5QsOmuUcT0TXxtXDIBX9k3GSYIrC/ZmOLGHdeds/LyvQ3sSXuLOv2smzPSUY= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM6PR11MB2970.namprd11.prod.outlook.com (2603:10b6:5:65::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Fri, 25 Sep 2020 00:56:06 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::952e:51d:d3db:b10a]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::952e:51d:d3db:b10a%12]) with mapi id 15.20.3412.020; Fri, 25 Sep 2020 00:56:06 +0000 From: "Yuwei Chen" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: Liming Gao Subject: Re: [Patch] BaseTools: Remove CanSkip calling for incremental build Thread-Topic: [Patch] BaseTools: Remove CanSkip calling for incremental build Thread-Index: AQHWkaZIRdbClgxkpESuVhOXy4o24al4ifMw Date: Fri, 25 Sep 2020 00:56:06 +0000 Message-ID: References: <20200923123658.40652-1-bob.c.feng@intel.com> In-Reply-To: <20200923123658.40652-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 707cb773-737a-4966-0b64-08d860edc902 x-ms-traffictypediagnostic: DM6PR11MB2970: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2BYVMXmM6lKzMr7+ldBqQ3LVE3LZph8BBy6tevBZqKQS//XM+zM1DQu6eZh4yvF1vj7C2Gx6XCWg8leW+AhvJxsDIy7mJa0o/iaRTDx5HjFgJmY/VZLvnDn02fqcxgvBdtGb671u5BBfgIA3iAMJIGi8D0TH5b84GS+H5OSZptZWdNOj4Aqgbh+uUuxHZ5RunDE2LjVFPqYt88u7+tST6IkCHq1B60PlRYlWFKQddAqgtr74PbusifLCc2CLZzxqxRNc5WPeTQW1CNVeu2xloHDDlbMPGESG4sLSUp69BX4Jfe+x6ViNoasW+l/wpWFhBF7ici6R7g51pIcR8k0nccDUOioMwqvbfVRIM2qdMkOFBvE2ykeOZ/Hi8LfK7tJiluJ5ew/xyQSVKuDMlGvbQW4zUYhl36/TPtBCfXYJMlpJTZRGBmwOcMrq7gyKyHRFdPVHNbtvwHJMSiBlAuzbfQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(5660300002)(186003)(8936002)(64756008)(7696005)(110136005)(76116006)(6506007)(26005)(66476007)(66946007)(66556008)(4326008)(86362001)(52536014)(83380400001)(8676002)(316002)(53546011)(966005)(66446008)(2906002)(55016002)(478600001)(33656002)(9686003)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: aV+5TivsrkZZ9iJytqWxo3rXXmB/DCi6Ikkj+TtqGwFYYOWiw8q4cOClw+J9Udk1V/O0GH1uLACx2wNm/09042szy+ZYM89l5ipnr2goQWaUcwivIIQMNJx0uAXcDqP2WZw/bAyYwUQgb/WPUlxuDEymAS4GPcb0BPlFlxqxHdwIPNjRCYm/y/pk9HZLYa9ca+4nBLQXugPtdS1CeW3TXcgR3Vmv9O99cUKewXWL1LhkmLI2YiuBI5vgNQkSiWCcy6sKfteORvROqWW/yzpbM43eYp4TrXRgIvG2gnRiiiC+QifVMASzd3MCMYPBBpA7CfnvQc5/+MFxTR+XEbHax4Z4DEw/1Cn/4vjWZMoxfp0t28g4LhSPWu6Mz+CUAUceeuUKbb22DOMgvMrVxVUlK6hd86F2gGeipRTVwYAcMKpHGJpmKUHWP+ftTr8rFJqlOUZRdv3+j3O5ceNlCwBQxWBHcR0lb+a28vqZv3NPmjW7/v4LNnqxEd8N6oPuqUuMPlwzvjaDZJsN5UwT2cLE0NG3G5oqhBAvfxltkIjk0/j713m7ocN1TAkR+aTAKdvOXfkxa4hbBigO8pcq8YZ6FYUwH2BLK9ros0cmlFUA8CgUavVfaC6NsyPAHEtK2nDLcnEC/ueKkFMe8eApkT3WJg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 707cb773-737a-4966-0b64-08d860edc902 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2020 00:56:06.7325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ebql6tNuVYCxUIO1IGNaefxRfbfHIlZsIqG9OjBAg9AT4cGghXTZAy5mLxxsBxBC5EZFsuYD5KxbFQouA5hOQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2970 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yuwei Chen > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, September 23, 2020 8:37 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Chen, Christine > > Subject: [Patch] BaseTools: Remove CanSkip calling for incremental build >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2978 >=20 > If a module add a new PCD, the pcd token number will be reassigned. The > new Pcd token number should be updated to all module's autogen files. > CanSkip can only detect a single module's change but not others. CanSkip > block the pcd token number update in incremental build, so this patch is > going to remove this call. >=20 > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > index dc8b1fe3d1..eebf6e87f5 100755 > --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > @@ -1820,13 +1820,10 @@ class ModuleAutoGen(AutoGen): >=20 > if not self.IsLibrary and CreateLibraryCodeFile: > for LibraryAutoGen in self.LibraryAutoGenList: > LibraryAutoGen.CreateCodeFile() >=20 > - # CanSkip uses timestamps to determine build skipping > - if self.CanSkip(): > - return > self.LibraryAutoGenList > AutoGenList =3D [] > IgoredAutoGenList =3D [] >=20 > for File in self.AutoGenFileList: > -- > 2.20.1.windows.1