From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.3496.1607398128576969279 for ; Mon, 07 Dec 2020 19:28:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=U7yWbPLe; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: yuwei.chen@intel.com) IronPort-SDR: nmdLFS/BMZFo9DiY3NY9jMDdv3WnSFqPh1K/x78QJc/LRx4hoQu+BBV1hRI9k9Houb6aFavsXX albvxf0diZfg== X-IronPort-AV: E=McAfee;i="6000,8403,9828"; a="192102782" X-IronPort-AV: E=Sophos;i="5.78,401,1599548400"; d="scan'208";a="192102782" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 19:28:47 -0800 IronPort-SDR: HePc/2sl2rAhXNkxes2emSYJs+1LJfbj5kU53YVMPKD1lktbeghjFjmkWpLPsJWv7X8QOx5uFD E1Va3iPd7lOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,401,1599548400"; d="scan'208";a="337438311" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 07 Dec 2020 19:28:47 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 7 Dec 2020 19:28:47 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 7 Dec 2020 19:28:47 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 7 Dec 2020 19:28:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hTZrT1vTvSLmTI3gWjGxMcGWca6sy6eJ6XHCsrK/rGjKpuiTxMcNJ24AJuJbP2SEYGjpA0vt8dCixnQIjMp6koFo8zQSzjWmAaBJezFIBgHdhRoSODMU3T/HRBWsvKoVac3x+FQUuJQtMzY+4XlkFff8cg00j5IUsu5J4ln1opiJSZ3sdnHKYiXo9RM66WUOvMQymx8VQ5zCiwZY8oE4mkfNBawPsY34sn3CPYjSRmORmdZirOOwZSWgZSEBL3lZR8AGm0wBuJHLRWmbmB/Q/Kbg9KJNLobOHY78Y8+i5lEIBDbZZ+FcGjR3kdTuUd/6BCsKawpP4z2zYLGxCkcr8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZZ+fu4mMnSvZ2BTfH54JpxGWDnO9ta+WnoOxJkZ+wc=; b=ToQuguNdA4WEgq+b+C2iGsxtX11drjGiESYyVv8IbC5/u8UeWq60ypQz59hHv8PUdjWz7VSbjZ7Z8MDwTbooi7uvXKn6wJLLppEZMsqfCPgvi0vGHf4FhShViE9vyLrjoPAW81ZsRMUOx85NhVgFREPRv6V5ui+iud9tTphOLgWA0OPC7GMfiNEqUc1I4dX5OuXdc5sjIMj3x0uR4kzGZBVQZPcJ5OYihw6XKZLascPGDPQZDtkbJyv/8AkUUe9tKw2J5tQfKGMytvy4tfQodt6xffVqmie1m8+oYH2H09IlWjORnBTV0JKcw+JdO5nlfih7YlkmKRawNWA0piWDLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZZ+fu4mMnSvZ2BTfH54JpxGWDnO9ta+WnoOxJkZ+wc=; b=U7yWbPLegKFoKAEbWd1VmEt9Z5Ffjphm0QzueLfzH5DE/Y9kMW8j8RG7Dgc34XSO4sIIqMW4Ih9D88kT+lBTW3fPETDbQEUZLqgfWv7QzzXbFWJiNGPXB7cSY1HSInDfPK1+oTIdfzXvbT+godvSPktNGNod2LN9W4o+Mx9UUXg= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM5PR1101MB2281.namprd11.prod.outlook.com (2603:10b6:4:5a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.23; Tue, 8 Dec 2020 03:28:45 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::59f7:5329:fc62:a3be]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::59f7:5329:fc62:a3be%9]) with mapi id 15.20.3632.021; Tue, 8 Dec 2020 03:28:45 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in sub DSC. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in sub DSC. Thread-Index: AQHWzQgpUjHsGZaMrkyyQIZMmFJeoqnsifHw Date: Tue, 8 Dec 2020 03:28:45 +0000 Message-ID: References: <20201208021553.1348-1-chasel.chiu@intel.com> In-Reply-To: <20201208021553.1348-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c1c6666-5fc9-49ad-3a81-08d89b295e93 x-ms-traffictypediagnostic: DM5PR1101MB2281: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uEQWpoms7qJ/+Hq0fOTumiqFNNa78NzELjKw3t4xTFvT3Jty4bebrBYqk7R6bW/QyGSSAWaVin8Bvpi+MP7RYKG4YP44zICaEZCRYrN1iszO/+MBhvFLtAF4wzGMaY4r1wd7S1vDc0TjzchFVNbNhG9CWeP/gXYQIDaYHSmDpZ/G0WXtEy9PiWdIve5nWlgv6oasiYM6+6p7pE3ZN1mcP15mIkwXfD1J3d1mKfWMWds3qI0WK1etxkr9wuhX7PYGrR7G7eeeCnr8GKMJx34eSAO9OxtUHcs8pWlNC/pAiz6A2xj1xqIKhbATW0YV8FeqJFW4iwozCC9ZobLMXCK4lR00IXgqBdbHDD+SVGjNOEDEO+p+mAex16XVtkzBgnAAh2OGihAMB4Stter6f7H/VA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(39860400002)(366004)(136003)(6506007)(19627235002)(8936002)(107886003)(86362001)(478600001)(52536014)(8676002)(66446008)(33656002)(54906003)(316002)(26005)(71200400001)(186003)(6636002)(110136005)(7696005)(66476007)(64756008)(9686003)(4326008)(55016002)(53546011)(2906002)(966005)(5660300002)(66946007)(66556008)(76116006)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?dGVhdj1DvjBMIe1W/llR0UdJJEBrYQggb18gFumotChIN7gllu3+VU5Rw+bW?= =?us-ascii?Q?xf0vfuPd1RuMBga/Qtq4JQT4d/iyfP4TNvefZ9o5msMmsAHS6mX5zwKbB1fv?= =?us-ascii?Q?I2xObuVME0PB58oHcSyuLCId60b80xpxNBHyhcH4lNDGP0dpmFp/8sq/Z1c/?= =?us-ascii?Q?d7eCwribvvyxYMWiY04DjuJll4GlBz8D9TadkQLSvskTDa6N3xEoWwBc4s+2?= =?us-ascii?Q?f3cjk2NqNv56dBuKBz6G8W0ZcLcIAz12ScAQn+Abp8tUs8ppL3Iw6KfRn1cu?= =?us-ascii?Q?9h5auZrDUjZMsCM1TKs4u/TY4R80arOm0J1qErxrRy9pftlwAMkeRr5XHZrf?= =?us-ascii?Q?yq2JRsMZ9bpxdKuly6j8xJ/ZAxjqzTAhqa+ckU5LpCjoD86xmScAVXxzIm0N?= =?us-ascii?Q?8nXT1SV+Q4ervYc8JesAZlmeRpFxG1TRMn2dKC2KLb9HRaYbn5O9n55OnWfj?= =?us-ascii?Q?SFlFLWk28mdh+rhw43+btTDdE/requXPgTcXLz28VIIGlkZh3djwABaYbs7p?= =?us-ascii?Q?vxcKQ9EV+MOI+vYHBkLeh2+X5ItnguPskI496ZT4nogGfD28/SumEFTMHY0L?= =?us-ascii?Q?l9hOvK2BiHSNKLy8lFdk3QwW1nGl/MY351CnmaUuysqkkCpoiFfTtUSNwaZv?= =?us-ascii?Q?jaG/bFuuf2CB4j8L8F6E4rzZafp+QSxv1aPQgywPMbUcKHMWI0oryvritA77?= =?us-ascii?Q?NSO28k3LfR5JWj5isTB+vbaROxoN280kfiE5cNNhrVgnqhb9/PAXRHQJBWd9?= =?us-ascii?Q?cktQ1xNGQ5bGHdtcGhKR8CIcVQ1pbZEZRez2eQAL2cjFD/dUvQ8tpjNs19VU?= =?us-ascii?Q?leDXMxX03SVCvzfP8wcsCiI+kh7Y7peA6bw8ccALlW5kw5EyFqVMnazAS3za?= =?us-ascii?Q?BFDWv2rfB9fWH5YG3r8ZNPG09zvxwrZZhebRVRswZiwpHT9ObDcoQ/f+YIdW?= =?us-ascii?Q?CcMeiXbmGMTOtfJsKdd81vKuAarBq3hImQ83Y3AP7Ts=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c1c6666-5fc9-49ad-3a81-08d89b295e93 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2020 03:28:45.4837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TPuT81VmPYnP7hu+HP1X5C0QYEFwhkzbOnwjgrFAqoqZkHfXpGmqphfSDxPzYbKKxjpzKhPIuFHSNCzFVSQtFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2281 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yuwei Chen Tested-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Tuesday, December 8, 2020 10:16 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental > build with UPD in sub DSC. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3107 >=20 > Current script only compares main DSC and output file datetime to > determine if re-generation required or not. > When UPD defined in sub DSC and was modified current script cannot detect > and will not re-generate output files which caused incremental build issu= e. >=20 > Since UPD can be defined in any sub DSC the script has been updated to > compare all DSC datetime with output files to determine re-generation is > needed or not. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Tools/GenCfgOpt.py | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py > b/IntelFsp2Pkg/Tools/GenCfgOpt.py index af7e14a10a..a0b8bba81e 100644 > --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py > +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py > @@ -313,6 +313,7 @@ EndList > self._DscFile =3D '' self._FvDir =3D '' = self._MapVer =3D 0+ > self._DscTime =3D 0 def ParseMacros (self, MacroDefStr): = # ['-DABC=3D1', > '-D', 'CFG_DEBUG=3D1', '-D', 'CFG_OUTDIR=3DBuild']@@ -423,6 +424,9 @@ > EndList > self._DscFile =3D DscFile self._FvDir =3D FvDi= r + # Initial DSC time > is parent DSC time.+ self._DscTime =3D os.path.getmtime(DscFil= e)+ > IsDefSect =3D False IsPcdSect =3D False IsUpd= Sect =3D False@@ - > 530,6 +534,12 @@ EndList > if IncludeDsc =3D=3D None: > print("ERROR: Cannot open file '%s'" % IncludeFilePath) > raise SystemExit++ # Update DscTim= e when newer DSC > time found.+ CurrentDscTime =3D > os.path.getmtime(os.path.realpath(IncludeDsc.name))+ > if CurrentDscTime > self._DscTime:+ = self._DscTime =3D > CurrentDscTime+ NewDscLines =3D I= ncludeDsc.readlines() > IncludeDsc.close() DscLines =3D N= ewDscLines + > DscLines@@ -815,9 +825,8 @@ EndList > if not os.path.exists(OutPutFile): NoFileChange =3D = False else:- > DscTime =3D os.path.getmtime(self._DscFile) OutputTime =3D > os.path.getmtime(OutPutFile)- if DscTime > OutputTime:+ = if > self._DscTime > OutputTime: NoFileChange =3D False = return > NoFileChange -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#68417): https://edk2.groups.io/g/devel/message/68417 > Mute This Topic: https://groups.io/mt/78794912/4546272 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [yuwei.chen@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20