Re: [edk2-devel] [Patch 01/15] BaseTools/Python: Allow HOST_APPLICATION to use NULL libraries

["Yuwei Chen" <yuwei.chen@intel.com>]

Hi, Michael

This patch looks good. While I have a little format suggestion: the Bugzilla link "https://bugzilla.tianocore.org/show_bug.cgi?id=2797" could be written as "REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2797".

Reviewed-by: Yuwei Chen <yuwei.chen@intel.com>

Thanks,
Yuwei
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> Sent: Monday, June 15, 2020 8:19 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: [edk2-devel] [Patch 01/15] BaseTools/Python: Allow
> HOST_APPLICATION to use NULL libraries
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2797
> 
> Update HOST_APPLICATION module type to use NULL library instances.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
> b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
> index 913e710fd9..53027a0e30 100644
> --- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
> +++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
> @@ -1,7 +1,7 @@
>  ## @file
>  # Common routines used by workspace
>  #
> -# Copyright (c) 2012 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2012 - 2020, Intel Corporation. All rights
> +reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  #
> 
> @@ -100,7 +100,7 @@ def GetModuleLibInstances(Module, Platform,
> BuildDatabase, Arch, Target, Toolcha
>      # If a module has a MODULE_TYPE of USER_DEFINED,
>      # do not link in NULL library class instances from the global
> [LibraryClasses.*] sections.
>      #
> -    if Module.ModuleType != SUP_MODULE_USER_DEFINED and
> Module.ModuleType != SUP_MODULE_HOST_APPLICATION:
> +    if Module.ModuleType != SUP_MODULE_USER_DEFINED:
>          for LibraryClass in Platform.LibraryClasses.GetKeys():
>              if LibraryClass.startswith("NULL") and
> Platform.LibraryClasses[LibraryClass, Module.ModuleType]:
>                  Module.LibraryClasses[LibraryClass] =
> Platform.LibraryClasses[LibraryClass, Module.ModuleType]
> --
> 2.21.0.windows.1
> 
> 
>