From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.11636.1592202137241468737 for ; Sun, 14 Jun 2020 23:22:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TO7lky2z; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: yuwei.chen@intel.com) IronPort-SDR: O5fQpTtmIvv3WTHeCWVLETzhdNqERapijoqRk4u5bXkmZ3/B/0RYojv3LKsoGPIm4Cv+Rkgvo1 x//op4QsGAag== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2020 23:22:15 -0700 IronPort-SDR: 9ZwCBD3A8CQySkV8Y38gn3AjwPf4Q0gFGA3ECIyo8q1XRlt1RMICpeUvb2FLvHea/WjpwExuRa wx3IKtP2q16g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,514,1583222400"; d="scan'208";a="316822664" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jun 2020 23:22:14 -0700 Received: from orsmsx125.amr.corp.intel.com (10.22.240.125) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 23:22:13 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX125.amr.corp.intel.com (10.22.240.125) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 23:22:13 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 23:22:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KYCViOgqgbOu1oCNegdD6i3j6Q+zcXwLRwYzbN8D70q6l+/GJrZHtI5wF1rdj6P2Qqdiw0lHRhaSJ+pYRczrcnkC35knEg2QUhhmqZ0Fvc/hDRrn9FbYBl4pa68ESL95vgAaTalWgW0mYcqPyQNfkrVFsAnhyQ6LhFx6y+mCY8QB5AmvxYtjgu0gqQ2EtfmVcy+JNBsxrL0YcJoXxBDYtPTdpxu4TBXsXAtv9SH5pfD842670gcIgz7fEeIl7LKyS9QQuri4Fuvl+SraC3IYcMA7yUESookzG15Yfv8A8LPpw+e+F9w8bm58zYmikML0neVcJJzMBlHlsEcE7faY3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wvHX6qY6QkkvcP61s6UKdA4wDoAs8wXYDit3h9ce9dw=; b=W90JhWNr+ZoWnGrsV68ZFFW0XbPZtDYVCxPeQkOGlxaFxx6qVER9JlYKn6p8LWo/KHqvOdKDVB+fsea7rCA11G9Sy3YsDs30bLCBjSaGFXjlgmaxZgQdAqDmL6eU0axSOVm6qCLsQrkSmhHRp38JlV5D+EyvYHG/Uj9Hy4Xu5iazZEjCPa1okFxkRtC7sa3bjZdJ2oFSdoQgxogegcM63Ab96Nx5eiyyyx4myNFEcOZDcpIP2jSdj+ejRMjc/522VvHhZgDJUvxvqrqb9pwjEfOmQ1Uw/2Yw678Eyyw4IWo1hJ0KfNuvzsXIHBlMhEA5WB/Hfh5DrAmzyMlIdp4vVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wvHX6qY6QkkvcP61s6UKdA4wDoAs8wXYDit3h9ce9dw=; b=TO7lky2z7aqifMCiUw89Iyg869t34JMZcriCIzQuPYL5bmaMPFYIkT2wLTAX1mrSOBBGkZQO6yBrZS/k8OKDQLpDsfiVhmFGcBUiF59DqLcNj1wSjfc35GK1WtH3XR+rshQs7J/pnMN+kV2LuTgOLS1YdJGPNzFotuyNtZa7To4= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM6PR11MB2617.namprd11.prod.outlook.com (2603:10b6:5:ce::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Mon, 15 Jun 2020 06:22:11 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d%12]) with mapi id 15.20.3088.028; Mon, 15 Jun 2020 06:22:11 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Feng, Bob C" , "Gao, Liming" , Sean Brogan , "Bret Barkelew" , "Yao, Jiewen" Subject: Re: [edk2-devel] [Patch 01/15] BaseTools/Python: Allow HOST_APPLICATION to use NULL libraries Thread-Topic: [edk2-devel] [Patch 01/15] BaseTools/Python: Allow HOST_APPLICATION to use NULL libraries Thread-Index: AQHWQqrB0soDhamonkCZ30PR1AL+UajZM4PA Date: Mon, 15 Jun 2020 06:22:11 +0000 Message-ID: References: <20200615001918.22164-1-michael.d.kinney@intel.com> <20200615001918.22164-2-michael.d.kinney@intel.com> In-Reply-To: <20200615001918.22164-2-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba21afcb-4b94-40b6-3956-08d810f4706a x-ms-traffictypediagnostic: DM6PR11MB2617: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 04359FAD81 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pLVpxCS8U0u/Y0nGzzFhxnh/qBZ0juGuBN5FIzXMXyHRfOhfwbcDszf9R3htyqrdbLHcz06LnOD7IX63C50+b/4tfDfhw8ZrH0cm4YslwqfWWlWWBoMlIbbj7cYxtt7OgdWqUzpZqQmAnRoR6/XGD7X3v6caIi64RXJrbQjenydepchrB9THqHngmBBU8ChVN0dfXtspC5uayYyS6JcDua4n8JhNjhwsIHsPxqdhpjDVtJkiA9keKtSkPth30u2AtEwWwdgAsQ4LFexwEd08vc8bmb4zomJPaHHipZdak5idmcGJJwjG93VBDzMli4BasDLA2C4X/UwxWvw3g9QzWzkGSt1L4NVqKcUAcSTRrU1VpGUMUipNnvUHki3ilsOg92ZEOwThkiIhDH0S2ZraOA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(376002)(39860400002)(346002)(396003)(136003)(316002)(7696005)(186003)(33656002)(6506007)(53546011)(2906002)(83380400001)(4326008)(478600001)(54906003)(110136005)(76116006)(64756008)(8936002)(66556008)(71200400001)(6636002)(66446008)(8676002)(26005)(66946007)(66476007)(966005)(52536014)(107886003)(5660300002)(55016002)(9686003)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 3ny5C8JshogzCzDiNM6K0Ws99XnCeUsDENIe5GLFMH2g64GCmctOxyZ8nm5GTAs40XnEJvBXX7Ruwny3Q+Bb4lSrRbpzU0qiXRvXJTJBtf36rNfquP0eGRXE8iehBIeJSBEEiiOHuqnaJZngZz1YUKVKIQKKtHK/Pl88VXZqzpkgrDm0czhWw52xQMXSV014nA5Rgzm0uFWfWBaiR5iIjKLwdwklrbqrNxulCWCO6s/F2+nC1eJxck9j1hj+h4yg7RsYRE2DX2IhcFStUxaUrqBfvszknI4h0BZxV19B2FLR3MjRkR9kQv8aYyPtvpd0t+EuQutHd05pwNPEc6HK91qoT83ZDZS2eQXRkwV277fVEos0Y7JYlp6h/19bsL/zUNOnZou+ZLC/30a08/S2r5iLsQZePAHM2WtWM/8NImxadIJvT0f95rUJaE4UE43lZGuZFipf0RqN/EBPvCEYpQsO/cGimubhaD6hKeTzLI0l5xmh/yaOm9KHGmp4jfIq MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ba21afcb-4b94-40b6-3956-08d810f4706a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2020 06:22:11.5140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bwzPzCXQenFBQsmr+GwjlmOkWE6c+bwLw68Dcx9zw0SAHI9gsszMVmlpFBaPz8I6D1n2q3mUWKZcJXr8yGqiaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2617 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Michael This patch looks good. While I have a little format suggestion: the Bugzil= la link "https://bugzilla.tianocore.org/show_bug.cgi?id=3D2797" could be wr= itten as "REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2797". Reviewed-by: Yuwei Chen Thanks, Yuwei > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Monday, June 15, 2020 8:19 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Sean Brogan ; Bret > Barkelew ; Yao, Jiewen > > Subject: [edk2-devel] [Patch 01/15] BaseTools/Python: Allow > HOST_APPLICATION to use NULL libraries >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2797 >=20 > Update HOST_APPLICATION module type to use NULL library instances. >=20 > Cc: Bob Feng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Jiewen Yao > Signed-off-by: Michael D Kinney > --- > BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py > b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py > index 913e710fd9..53027a0e30 100644 > --- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py > +++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py > @@ -1,7 +1,7 @@ > ## @file > # Common routines used by workspace > # > -# Copyright (c) 2012 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2012 - 2020, Intel Corporation. All rights > +reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent # >=20 > @@ -100,7 +100,7 @@ def GetModuleLibInstances(Module, Platform, > BuildDatabase, Arch, Target, Toolcha > # If a module has a MODULE_TYPE of USER_DEFINED, > # do not link in NULL library class instances from the global > [LibraryClasses.*] sections. > # > - if Module.ModuleType !=3D SUP_MODULE_USER_DEFINED and > Module.ModuleType !=3D SUP_MODULE_HOST_APPLICATION: > + if Module.ModuleType !=3D SUP_MODULE_USER_DEFINED: > for LibraryClass in Platform.LibraryClasses.GetKeys(): > if LibraryClass.startswith("NULL") and > Platform.LibraryClasses[LibraryClass, Module.ModuleType]: > Module.LibraryClasses[LibraryClass] =3D > Platform.LibraryClasses[LibraryClass, Module.ModuleType] > -- > 2.21.0.windows.1 >=20 >=20 >=20