Re: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI external definitions for RISC-V assembly build

["Yuwei Chen" <yuwei.chen@intel.com>]

Hi, abner

I have a little suggestion for the patch format, it would be better if the length of each commit line is less than 70 characters.
You can follow the Commit Message Format in the wiki of tianocore.

Thanks,
Yuwei

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Friday, June 12, 2020 9:57 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@hpe.com; Feng, Bob C <bob.c.feng@intel.com>; Gao,
> Liming <liming.gao@intel.com>; Daniel Schaefer
> <daniel.schaefer@hpe.com>; Leif Lindholm <leif.lindholm@linaro.org>
> Subject: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI
> external definitions for RISC-V assembly build
> 
> Add opensbi external definitions to RISC-V build for assembly code.
> Use GCC5_RISCV_OPENSBI_TYPES to refer to edk2 data type for assembly
> files instead of using opensbi data type.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  BaseTools/Conf/tools_def.template | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 923517b5c2..8aeb8a2a64 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2037,6 +2037,7 @@ DEFINE GCC5_RISCV64_CC_FLAGS               =
> DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GC
>  DEFINE GCC5_RISCV64_DLINK_FLAGS            =
> DEF(GCC5_RISCV_ALL_DLINK_FLAGS) -Wl,-melf64lriscv,--oformat=elf64-
> littleriscv,--no-relax DEFINE GCC5_RISCV64_DLINK2_FLAGS           =
> DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) DEFINE GCC5_RISCV64_ASM_FLAGS
> = DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH) -
> mcmodel=medany -mabi=lp64+DEFINE GCC_PP_FLAGS                        = -E -x
> assembler-with-cpp -include AutoGen.h DEF(GCC5_RISCV_OPENSBI_TYPES)
> ##########################################################
> ########################## #--
> 2.25.0
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#61183): https://edk2.groups.io/g/devel/message/61183
> Mute This Topic: https://groups.io/mt/74832499/4546272
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [yuwei.chen@intel.com] -=-=-=-=-=-=