From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.3326.1592383881208337182 for ; Wed, 17 Jun 2020 01:51:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OHtnbmFd; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: yuwei.chen@intel.com) IronPort-SDR: udfyT264PrzRrZaebWrRC/oMF1N81VAerfhrz4klgs6q1bBZb9LAxtk/Ywxg+S6TqLKi81eUtw ALuMtRWZBrCg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 01:51:20 -0700 IronPort-SDR: OrttRow7p+7tVnzNPbc/ir8i0eBeWfLzRaCjmg9HiRZxY6kL7ILj6id7gVcCTthYiv9YLaEKWr 5k7FjAU+lZ3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,522,1583222400"; d="scan'208";a="352015616" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga001.jf.intel.com with ESMTP; 17 Jun 2020 01:51:20 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 01:51:20 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX122.amr.corp.intel.com (10.22.225.227) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 01:51:20 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 01:51:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PxxcrVM6g1yu3iwRjAK5kvRPbSBFeHh6G6USAsumOfZnOuZKb3yJFRPOpPzgwMoGzRFaTghSbtSAETDO99IAxGiNmPa2nrlS0nJMhU8CkV3g54DPFOf2ti7P8E1/lMC+zav9MdTq6bkMZluX5e5nEFNgpBZoc64cu3OIpD/3KzgasUqW1jNaB1aPCmKU3CbSLYAVz7bq5W4kFKnGV6LcvuAAjw5kATD1VxskuOYZTYn283Y81ABZbi5/KpuuwdgcxCd1rSiBZ2OvyVtjpuMJ/gaWVnuB/mFaYA7VnpNQ8wg8aZ4lUfIzdB4cmQPjKOWKmFN7WZ1JiGzFdi3LdU1Ghg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2tYJrL/5cZlKPBkN0IoSRyID4KDEY9v48SSLxWkPGk4=; b=Lcp9CdjsBtNN9wqreuAKONS6r8asaIvJKDgRsZDc4aAuU+IbQRbbx8ewfEVzFOoK1zZ68Mp52fCI8CssVxStDRSmIdfsuJ72diIHVhJMw919yQopl3fjPNwUyLZEGrNctiMEAfYlnwLBtRExU0i8EmZWBoaT9y6tPEO0vxDbxz1HWdcI2DlFQLfS0ul/eUUKGF40xJBFVwilrh1KgZ+xoWrXwqoLNZ4oh7ux/QsaGwsmHrxDQsDKQEEPXHGbyFl4QJRQ5ZpRD+ZK8m+JNymxX0rg1l1x7QUGJj0XSCGOcZfb/irfa+pkr5vF/76/jxrXdD79vN34+mjr+Tv03mKFwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2tYJrL/5cZlKPBkN0IoSRyID4KDEY9v48SSLxWkPGk4=; b=OHtnbmFddh8IBmy2WkfKw8AllcrQnpgVVGp7V7MuzGaapUt+sr96f1EhUN/8qFql3tKOu6iCMH+L8h0GFGtxL9VazvZzzcbK56NwacIyPOyfKu1rNMljwavDTySFpMOY0/sMo46bmECUuK9SK0CRojesjIDrximzUgOE5kmdtuU= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM5PR1101MB2201.namprd11.prod.outlook.com (2603:10b6:4:51::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.24; Wed, 17 Jun 2020 08:51:19 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d%12]) with mapi id 15.20.3109.021; Wed, 17 Jun 2020 08:51:19 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "abner.chang@hpe.com" CC: "Feng, Bob C" , "Gao, Liming" , Daniel Schaefer , "Leif Lindholm" Subject: Re: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI external definitions for RISC-V assembly build Thread-Topic: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI external definitions for RISC-V assembly build Thread-Index: AQHWQGJjC+eTkUxmG0iLQlPwtHEGlajchmpw Date: Wed, 17 Jun 2020 08:51:19 +0000 Message-ID: References: <20200612015641.23112-1-abner.chang@hpe.com> In-Reply-To: <20200612015641.23112-1-abner.chang@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed14fc36-844b-4aab-5839-08d8129b9a5b x-ms-traffictypediagnostic: DM5PR1101MB2201: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6qCIsg8c2GesVCzE1pNRs03mLhQA51tcvPZUfQdjGFGbs8dvx+HBGm3MB15v+B4CxU7syj95oYgIfUGR1w8GdAha0ENtBcUvO1JKthblvktMnagYP6hiC+FCbuKWlx6lvag/dYtnWPkKidqRIUdmno/SXHV1WTRp/SOddPR6iklB7gFg52mZRPiF6My5p7hJXix7mqSZ5Pb/jOVAETxQr6hL9jIpnDEmjLx+4NI/elHW0aGegaj6DsCB8YQD0BNgjEzDrstY60yoRlLr+QHk55PdLH6AOc6+Loj5I5suGkwU/xx5E67iKpjLrGjczJl3junZMgKhCTjEiKvn+jKQ8+tWA5z6UQIiUZ3NatbeIhnhGX3LfUbbQHhyUXjIccxf79HQYbWWTrTQOak/9J8fUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(55016002)(9686003)(478600001)(4326008)(110136005)(66556008)(64756008)(76116006)(54906003)(966005)(71200400001)(66946007)(66476007)(86362001)(5660300002)(33656002)(66446008)(26005)(186003)(2906002)(52536014)(53546011)(83380400001)(8936002)(6506007)(7696005)(316002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: IEscX1GSwl30ri85Q8l56uHBmYM4qbgetJ84N4BFBiR6xOfomLOfmxb+Dh8hKTl0jfL0wBUv2aP4oYsWtwUZfAxDU2BoLNEcqAtj9jHF6vElyCfcrBg25sBrAg/QA9/zS6v61K7xjf6cqeR1S2Q6FPmb0lolxo/3hu0ks3XRZbHix9+YQU343za+DOAYsWGT84EjkoLw0WjwVCZWO3Ch0WQxymAynTlR+nKyw4hmPRhTtQ5ntl0sjX5T7FP38ZTMXxRP4IkZckecZr3Je7EstkW0C4xHmBDd6UGBylP02sux67taq7IyHi2yiU3tTWMrFm53VtwlrZ80GHQxuZS7KaYtHnFKONc5St5Fi2XCMYuvGBOlwHbxGRFiFQpXlxNCeiWaQou4mqWm8zjE1eFHy/pg69aM4rPhdQ+73WdqhcpQGE1vV0hST732H7ySndCKxsgwH05eysjN1H4q+ixp2w6uRlFvipFAaosZFNw2Hzo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ed14fc36-844b-4aab-5839-08d8129b9a5b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 08:51:19.0584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p2UkzmZt35KXr2Bpai9MQiv5JlhMF4GUt0zEoMOCnAJ0sQb+ECs1syeqKEEg9NeI12ZXtl7zV1tf7gfHDiLrfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2201 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, abner I have a little suggestion for the patch format, it would be better if the = length of each commit line is less than 70 characters. You can follow the Commit Message Format in the wiki of tianocore. Thanks, Yuwei > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Friday, June 12, 2020 9:57 AM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Feng, Bob C ; Gao, > Liming ; Daniel Schaefer > ; Leif Lindholm > Subject: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI > external definitions for RISC-V assembly build >=20 > Add opensbi external definitions to RISC-V build for assembly code. > Use GCC5_RISCV_OPENSBI_TYPES to refer to edk2 data type for assembly > files instead of using opensbi data type. >=20 > Signed-off-by: Abner Chang >=20 > Cc: Bob Feng > Cc: Liming Gao > Cc: Daniel Schaefer > Cc: Leif Lindholm > --- > BaseTools/Conf/tools_def.template | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 923517b5c2..8aeb8a2a64 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2037,6 +2037,7 @@ DEFINE GCC5_RISCV64_CC_FLAGS =3D > DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GC > DEFINE GCC5_RISCV64_DLINK_FLAGS =3D > DEF(GCC5_RISCV_ALL_DLINK_FLAGS) -Wl,-melf64lriscv,--oformat=3Delf64- > littleriscv,--no-relax DEFINE GCC5_RISCV64_DLINK2_FLAGS =3D > DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) DEFINE GCC5_RISCV64_ASM_FLAGS > =3D DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=3DDEF(GCC5_RISCV64_ARCH) - > mcmodel=3Dmedany -mabi=3Dlp64+DEFINE GCC_PP_FLAGS = =3D -E -x > assembler-with-cpp -include AutoGen.h DEF(GCC5_RISCV_OPENSBI_TYPES) > ########################################################## > ########################## #-- > 2.25.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#61183): https://edk2.groups.io/g/devel/message/61183 > Mute This Topic: https://groups.io/mt/74832499/4546272 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [yuwei.chen@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D