From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"ipark@nvidia.com" <ipark@nvidia.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred
Date: Mon, 29 Jun 2020 00:32:33 +0000 [thread overview]
Message-ID: <DM5PR11MB1594D259A4735A3673234820966E0@DM5PR11MB1594.namprd11.prod.outlook.com> (raw)
In-Reply-To: <09637bf9f163742b1ebdd3700441c4b808e55b50.1591135082.git.ipark@nvidia.com>
Reivewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene
> Park
> Sent: Wednesday, June 3, 2020 5:59 AM
> To: devel@edk2.groups.io
> Cc: Irene Park <ipark@nvidia.com>
> Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen
> error occurred
>
> From: Irene Park <ipark@nvidia.com>
>
> AutoGen manager/workers halt the progress when an error occurs but
> doesn't propagate the error code to main and allows main exit with 0 and
> gets the build system unable to catch the occurrence of an error.
> This change informs main with an error when a progress is halted and helps
> main exit with 1.
>
> Signed-off-by: Irene Park <ipark@nvidia.com>
> ---
> BaseTools/Source/Python/build/build.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/build/build.py
> b/BaseTools/Source/Python/build/build.py
> index ed3a3b9..1ab1e60 100755
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -880,7 +880,10 @@ class Build():
>
> self.AutoGenMgr.join()
> rt = self.AutoGenMgr.Status
> - return rt, 0
> + err = 0
> + if not rt:
> + err = UNKNOWN_ERROR
> + return rt, err
> except FatalError as e:
> return False, e.args[0]
> except:
> @@ -2724,4 +2727,3 @@ if __name__ == '__main__':
> ## 0-127 is a safe return range, and 1 is a standard default error
> if r < 0 or r > 127: r = 1
> sys.exit(r)
> -
> --
> 2.7.4
>
>
>
next prev parent reply other threads:[~2020-06-29 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 21:58 [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Irene Park
2020-06-03 7:23 ` [edk2-devel] " Bob Feng
2020-06-29 0:32 ` Yuwei Chen [this message]
[not found] <1614D8FC854AA05C.21938@groups.io>
2020-06-02 22:00 ` Irene Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB1594D259A4735A3673234820966E0@DM5PR11MB1594.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox