From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.9058.1593390757024522174 for ; Sun, 28 Jun 2020 17:32:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RtZ0SetZ; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: yuwei.chen@intel.com) IronPort-SDR: 9pJnD+KEo0MDyKIas5SnVDQ3GUMTb0XHxwHPU+k4LHUD8MVAafNVdcytALqNe1M14JJNV9lu5m w/B0jeRsn5mg== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="210962447" X-IronPort-AV: E=Sophos;i="5.75,293,1589266800"; d="scan'208";a="210962447" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2020 17:32:35 -0700 IronPort-SDR: mg0RwNHPlAD8BqTsHRLGmRaq5NnMDIigCdj07LWLuH1ZFxn+ZZ/a+AdXxnq2RtBH7G5pzqdiZx CJDDFtcr/YYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,293,1589266800"; d="scan'208";a="386247556" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2020 17:32:35 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 17:32:35 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 17:32:34 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 17:32:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOrDj/1oxcApmTDl7ywMj86qJikxak1vIgaFTaLcOPP8krv/sHWaoZ1GnQ7QTLDA6tYrOcdYLk7g3NQLDPWxpXq1ndsAoe4+0BilhZVSG7Yh932hg//ybPuAkXdPMkArlz+Vt+F4LCj/octINsyaKVyFbmbq+ff61VCtzYojgZE0FsowRWbc4VQCYRiZ1DXQ5COSPI/DpoO5upUo9+cB+L3azkFvlnoH1rNf5Vzi8X9PvjBxnDwqlOQm+k8wBqDo8lZk3GQ1mUSBfFKwaNT0i9NWY6rVDfSNeYF42a4ZMa3WSbPmVH8U7CTnwV/WQjHLJEUNFku47stlSWmf17urog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=05s0AN39nT2XrX33ZcozeLWylR7gBjOOqwaWSEUHp40=; b=Oqv1Rz8HilW4CMepyR1ru2LOdSQahudgzGTwrm4VKXkq+V5Dg5egNF1Q44pgvvy9BEDTt2LmzCyalXiIfeLYQbYkyEsYcTP4cr94t0kJ63HQYmhd6iOv71ancIIAJNczrcxUktAnSuHFaEEmtIwF1XKFo80EtVEBKYneUuUjDSshxQmOxJSJ4Oud0Hx5Q8OxOOKSTRC54suO4OhNK9e1+mgcZi9vPlcj5rCnolgf7lhpsMPshSsQaRC3NeTSQ6pJsX0xWvwTedTmQ+hS/LQNCHlAsSVzhDIql5Wn62kVWdznu+cwXZiGV1S2hXcj6RXAsSZdYe415pxTGOawt2DSJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=05s0AN39nT2XrX33ZcozeLWylR7gBjOOqwaWSEUHp40=; b=RtZ0SetZBkpzQ/F+ZHQnWOlXb8pLtDss34vBYwkofw00U4CFyK+yVIhg7MizqHBQCDqfYSVcz6egyRmvlaNOanWCpFMtubDGeytH+1RbRYQBP+bMkR+JJ2kSNc/h4b38mCnybmZtyzW4olp8vlF52AqWoHDSIF4zmNB6tQW9VyA= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM6PR11MB3450.namprd11.prod.outlook.com (2603:10b6:5:5e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Mon, 29 Jun 2020 00:32:33 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::503:d97b:c650:831d%12]) with mapi id 15.20.3131.026; Mon, 29 Jun 2020 00:32:33 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "ipark@nvidia.com" Subject: Re: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Thread-Topic: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Thread-Index: AQHWOSkWfXAYK3itSEunhTqhlX9Cpaju5stw Date: Mon, 29 Jun 2020 00:32:33 +0000 Message-ID: References: <09637bf9f163742b1ebdd3700441c4b808e55b50.1591135082.git.ipark@nvidia.com> In-Reply-To: <09637bf9f163742b1ebdd3700441c4b808e55b50.1591135082.git.ipark@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2d9322ee-026d-4c30-1be4-08d81bc3ea2b x-ms-traffictypediagnostic: DM6PR11MB3450: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mvfPEcdhPyfHxQlt4vi7wdlBNwVx9m4YAPnzp8W/rYFmDbxBQJPu5IBQbqQ3wuxsvbcsYtYj8m/LpPtoi/nY9Ge6UDRzwwQvrjyKgmXixu6UhMdLn9x3bCj+CPfcb4zFLIMefEukWGhfUHcbQX+2PJJBF/0zQQIplXKWY9F4o3SnIN/HFv8Yp2FJlGkI69YcWjrolJ3fYMf4xoTENWfwuh3sV6CeWXCInhzxHORSOFMPbq02J3C4BObHShg6vQIzskXPmKYsM3+nVQUpoRUQM2g0NUfk4ULVQyPsiNnlDcq7J25ulrP5hgku1Hvyi2eF96cR9F+NHxLZWqbd8AmEkKav6jIFx4wAtcZA1QMrbl2EbN1SqtLSJBPTjkMR3f70lgF+m+3IlxxQOfK611YQyg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(66556008)(86362001)(83380400001)(5660300002)(9686003)(186003)(55016002)(26005)(71200400001)(110136005)(478600001)(7696005)(966005)(316002)(52536014)(6506007)(66946007)(76116006)(53546011)(64756008)(66446008)(2906002)(8676002)(8936002)(33656002)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: DFL9C4Bft0njVDAyzWrLCyn2RPKOtjMsHHz2VpOYaKtiH6sP45mOhoKyQaZEi6fUYb0LoYPpBkNdf/LtdssqfdhOEyoU8ncBbRpb1/cYyoz10QqyvfwcAP77riP6uUsBhZ0lxo8w+wAoz8ja+I25ET8D8Y4u8at9B5r/2Oxz4iljgCjdQwOFZw1HMpDO8zQkZoBrWF0MKu8gIVt+VlW+pgAyzptaD2dReH8EnogVrNFcDkQn91g/KVSMO2OQtV3aw7oBDU0ST2RUqVyNt2zl1dfdHyjdIgphKiJFPYkXs3WbzTD3gFkaVVDgwd68Y0heendruys6Xc7pjTJ1ea9KSLc5vs1QbO5YaxSy14RZ2SrzzGKf1CNB3WRECeHIJcDf8jWJXGNfzhEA4VK6VSv0xYvbND0vt/K+kfy7RdeB7d4/DJzR9oN8ME8K0s5hcqm2yvDmHlcFQNiK+7tfJGSA9EqCOKaNDMuooAW15N3zIZO7IbcUkgnUulJIJ3Chq2Z8 x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d9322ee-026d-4c30-1be4-08d81bc3ea2b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 00:32:33.3022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NZZMcoyng4z/kO3Fnb1D3+q1o8WINWctsW/h8dJnDfxSUTpnRIkyzDUt2fuyhSiFwmVPsOwn4eD/ruxLkJRDZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3450 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reivewed-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene > Park > Sent: Wednesday, June 3, 2020 5:59 AM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoG= en > error occurred >=20 > From: Irene Park >=20 > AutoGen manager/workers halt the progress when an error occurs but > doesn't propagate the error code to main and allows main exit with 0 and > gets the build system unable to catch the occurrence of an error. > This change informs main with an error when a progress is halted and hel= ps > main exit with 1. >=20 > Signed-off-by: Irene Park > --- > BaseTools/Source/Python/build/build.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/build/build.py > b/BaseTools/Source/Python/build/build.py > index ed3a3b9..1ab1e60 100755 > --- a/BaseTools/Source/Python/build/build.py > +++ b/BaseTools/Source/Python/build/build.py > @@ -880,7 +880,10 @@ class Build(): >=20 > self.AutoGenMgr.join() > rt =3D self.AutoGenMgr.Status > - return rt, 0 > + err =3D 0 > + if not rt: > + err =3D UNKNOWN_ERROR > + return rt, err > except FatalError as e: > return False, e.args[0] > except: > @@ -2724,4 +2727,3 @@ if __name__ =3D=3D '__main__': > ## 0-127 is a safe return range, and 1 is a standard default error > if r < 0 or r > 127: r =3D 1 > sys.exit(r) > - > -- > 2.7.4 >=20 >=20 >=20