public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "Liang, MingyueX" <mingyuex.liang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH] BaseTools: Add BaseTools/Scripts/ to the PATH.
Date: Fri, 13 Nov 2020 08:15:34 +0000	[thread overview]
Message-ID: <DM5PR11MB1594D685A25D24F526D9B33796E60@DM5PR11MB1594.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201113060751.1306-1-mingyuex.liang@intel.com>

Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>

> -----Original Message-----
> From: Mingyue Liang <mingyuex.liang@intel.com>
> Sent: Friday, November 13, 2020 2:08 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
> Subject: [PATCH] BaseTools: Add BaseTools/Scripts/ to the PATH.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2859
> 
> In order to have any scripts in the basetools/scripts location, you need to add
> the location to the path.
> 
> Signed-off-by: Mingyue Liang <mingyuex.liang@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
>  BaseTools/BuildEnv      | 1 +
>  BaseTools/toolsetup.bat | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv index
> 5943bb9ef9..15d9f599ea 100755
> --- a/BaseTools/BuildEnv
> +++ b/BaseTools/BuildEnv
> @@ -183,6 +183,7 @@ AddDirToStartOfPath() {
>    PATH=$DIRNAME:$DIRNAME:$DIRNAME:$PATH
>    PATH=${PATH//$DIRNAME:/}
>    PATH=$DIRNAME:$PATH
> +  PATH=$EDK_TOOLS_PATH/Scripts:$PATH
>    export PATH
>  }
> 
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index
> 61ebf4ae09..44c695f83e 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -143,7 +143,7 @@ if /I "%1"=="/?" goto Usage
>        echo.
>      )
>    )
> -  set PATH=%EDK_TOOLS_BIN%;%PATH%
> +  set PATH=%EDK_TOOLS_BIN%;%PATH%;%EDK_TOOLS_PATH%\Scripts
>    set WORKSPACE_TOOLS_PATH=%EDK_TOOLS_PATH%
>    goto PATH_ok
> 
> --
> 2.29.1.windows.1


      reply	other threads:[~2020-11-13  8:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  6:07 [PATCH] BaseTools: Add BaseTools/Scripts/ to the PATH Mingyue Liang
2020-11-13  8:15 ` Yuwei Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB1594D685A25D24F526D9B33796E60@DM5PR11MB1594.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox