Hi Vineel,

I noticed that there are some CI errors still in PR,

The VsIntrinscicLib is only used in OpenSSL related lib, putting it only in the CryptoPkg would make more sense and simplify the review process.

A BKM: NULL LibraryClass means that its internal API will not be called by external modules, the correct usage of a library is to give it a name and use it in other modules,

And this link will be more clear: https://edk2.groups.io/g/devel/topic/what_is_a_null_library/80192232?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,20,80192232,

This is also the root cause of the remaining CI errors.

I drafted a demo patch and it passed the CI test,

Seems we only need three patch:

CryptoPkg: Reconfigure OpensslLib to add elliptic curve cipher algori…

CryptoPkg: Add instrinsics to support building ECC on IA32 windows

OvmfPkg: Increase DXEFV size to accommodate ECC ciphers related changes

FYR.

Thanks!

Yi Li

From: vineelko via groups.io <vineelko=microsoft.com@groups.io>
Sent: Saturday, February 26, 2022 1:52 AM
To: Li, Yi1 <yi1.li@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Huge Thanks for "You can submit PR to edk2 mater branch directly to check for CI bugs(will not be reviewed or merged)."

I am fixing them. Regarding the style(extra spaces and tabs), It is actually coming from openssl when we run CryptoPkg/Library/OpensslLib/process_files.pl
Not sure if there a way to exclude some of the files from checking the style?

Sample PR against EDK2 master: https://github.com/tianocore/edk2/pull/2546/files

Thanks,
Vineel