Re: [PATCH v2 1/1] MdeModulePkg/Sd: Corrections for Extra.uni files

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Tuesday, October 12, 2021 1:01 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; gaoliming@byosoft.com.cn; Wu,
> Hao A <hao.a.wu@intel.com>; Konstantin Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH v2 1/1] MdeModulePkg/Sd: Corrections for Extra.uni files
> 
> Add correct content to the 'SdDxeExtra.uni' file.
> Include 'EmmcDxeExtra.uni' and 'SdDxeExtra.uni' files to their appropriate INF
> files.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Will wait a couple of days before merging to see if any comment from others.

Best Regards,
Hao Wu


> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf  | 2 ++
>  MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf      | 2 ++
>  MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni | 9 ++++-----
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf
> b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf
> index 2afe4f42a985..ec7da2794b30 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf
> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf
> @@ -63,3 +63,5 @@ [Protocols]
>    ## BY_START   gEfiDevicePathProtocolGuid
> +[UserExtensions.TianoCore."ExtraFiles"]+  EmmcDxeExtra.unidiff --git
> a/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf
> b/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf
> index 69b856b665ea..d620e830046e 100644
> --- a/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf
> +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf
> @@ -62,3 +62,5 @@ [Protocols]
>    ## BY_START   gEfiDevicePathProtocolGuid
> +[UserExtensions.TianoCore."ExtraFiles"]+  SdDxeExtra.unidiff --git
> a/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
> b/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
> index eb8ebd5a3594..4651ac42036d 100644
> --- a/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
> +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
> @@ -1,6 +1,5 @@
>  // /** @file-// SD memory card device driver to manage the SD memory card
> device and provide interface for upper layer-// access.+// SdDxe Localized
> Strings and Content // // Copyright (c) 2015, Intel Corporation. All rights
> reserved.<BR> //@@ -8,8 +7,8 @@
>  // // **/ +#string STR_PROPERTIES_MODULE_NAME+#language en-US+"SD
> Device Driver" -#string STR_MODULE_ABSTRACT             #language en-US "SD
> device driver to manage the SD memory card device and provide interface for
> upper layer access"--#string STR_MODULE_DESCRIPTION          #language en-US
> "This driver follows the UEFI driver model and layers on the SdMmcPassThru
> protocol. It installs BlockIo and BlockIo2 protocols on the SD device." --
> 2.25.1