From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.431.1652841680767186601 for ; Tue, 17 May 2022 19:41:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gMw3uR4T; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ted.kuo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652841680; x=1684377680; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ueVWPUuN+m6kS3j4zzIAvgGTSAUEZRjqm6tNH+G1ZnY=; b=gMw3uR4TrSqXy+QbzD2aGvLEGACg3YUqHH83Aehv86RYq7zKgLOpBc/j HfgBr5udPoSe1cbc5XgF9RkVRlqeHtPkizpxl3Q3wDcQu01k5du63SH3X FFPm/lGc5sjArCUhWqw9tM8GbOcav235OhuXsnoh/KDyLhRPckwb759OH IXuUImpl8e3YU1+nib/aLiOkbsWdGXueMHkOjrfUj5xv85dkKmY6drrtH TqVV1Ste/IJHeS8RDWFE/IQ6zN/qQY6GKs0KTBceFZQqdNeuDPaXzJwAK Cfj8eYbdg/lSGB6w6hcmu/mhMlFhTX+JHI2xsueeq7A13ZbpwnlHWaom+ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="296727582" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="296727582" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 19:41:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="700373235" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 17 May 2022 19:41:19 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 19:41:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 19:41:19 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 19:41:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4RgL6/u4BZ7A7A+XZ7dYO60TWbgaP5GLWWpj4mGFsggK3LKIbewKNkryn0K7in2D9Ay5wPYVD3QXi3cym4LH3IEcfch5cnMcfHZzZp1KF1JAIAWjwCPLY3aicNqFqwlxzBWqZRUjrobZr6h30VgxmDPOktsTfXMXHd8tl0Ze6iZ3xtxWvn+ghKU7AlxkY1naxEy8TRVle+QqXNyRrTiI41bxl11ECnWlLrBjN7XgG+52PNjVMyT/mKrIn9S4PPPOlq+x2J7RZRq0jz32K0nQ5/HUVpZSRkXotmVXaJYQhyhr0cviER/vahSKCqW8EhdTZeyOK18es+tAUotGP2gGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S49C3apg8IPXCwE8579Ty8g97g2W/ICs9ctqt9rimzU=; b=boGNAftrWX8FaJmU/l7z5T6MXvbKIV3HktkFqM6GDlAeqfUvMjjCaR8iy5NzchLHtabkYvA5FILc7zVJ9h6+v73KjYmeAC8XbPo/P3Z2PiwPV+dGqf/c36xJ6FVAbIZ/JAeeAUSwkyQmSrmTY6ovW1yjHp343S/3FaFgMNp6yJVImZrU7o2SBYs6ugILR9NDsKS8gYHxi8fPJItOvzah7U8dSIQhNcPO1oO3+p944VDmeJjeFUM4C3f6QLqKbe0E1+elxIP4LKmxTy2KJNZXkCMfainygALO0Qunex1NmBCQPiCpBp5mORZzlxgk/PBTZD6LQ3DHITlq/fTHXKmdmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1929.namprd11.prod.outlook.com (2603:10b6:3:10a::22) by MWHPR1101MB2175.namprd11.prod.outlook.com (2603:10b6:301:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 02:41:12 +0000 Received: from DM5PR11MB1929.namprd11.prod.outlook.com ([fe80::650d:1666:1081:668f]) by DM5PR11MB1929.namprd11.prod.outlook.com ([fe80::650d:1666:1081:668f%9]) with mapi id 15.20.5273.013; Wed, 18 May 2022 02:41:11 +0000 From: "Kuo, Ted" To: "devel@edk2.groups.io" , "Chiu, Chasel" , "Duggapu, Chinni B" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "S, Ashraf Ali" Subject: Re: [edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention Thread-Topic: [edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention Thread-Index: AQHYacpZdft+qyDKz0a09giHVEHwLa0j3SMAgAAQY9A= Date: Wed, 18 May 2022 02:41:11 +0000 Message-ID: References: <20220517084401.1805-1-chinni.b.duggapu@intel.com> <20220517084401.1805-3-chinni.b.duggapu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b674c92-33ba-407f-26f8-08da3877dec5 x-ms-traffictypediagnostic: MWHPR1101MB2175:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QIVsN38Q9GGAClgmszisOmJH0au7xb8EDrExQZI4khhVpotLXVsiggoKJ/by0DMZygzI/kuBqKknxPXFkP6mhel+KaAxFYlRGs+y/a+ubb3gxgoLO/3wGZUZUMYL9GeLau4t9bbpI2OLZqhxOX3p0zKulsvn8Ga3ZHrmtbo+4wVs+yrFYLne9g7sATEanP26u1sekVXOA8yuoi+Y2q5WI5hKjzEd4KKtzwFbtBwzmiw2cDHFVAWipQR8CR3wtSGX8ZP13/YrPDciuUjSvM4n4+4TJ5bqxLNPHtgak5UPPhxDt8MdUFEgvViXnJ9Gvuk1s/VHXLPeOW9Jd45+0pQXhSURkoVFLsu7a9RXJLLU1WSa4StQpvB6ALroQELcZPu35XoTMxW/tyfqQHpVoENnZ5OW8RU6fLGa1KBJ+48lUgB5/33vX9fIqe0UqKSefwwiVX1Wx2DNs6ysG+FhpDJD7bjr1EsNSMTdHHr6HU3k0sYgjs8rUDJSpT/3HajikMl4nSaFUr0fT/mxmlTnSKc1t/OpURgbzquBerl+kMhTa9L931zw49gHCN5kluNE91Kb9xJwupy8odTuB63CJp8LD7YjDIQ3yh6pFLlGyNdU5iuI7aKFmc7IBTpRJ7/HxovzRqaG6udr0eHTUrsbbgC+AVIUJ1VKctSDKz0u5MvkS2zWOjjtu4L+Jdwfif5PfeG0PqPypiVwqTtn8ZuwzBhdQKQTDQKojWKo+kifmRp6Fiymmjm+r3yTSjiZDclgYAb1NAkEkvLDGaGyOfnqq59esXQXKcc61Ib8TLJptlYJpHJNSqIUj1gYA28Cbg2EIi2NZBMjJfxPaJ9vxTa052kPRw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1929.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(82960400001)(6636002)(83380400001)(52536014)(53546011)(33656002)(2906002)(6506007)(110136005)(7696005)(107886003)(9686003)(26005)(66446008)(71200400001)(54906003)(186003)(66476007)(66946007)(5660300002)(66556008)(86362001)(76116006)(8676002)(122000001)(4326008)(64756008)(38100700002)(508600001)(38070700005)(55016003)(8936002)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lWcQlDmtnWKch/HRoCQdbAx5TInixWZM6OE3NyM0gGoXQrP50SWOmN04PIli?= =?us-ascii?Q?ARdf97ABdpPO8CK4YYqyobpHIj1cm6qtD2K8PAXA48B2caI2mn4P77FdNw/F?= =?us-ascii?Q?Y5/GG22F6KiFLFBcT3KPbiNS832WbXYeavURMbgqyB1vDJQxQgM19OzkgETn?= =?us-ascii?Q?5sHmQE2r1AOkT+B/AZ97+D5hyMzBSsfflzK4AqRJZN/f5x6jmclrm+nfHYB3?= =?us-ascii?Q?GTrrctPDqiF7L/Gry4NQEJOFZH1ti4MAx+fQgjfknGBplhNDyWX0WWS1sj4L?= =?us-ascii?Q?0LSEE9fZPb8ic9j6m16esWdsZEWZoSGzVfE4UDRbEpPswNJwArtKyawYlntv?= =?us-ascii?Q?2XaguSDqWjogfzS0LHcEv23PK4YLrqs+qdQJWsYcBJ0pFCCYnXb+M+WKhhQA?= =?us-ascii?Q?sMdDWrsKZtabKMFq8yVDCc5lHq3AjC00kHBgI3dabY9kZCfEagxBr9ZTBOe5?= =?us-ascii?Q?2UIL5FB72DoX/FUjx67eWRs0mvbJl6mS4+8O3WBawl0Aq1tNHAtnsg8AN2QA?= =?us-ascii?Q?idWG7lcUySdVOZIZJtZk0IBsMAYeAZJG5cJ/G4Ir1AMqq0tLVWaiae0Z01Xi?= =?us-ascii?Q?IzDXYiG27m7UdIWwjd1nMDBPAPfZ+XQfm0ZOiEyB0Qms1LYm6EOxB9ld2gX0?= =?us-ascii?Q?tWK3mvkJflKpCe7qQDT0pgjzGj4Xme1bOzQAQCnKHagOA/RRfn4MWSpY6jl9?= =?us-ascii?Q?s9TcRVqSwlRFzMA1Z9qFt9nkQOTVaYzrVBsxOw+IxuhGbImWrwkD+lmVD9IO?= =?us-ascii?Q?APrl5coz6xSJN3cc4eAl9G0fRDMZIzlYbcqLaRjj3GhBH+3XAD8W4HLhKm5i?= =?us-ascii?Q?sF1gkRDigWKn8IvLkWIyphD6Aya4XN8mOYchj8XAGS8p1wV81qs97shYixrn?= =?us-ascii?Q?xu6zD+48Bu4nsLzQzcH3AQwITuBWQxdPVxffKDTWWTB3sZ/ujYxkNPie/OGO?= =?us-ascii?Q?6FwFLdfd3FAqH9yulJYiybj2ggEyjHHQG7WC/8ejD0ITcmNLTmf22aksRKrG?= =?us-ascii?Q?pB9ugBQZINSzkDfzRV2nTCVcASVritRg00nNvL5O94L5XGvR+H9FBba6Yh/7?= =?us-ascii?Q?Ui1fTnwrl8sjK1k34WXl+2IxYq/Slz8z65J91P6ODUsdn/Hi3DetUA0WQgr2?= =?us-ascii?Q?63JBNV6XmlCfP/0PHZHFe5eFwLIGyvneiwdgUmuJfEB1ulwTcdWgPGy5SzFz?= =?us-ascii?Q?vPqsJg7OwF/TMpIhvMRzk+E6HfT9ngnA7OMXHUVY9OOoU2NnnEaM8eRlmfvP?= =?us-ascii?Q?GMziSIZRaZmRfJNj6e6pHNhNb1oR38YXgg5LLzLjPfT9k5YPZsaQTkVnupvW?= =?us-ascii?Q?nyTYw631z95oArY1nUC8Mh9JmJvIkl7TU+u/HsjmquK5Jocyt4Y4lF6155ij?= =?us-ascii?Q?TNzfHA4F4k7LVhYNSkyNNPIYsvzkyKwRlN4wguczTyc/z8P/3DiZXqF12SOz?= =?us-ascii?Q?b7BRM5J1XxYHh3hIxpmBNOyJv/zSMB5mnGHHPU/bp0HZMjLNwI912KnPk+1D?= =?us-ascii?Q?EYmVOAsJB8CGzKrJYKa3xb1PyJ1ANO1nDx92J0/6bYgnsNmR8gZhmFS01jK6?= =?us-ascii?Q?ErP2QGBBzfn2yU5crplQEc7xVVg6LzJCL9zdZI53Pt5UvF/29TNETkAe9p5S?= =?us-ascii?Q?gKTSQH0a5QGEWjJ2kacswWShx84H4hlwC1n6QOInrwRl8OcsL0xK3gFgVOtv?= =?us-ascii?Q?3j2XJyXfNT/+Wzo9I+3AZn4Sa+Hafx/M7H0vKa07anBpJzXjrDX0sUfhNhB0?= =?us-ascii?Q?jyeA+cusvg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b674c92-33ba-407f-26f8-08da3877dec5 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 02:41:11.5603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B1IlMSdXVsdNnoEAf5p5COcHWvcbZ+jzm86Lq2s+mJbhPSGsJQpMsK7f7cNgHSOIdYtbDejXn3A5uDE1EqgLxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2175 Return-Path: ted.kuo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me except one typo. Please see my inline comment. Thanks, Ted -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Wednesday, May 18, 2022 9:41 AM To: Duggapu, Chinni B ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star ; S, Ashraf Ali Subject: Re: [edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_= INIT call must follow X64 Calling Convention Thanks Chinni! Reviewed-by: Chasel Chiu > -----Original Message----- > From: Duggapu, Chinni B > Sent: Tuesday, May 17, 2022 4:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L=20 > ; Zeng, Star ; S,=20 > Ashraf Ali > Subject: [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call=20 > must follow X64 Calling Convention >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3926 > Pass Input parameters using RCX. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ashraf Ali S > Signed-off-by: cbduggap > --- > .../SecFspWrapperPlatformSecLibSample/X64/SecEntry.nasm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > index dbbf63336e..065d80d0e2 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > +++ > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > @@ -130,6 +130,9 @@ FspHeaderFound: > mov eax, dword [edi + FSP_HEADER_IMAGEBASE_OFFSET] >=20 > add eax, dword [edi + FSP_HEADER_TEMPRAMINIT_OFFSET] >=20 >=20 >=20 > + ; Pass Fsp T Udp pointer as Input parameter [Ted]: It should be Upd not Udp. >=20 > + mov rcx, ASM_PFX(FsptUpdDataPtr) >=20 > + >=20 > ; Setup the hardcode stack >=20 > mov rsp, TempRamInitStack >=20 >=20 >=20 > @@ -167,5 +170,4 @@ FspApiFailed: > align 10h >=20 > TempRamInitStack: >=20 > DQ TempRamInitDone >=20 > - DQ ASM_PFX(FsptUpdDataPtr) ; TempRamInitParams >=20 >=20 >=20 > -- > 2.36.0.windows.1