From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.771.1594789716164832973 for ; Tue, 14 Jul 2020 22:08:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qzGKK2rF; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) IronPort-SDR: /6jVmDTGygK7mfTPSlUnqsP2PZuKmJQbqknOK6Rt4q9zlyTh6Sw6wXFNR8U8kLC7UlJppSYXp/ lmQspw+hVCig== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="128645336" X-IronPort-AV: E=Sophos;i="5.75,354,1589266800"; d="scan'208";a="128645336" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 22:08:35 -0700 IronPort-SDR: 0uc1m6lIOrP+To1SrX15ENckTXNrP7W6shevnBNu0f4PVve7gALRDQGGUiS9Y+YjLd92B7EsHq 4FOUexzPHjkg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,354,1589266800"; d="scan'208";a="316601078" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 14 Jul 2020 22:08:34 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 14 Jul 2020 22:08:33 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 14 Jul 2020 22:08:33 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jul 2020 22:08:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYjPD8bWKVPASCufkr2CtDc2JLBoiUPgiylj4NOOkq31z+Ki2YCrypE2rhrvvwtVbrOzXYq/AuJurEqaxGK8PryDnUMtEYhuP4gEMMHGP2vinaK/CfuHLCho9rA4yVwPdUvI73H+T2V+Ry75LVN9zwJ4rRjcF16BHU1gAhDK1F3fRorsarojThFS0WMhRl4FFeBB+XW28EsJus3AWABmZUaGAhMNByg5uDOVL5UkaHVzjLaJg0LkjkQeVydXESZY6Vloe9HaB17WLxCRZqdCcOkZKAo6OeHlC82WBENuwP6sDUy6AWW5Vdx8vHi/10GhwFpXwkPyhOg/emZWuSphwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQc8XN+yo2sbA06gS/IKOH7DljoPRY//2XHosyODbsM=; b=eM+B1J5zVBF4KBp6GhVmf/ASunHbwIoiX4e+JqGEzoqlTdCSEd9gaYvh2mfw5Wj0HLBzhWpa+fyJG/mADah3gjzGciPoIvjxJFFeRRpFTbYcmLC7EENeLhbZVvpmN2+qOIOUgOOJfN2x/xB3sWHU+U3RvjH7Z9uvTXt/J7ZO+9K2oMqznv0FxqPhcouISY/33tKqwrvqQ4SL1cdFIQQUgjgbK3NZ2KQ1+EP2aa8+I0XKpbybU0o5ZO5yJ+2PUfveoXfzm83ivo/UdcVYwgVYbqhEmEWoLAvC0/B/k0cIPB64jAsm91/ZVW9ZpBTL1lomM6YvQ8eQrBUTQNpRUotemQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQc8XN+yo2sbA06gS/IKOH7DljoPRY//2XHosyODbsM=; b=qzGKK2rFnXbwAS0SEn+lQ7EN1/xxR7VlqF6zWaeph/809Uxk4W6hRXuBjfZ/lvztL0gQ9qwrfVluwcagvcLVp2XSeEKqt3565WAA+70yBKvQdfrhUcI2oCQSNUKlltthXXYW9fnrnd+3LTzOoCYzuTVZyi+Fpv5/ViTWRDIvPao= Received: from DM5PR11MB2026.namprd11.prod.outlook.com (2603:10b6:3:10::17) by DM6PR11MB2585.namprd11.prod.outlook.com (2603:10b6:5:ce::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Wed, 15 Jul 2020 05:08:30 +0000 Received: from DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4]) by DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4%4]) with mapi id 15.20.3174.026; Wed, 15 Jul 2020 05:08:30 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. Thread-Topic: [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. Thread-Index: AQHWWar5Wq9MxN8Sv02u5OkL57B49akIFgLA Date: Wed, 15 Jul 2020 05:08:30 +0000 Message-ID: References: <20200714064922.7025-1-qi1.zhang@intel.com> <20200714064922.7025-2-qi1.zhang@intel.com> In-Reply-To: <20200714064922.7025-2-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWVkYmYzYzgtZGI4Ni00ZTlkLWE5YzAtNDhiYTU2ODA5NWMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMW1haVRTVFJLeXIxVWxhTkgyMHZvTUFsRzJWUTdwTWFYWFVkR0NxSzNLbjM4M3VnaE50cmhvV21xYXJ3UG0rNiJ9 x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0eaa554-4e2f-45da-a80a-08d8287d1dad x-ms-traffictypediagnostic: DM6PR11MB2585: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xtzlFQwzEcCwEFYMhQTiSlHF57guGFdnX8bEuKvjCeU4QzJBhFD2cI5C0c/YxIouk+cCeIOhc+U5jIoYKO1qfsVBl47AdqxCMI4yf9o26ZuTWDgHCEqFLtFjk3nsBf3MX9TKOlwRd3047r8uFrmnRi+i4noVDlrgeuwA5WTaeaP7xhHoDiRDzSOsWGuW+Jk+MgQpuFbQnY1b/5RgDJmaAVNVD6EgHNXG2BDV/SuCE2TMphGoRdEyvR47/rSVnhcOWW69UzCKm0Mk43OfLfR35R6+uMfsl+xnx9+LQRXTIqgLMPuUdCFvgeDtVMMrENWtoKY2q1wcQh4ZG8/IhJMzvHeP7iIY27b40kMkhk8di+Ke/ph3ktZnqAUcxdUucEx0bsxd1ueQQ/CHWupsMSk38g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB2026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(366004)(39860400002)(376002)(136003)(66946007)(66556008)(33656002)(66446008)(64756008)(76116006)(5660300002)(71200400001)(186003)(6506007)(15650500001)(66476007)(55016002)(966005)(83380400001)(9686003)(478600001)(8676002)(2906002)(52536014)(26005)(86362001)(110136005)(53546011)(4326008)(7696005)(8936002)(107886003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: a9i/KtjBqaleHrmfu2Fi6E9NVwruptFAJm447GD9hmajXH0wDP2p/EKQcAA+vSLaVW5JjVftYD/2PzNu+aQ4bYXjfpvAAOasNQUiKnV0MxCYvhwWmRPAjvA5qK2fhz1rqYh2nihDGFrVwe1FFmYAUJ+2/um30fiWcPUBGBArUTS3/4d435DseW71rG2HbY0HEe2XHTERDHeVEnkbexhNM6os9RDcdIJRn/DmLzNVVHu5fsuPjNBkUaEoV6uq6edE1Yaij6BvqvWq4Qoakd5IMXvL/RDQs5HhclMuDp4rcgNfOskOO728JT6wqmb/BUiYDw0rircngb5o/HWY7F4qPhQMkE838GHs8XZsIMJZ+Oz3LDw7cqOSPjWC9LoistcMGTKmpB0IC8Nmvd6zlejTWUQwqkfzZEpgsEn7AZUEu904ElSOMHGbGZY/9QRHtVKOD4bKhFgJs7okIaVgCu11QZ0H6jOwM0KQ/mlLJOC+el/7eHSUIb1h6Sq5sXOA118l MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB2026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0eaa554-4e2f-45da-a80a-08d8287d1dad X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2020 05:08:30.5198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q7+vRKPLL6jhQ2wx0XkfMH9H3iTJdu1G0q9Ya5YoM48P7DrqteLkcnOZoT8k8BeO3up/1G+xhiSpFwDbbBxqTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2585 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Qi. I just thought one use case that a PEIM may already have a calculated hash = (https://github.com/tianocore/edk2/blob/master/SecurityPkg/Tcg/Tcg2Pei/Tcg= 2Pei.c#L652) We may need add a flag to support this pre-hash use case. Such as: > +(EFIAPI *EDKII_TCG_HASH_LOG_EXTEND_EVENT)( >=20 > + IN EDKII_TCG_PPI *This, >=20 > + IN UINT64 Flags, // new field. BIT0 =3D 0 mean= s HashData is the data to be hashed; BIT0 =3D 1 means HashData is the pre-h= ash digest. >=20 > + IN UINT8 *HashData, >=20 > + IN UINTN HashDataLen, >=20 > + IN TCG_PCR_EVENT_HDR *NewEventHdr, >=20 > + IN UINT8 *NewEventData >=20 > + ); > -----Original Message----- > From: Zhang, Qi1 > Sent: Tuesday, July 14, 2020 2:49 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Chao B > Subject: [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. >=20 > From: Jiewen Yao >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2841 >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Signed-off-by: Jiewen Yao > --- > SecurityPkg/Include/Ppi/Tcg.h | 50 +++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 SecurityPkg/Include/Ppi/Tcg.h >=20 > diff --git a/SecurityPkg/Include/Ppi/Tcg.h b/SecurityPkg/Include/Ppi/Tcg.= h > new file mode 100644 > index 0000000000..4eacd57166 > --- /dev/null > +++ b/SecurityPkg/Include/Ppi/Tcg.h > @@ -0,0 +1,50 @@ > +/** @file >=20 > + TCG PPI services. >=20 > + >=20 > +Copyright (c) 2020, Intel Corporation. All rights reserved.
>=20 > +SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > + >=20 > +**/ >=20 > + >=20 > +#ifndef _TCG_PPI_H_ >=20 > +#define _TCG_PPI_H_ >=20 > + >=20 > +#include >=20 > + >=20 > +typedef struct _EDKII_TCG_PPI EDKII_TCG_PPI; >=20 > + >=20 > +/** >=20 > + Tpm measure and log data, and extend the measurement result into a spe= cific > PCR. >=20 > + >=20 > + @param[in] This Indicates the calling context >=20 > + @param[in] HashData Physical address of the start of the dat= a buffer >=20 > + to be hashed, extended, and logged. >=20 > + @param[in] HashDataLen The length, in bytes, of the buffer refe= renced by > HashData. >=20 > + @param[in] NewEventHdr Pointer to a TCG_PCR_EVENT_HDR data > structure. >=20 > + @param[in] NewEventData Pointer to the new event data. >=20 > + >=20 > + @retval EFI_SUCCESS Operation completed successfully. >=20 > + @retval EFI_UNSUPPORTED TPM device not available. >=20 > + @retval EFI_OUT_OF_RESOURCES Out of memory. >=20 > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. >=20 > +**/ >=20 > +typedef >=20 > +EFI_STATUS >=20 > +(EFIAPI *EDKII_TCG_HASH_LOG_EXTEND_EVENT)( >=20 > + IN EDKII_TCG_PPI *This, >=20 > + IN UINT8 *HashData, >=20 > + IN UINTN HashDataLen, >=20 > + IN TCG_PCR_EVENT_HDR *NewEventHdr, >=20 > + IN UINT8 *NewEventData >=20 > + ); >=20 > + >=20 > +/// >=20 > +/// The EFI_TCG Protocol abstracts TCG activity. >=20 > +/// >=20 > +struct _EDKII_TCG_PPI { >=20 > + EDKII_TCG_HASH_LOG_EXTEND_EVENT HashLogExtendEvent; >=20 > +}; >=20 > + >=20 > +extern EFI_GUID gEdkiiTcgPpiGuid; >=20 > + >=20 > +#endif >=20 > -- > 2.26.2.windows.1