From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.6964.1594972077148381540 for ; Fri, 17 Jul 2020 00:47:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XEsvcFXk; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) IronPort-SDR: VQThw9Kh1Q3YuHkqA6JTrjURm2zWXJXzoTTeEEx31wlOI+HvlqtxD2oQyVyXg6PaVRNF3NfCSn WaOFd94CIhAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9684"; a="214271304" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="214271304" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 00:47:56 -0700 IronPort-SDR: MxCBG9RYsKjMVFY6lQAKQ+7wC5/YJRIbDLQScCxk/6aT1rJ8jACyYQvyALFwRVK8w6MFkKAESM ZUhcIQshndDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="325366950" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jul 2020 00:47:56 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 00:47:55 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 00:47:55 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 00:47:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UeSY2Ou/cR2eFUoSdvzDtPbnam7agJv0g+goT3o8S0MbfFw0y9SaekEalbjIC1r4luLfNa4xj5I77EU30+RxTxGjfJor8yb5bXUZrXGcIt5loLHKU52a0oUTmEdF5N9vBnMWqH3zmFqZBibZQSV7PytriJ872SVuN813xJLWg/kZfTNlavGYy2zs0AeDqcQPGrBmMNySpEwtiHS8z0JEtQioBkWr8cLX39DPaQem9eD6wQEHOBWfvpJg7gaGEP/A5U/rig6+cuowSjtzwimw8YIuaT3W0rneDvFGuvkEHGD5aWMbuMOLYm/m/QXViRNOkjRNqpsvBP0IxSOy0KOOUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eueTscZWOYijp9eau5iVv0o/JjV7IfrmWKEjpB7GVtw=; b=GPiPHsIRpjNLjANo5Du8bb9ixyWf8lkGRxVyqv26EWUekn4+Z6nn9U/u2EWyHiYE7uj17b4mZQLtnwI7i2MIkykFFy2aE+Paguqrd09ej/x3twERl1ZHM94TWTqxmjjwGIqGhciAFocEcRG35BkQx3gOLfswH54f9lwLYStXxSpFiZSPV2euqieeIS853uHEYSXEXoXo3uS0S9oYRluwI7j4otkcIBUmRmibGk7xisxkuj+Z9VisPh19mFp4sehA+boa1IE20HDNa8JCiqPZVSQEUv6rPyXOpnyvecZnhU5ZrSNdxOkrmaoGPxyC25CC15YQBLJxEqrjJATxgvypeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eueTscZWOYijp9eau5iVv0o/JjV7IfrmWKEjpB7GVtw=; b=XEsvcFXk24sMT/pC+pe71zqM7DlOeH1gueecF/4iJuxxmtFR7XY0HTI0efCWUExAV1upNQbxwJ6oGqBTPrr1Yue/MGdKv26JQvtKBE1n2R/MRARxLO497BO3aiuY85ZTlSSWq8NaP3Vsi6LOeSTie99nET0sdslUGAIGrtaiCwE= Received: from DM5PR11MB2026.namprd11.prod.outlook.com (2603:10b6:3:10::17) by DM5PR11MB1882.namprd11.prod.outlook.com (2603:10b6:3:10a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Fri, 17 Jul 2020 07:47:53 +0000 Received: from DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4]) by DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4%4]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 07:47:53 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , Chao Zhang , "Kumar, Rahul1" Subject: Re: [PATCH v3 0/6] Add capability to let PEIM extend TcgEvent Thread-Topic: [PATCH v3 0/6] Add capability to let PEIM extend TcgEvent Thread-Index: AQHWXAyPInM2YCM3qEC7TWInqd6AeqkLZAAQ Date: Fri, 17 Jul 2020 07:47:53 +0000 Message-ID: References: <20200717073312.10594-1-qi1.zhang@intel.com> In-Reply-To: <20200717073312.10594-1-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmQyNjc5M2EtNzE2NC00NjliLTljNzYtMTMxN2NmMjU0ZjFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmhoaEdlMytxaTZMa2ZjNFFZQ2pBNytRYkI4NVgwbVBTbVFFeU8rYlRUdEJmVzEyWWxnNTVcL2pNN2pZZDVGVHEifQ== x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59b93b54-5750-4d7a-6c4e-08d82a25b687 x-ms-traffictypediagnostic: DM5PR11MB1882: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 07kjoB/EOFTuOFh+BZubfIyTkrwWhx1wL84qqmGOL0vZOXRlMzZXZh/6aXllLFHUQoUQpj2u/Dc6rSDweJI8HOcWiGRTflgD7YG4uQaMtmRqFnKInbSs6aCBvvGH4D6Spr+ztOnprqwXaphBzrL68Cj5QkQVjKfba9rX8xcEaT16mW0m08QtL6bA3okPCZvhMVq3O4YJ/FGsbE4Bm4HFvds21JrhbkVsZMfD/Ke6GIXw6XOVq1ecWwDKtBW0k0CNNWFVn6lxXVhAiOoekMUx0/BBdSbj1hqFYIlzcYreXUvpUYxpGLWSTrQ3LKrRn4cYdEQ69I4URIK7GzjPEcVJe13YDwqnyjKuN8VXa9I50CkuE8BVII/+OIbyTkCT9AO1+qNkDmtINDZsZQiZtIBeHA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB2026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(39860400002)(376002)(346002)(396003)(136003)(76116006)(2906002)(8676002)(71200400001)(54906003)(478600001)(33656002)(66946007)(26005)(110136005)(55016002)(5660300002)(4326008)(86362001)(966005)(9686003)(107886003)(8936002)(316002)(83380400001)(6506007)(52536014)(186003)(66556008)(19627235002)(53546011)(7696005)(66446008)(64756008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 5eJ25uiRvjnPbH9ssjaCA7wtzqwv71ht1U6IjAE7tSZvn57DJe4pSzc3UxzR634owfx5c0JA5bs1aDkSmXtUPyJ9rP5gtrWBN2Ck+jHVOhJ627IzgPhQ6lypby8vfAeREqA82G4CuZclyRw43ZPuE3LgBRtx/yk9eItj0HK9gIHdd6SoSXq1bGOOJ0v3oJc9Xw3OJNQxn2D6HJVrAXs/64hMlsYqZqg788sIR5d2NZ9RdwTOwa2l1Qijh6ZAEPD0hIV1hIPers+w0WI5Xw70ZBHYkc4R6VaNl6/XOp8UrsV75kvG1wwj+Tk4q/PlbXWMgXeR6TFtpRh3mySKyHtbD8ifmdy7aI5mxJvitAyc63dIOJiuOdmk9nDcsnuCXmYyLYIHsFsIa/cLvDs2Deae73GGk4imiXPj1CWrip7YOmYfySpsCOVUhWmCN08N3K7cT5shMy3X9GEjnMSfn31lmxVafbQKsmV2ttLody3pkjsl//rMOem0n9xQ1DzA19tq MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB2026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59b93b54-5750-4d7a-6c4e-08d82a25b687 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2020 07:47:53.6100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0a0Ak2B8/uZBqCAlcUDe/qBgADbZa148up/ap5ZrrME/Z5cAl7ZA+7FzD3f4DMF21b1m4khinIGtKDJbGOb3CQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1882 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you very much, Qi. I forgot to mention that we should change the name EFI_TCG2_PRE_HASH to ED= KII_TCG_PRE_HASH. The EFI_* prefix is only for standard defined protocol/PPI. Since this is our EDKII extension, we should use EDKII_* prefix. With that change, the series: Reviewed-by: Jiewen Yao > -----Original Message----- > From: Zhang, Qi1 > Sent: Friday, July 17, 2020 3:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Chao Zhang = ; > Kumar, Rahul1 > Subject: [PATCH v3 0/6] Add capability to let PEIM extend TcgEvent >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2841 >=20 > Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE > module extend the TCG event. > There is more and more use case in PEI phase that a PEIM need extend TCG > event, such as BootGuard, FSP, Microcode measurement. Currently, we dont > have API to do that so that each module need create TCG/TCG2 event log, > which is a burden. >=20 > This bugzilla requests to add PeiTpmMeasurementLib instance. >=20 > The implementation includes: > 1) A EDKII_TCG_PPI which abstracts the HashLogExtendEvent service. > 2) A PeiTpmMeasurementLib instance, so that a PEIM can call this API to > add TCG event. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Cc: Qi Zhang > Cc: Rahul Kumar >=20 > Jiewen Yao (6): > SecurityPkg/TcgPpi: Add TcgPpi header file. > SecurityPkg/dec: Add TcgPpi. > SecurityPkg/Tcg: Add TcgPpi > SecurityPkg/Tcg2: Add TcgPpi > SecurityPkg/PeiTpmMeasurementLib: Add PEI instance. > SecurityPkg/dsc: Add PeiTpmMeasurementLib. >=20 > SecurityPkg/Include/Ppi/Tcg.h | 60 ++++++++++ > .../PeiTpmMeasurementLib.c | 74 ++++++++++++ > .../PeiTpmMeasurementLib.inf | 50 ++++++++ > .../PeiTpmMeasurementLib.uni | 17 +++ > SecurityPkg/SecurityPkg.dec | 3 + > SecurityPkg/SecurityPkg.dsc | 4 +- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 110 +++++++++++++----- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 3 +- > SecurityPkg/Tcg/TcgPei/TcgPei.c | 61 +++++++++- > SecurityPkg/Tcg/TcgPei/TcgPei.inf | 3 +- > 10 files changed, 351 insertions(+), 34 deletions(-) > create mode 100644 SecurityPkg/Include/Ppi/Tcg.h > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.uni >=20 > -- > 2.26.2.windows.1