From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.8888.1595290378367043427 for ; Mon, 20 Jul 2020 17:12:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EjwoH7rU; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 5LkVh1P58Xf4lMvEJblsBF5RxA5dQ9F8P+PsMuT/GHxnzf9gaUrLo6aHajwG2qoK8MLz6wxvqt rC5lMjXEFF6w== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="234883070" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="234883070" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 17:12:57 -0700 IronPort-SDR: c1qVlZNL0WE5tgg61cXK0LmHxUjhmusu77lQCWou4yq/m528iYlJ5GsUWTjnjOgX8UTD/ZtiqZ fkJP242SXhKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="487422902" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2020 17:12:57 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 17:12:57 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 17:12:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Env7pHxx+HHQIMIwDz1W47H7WkyrbGOJxm6cpr7tQ40FAXgGCGena5GBD3xjslGGNFJWEoKJfcU0BpR0SvcYUd4MAUJlP9sIY2CFA1fNZssBg2bh8lvHCtx4ly3dRapdzWlMuxc3MpcOt4GcAvCb8JRL4JBGytaNIn/HZzArM9P2qr/4hcW8C/Bap3N4rGv3L3HhvJEBFNKDOP7WSOpHWtZj3zzAY/Be1pOaM4g7/V2X55aOZMTBItGFbqryV3MdegbmUxPhSeTgPfye7A/HI4lqkW/yGSBVgXbzaFH1ez2WTm+NtvBYs0Ye6k14v5keDDV/deowNbFV4jxjIUmm5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kmwm/+hfEerYcirPPj4t1EfgtiExB1CxGuI2GR0FiiM=; b=DVrH7skoKNUorqGNYG+bS8BpbKbbumdVJYqRRbJZ5Vk4DB73XduW5rPAz2yco4i0gONu8cbbUUcCbz4D68Y23VmgqXvtzp9jcHxfqITpT5EUUKZbUVga8MWDXIG/XH8K6VPA8eiiYXoGkxOsPxfaTF4Dc0aF+ll6osMT6IDe9yI3ihCJYW6KDx1YHJ/Ukl/lqeY5A8QlOXSXJzSg9iFLntjjOlB/YjYi/zkvS0xtAbxfUydkpDjy9N9v+/1C2hju8lB97TuJl1TRsO3EnY5Bnk/eD5XGa5flSQN7lH5beR6qw9ifNUn8auTObvhQPRaWhQPmNjPu53tUZlccE23Cng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kmwm/+hfEerYcirPPj4t1EfgtiExB1CxGuI2GR0FiiM=; b=EjwoH7rU9n2F6fK+vo8AWJ19wblkn1s0JQLkQFoltzG4oHpq7XjpvEgt/9C9i9Vl6Y0u1KRPThj6qfXzTSJEM3kmZNffVLjqixSctLXHoPi3wiHuQA/LgFAWG8+vegUbxSB8hG0vOAX9sjpw00mHI++3wMkxdxC+fF3oiiyVsng= Received: from DM5PR11MB2026.namprd11.prod.outlook.com (2603:10b6:3:10::17) by DM6PR11MB2553.namprd11.prod.outlook.com (2603:10b6:5:bf::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 00:12:55 +0000 Received: from DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4]) by DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4%4]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 00:12:55 +0000 From: "Yao, Jiewen" To: "Gonzalez Del Cueto, Rodrigo" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] SecurityPkg: Fix GetSupportedAndActivePcrs counter calculation Thread-Topic: [edk2-devel] [PATCH] SecurityPkg: Fix GetSupportedAndActivePcrs counter calculation Thread-Index: AQHWXu8IvwMZEh93I0Cscusfeba3QKkRIrJQgAAEnICAAAEqwA== Date: Tue, 21 Jul 2020 00:12:55 +0000 Message-ID: References: <20200720212637.48-1-rodrigo.gonzalez.del.cueto@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzQ4Y2FkZWUtYjQ2Ny00N2FkLWJhNDUtMzUyMTRjOThhZTVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGNKZDVMS3c0T0QwbGRsZjczclNsV1pUZlVCTm1TZ2xNZ3pIUEJHUTFzemVtYTNacGZQTWtaSEh6aVVqYmdOVSJ9 x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6788b6af-e772-4df7-a5d5-08d82d0ad10c x-ms-traffictypediagnostic: DM6PR11MB2553: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:489; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zdyPOofkkjcT0JwLmdhYeNXgDQ+PLOyXM2Q9pmbO0sgR2/gkFaLQqRSOIGNHAazslQQnMhJmt1tZSJYo83iclLLmESUr38HJrHovQYy51YlbWZ+c7qtPFHtENsM+++7FdOZSzcB1SN7r50ecmzp/emDvRwFmOFDRc2ugb4cP8y4W3IP064v/toP/LP16jIWH1do2NHgDtCvWRHKhW6WjlbeoM4Xr7F44Sf5+f7xhrupDJQtSnX3qlxo5z02dSCMF9OA59mxgzbbWCXY6Tptl35kM7WOI41cWunw6f6SzGVHQEcN4avA7LDyZa5QjaZerJ3+VWY6M+eOpibfp2Andu8Sc3lNS32jbL8+h0R29qqs7uPqxv50DgxblELUWzwfw9oi35n69+WfYpnmqoAXQDIM70nBQEG4zfvtVbMraQe42tWIJ4anUtx9u3JvLJA/qvELtoFHgDp8MyUaf+9fb3A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB2026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(66556008)(66946007)(76116006)(966005)(64756008)(66476007)(7696005)(86362001)(55016002)(83380400001)(66446008)(2906002)(9686003)(8676002)(8936002)(30864003)(33656002)(5660300002)(186003)(15650500001)(53546011)(6506007)(52536014)(110136005)(316002)(71200400001)(478600001)(19627235002)(26005)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: mvQm3fa+t8PggzDbIHUTo26w+sXkW4oVxt9XI6v/vxglGmB2Ay4Lx7NZJF2lH8ZTY4zXRhbvBQahyz+2KGyqNA61uBhDqQVcm2VjFEMynJMkPNYv7VcrHcTSbGqy5YmyLrMCFftCxuoVhLKGYq7DRDjgojXOkvkI15OzafXkep6Utq/LRpYcSixoPX+4kEz84Uz6wdlgM0rCJXeGcsx0AzEgNYLHs+nalSctNpaIG1tn7rvucD+GYdO3RL/YJdGRn6uhA6ZMbXQClGgH4I9l7h6dHbvWCQjs4fs95v2HHTnJArBJos+hyQeSjs5fSXeJDpRLi/WjdmvjfWZzqi6RktSGCv4pIabHTR2PKLP7GNFgZqDDKveucrkoilU7mOt39oM5C3X/+cIc2tZvD6h4c4SSuiufdH5Km3WUaHXvIoUmZm6sgD1CukOR2wGAMuxPNQoUxUzeNdhwS/nThrN9WNmgiXbB++/4ZnVu1Jsl7hbS9E3yICwUowYvItiyqmxO MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB2026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6788b6af-e772-4df7-a5d5-08d82d0ad10c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 00:12:55.1245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wln6fRseluTtKCVT/cviGgMhOiPLlMoVOzMe4uMTS+2dmqk8sYwHRPnvjqP+1Ao3K1CpgZsA6tf+/sKmQayXbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2553 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good to know. Usually, if I saw second patch, I will override the first patch.=20 It brings confusing in this case, because I notice that there is NO signed-= off or Cc in the second one. It seems in invalid patch. So I will ignore the latest one and just review the old one. I recommend do test/debug with a test patch, not a real patch, to avoid con= fusing in the future. Thank you Yao Jiewen > -----Original Message----- > From: Gonzalez Del Cueto, Rodrigo > Sent: Tuesday, July 21, 2020 8:05 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH] SecurityPkg: Fix GetSupportedAndActiveP= crs > counter calculation >=20 > Hi Jiewen, >=20 > Sorry about that, I was debugging my git SMTP configuration and I might h= ave > send the same patch twice at some point. > This is the version of the patch that should be reviewed: >=20 > >Subject: [PATCH] SecurityPkg: Fix GetSupportedAndActivePcrs counter > calculation > >Date: Mon, 20 Jul 2020 15:27:13 -0700 > >Message-Id: > ez.del.cueto@intel.com> >=20 > FYI, I also sent another patch to be reviewed, which is independent and n= ot to > be confused with this one. >=20 > >Subject: [PATCH] SecurityPkg: Debug code to audit BIOS TPM extend > operations. > >Date: Mon, 20 Jul 2020 15:28:32 -0700 > >Message-Id: > lez.del.cueto@intel.com> >=20 > Thanks and regards, > -Rodrigo >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Monday, July 20, 2020 5:51 PM > > To: devel@edk2.groups.io; Gonzalez Del Cueto, Rodrigo > > > > Cc: Yao, Jiewen > > Subject: RE: [edk2-devel] [PATCH] SecurityPkg: Fix > > GetSupportedAndActivePcrs counter calculation > > > > Hi Bodrigo > > I have seen a patch with similar title and content earlier. May I know = which > > one the latest one? > > > > Please add *PATCH-V2* in the title to tell us which one is the latest v= ersion, > > and always add V3/V4/V5 to future update. > > I will review and give comment to the latest version. > > > > Thank you > > Yao Jiewen > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > Rodrigo > > > Gonzalez del Cueto > > > Sent: Tuesday, July 21, 2020 5:27 AM > > > To: devel@edk2.groups.io > > > Cc: Gonzalez Del Cueto, Rodrigo > > > Subject: [edk2-devel] [PATCH] SecurityPkg: Fix > > > GetSupportedAndActivePcrs counter calculation > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2855 > > > The Tpm2GetCapabilitySupportedAndActivePcrs function prints a count > > > number that should reflect the *supported and currently > > > active* PCR banks, but the implementation in place displays instead > > > the count of the *supported PCR banks* retrieved directly from the > > > Tpm2GetCapabilityPcrs() TPML_PCR_SELECTION output. > > > > > > The counter should only take into account those PCRs banks which are > > > active. > > > > > > Replaced usage of EFI_D_* for DEBUG_* definitions in debug messages. > > > > > > Change-Id: I2f41bbe69834bdce41ffc0f20199b6fb881cd10b > > > Signed-off-by: Rodrigo Gonzalez del Cueto > > > > > > --- > > > SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 46 > > > +++++++++++++++++++++++++++++----------------- > > > 1 file changed, 29 insertions(+), 17 deletions(-) > > > > > > diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > index 85b11c7715..07cac08c40 100644 > > > --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > @@ -110,7 +110,7 @@ Tpm2GetCapability ( > > > // Fail if command failed > > > > > > // > > > > > > if (SwapBytes32(RecvBuffer.Header.responseCode) !=3D TPM_RC_SUCCES= S) > > > { > > > > > > - DEBUG ((EFI_D_ERROR, "Tpm2GetCapability: Response Code error! > > > 0x%08x\r\n", SwapBytes32(RecvBuffer.Header.responseCode))); > > > > > > + DEBUG ((DEBUG_ERROR, "Tpm2GetCapability: Response Code error! > > > 0x%08x\r\n", SwapBytes32(RecvBuffer.Header.responseCode))); > > > > > > return EFI_DEVICE_ERROR; > > > > > > } > > > > > > > > > > > > @@ -522,74 +522,86 @@ Tpm2GetCapabilitySupportedAndActivePcrs ( > > > EFI_STATUS Status; > > > > > > TPML_PCR_SELECTION Pcrs; > > > > > > UINTN Index; > > > > > > + UINT8 ActivePcrBankCount; > > > > > > > > > > > > // > > > > > > - // Get supported PCR and current Active PCRs. > > > > > > + // Get supported PCR > > > > > > // > > > > > > Status =3D Tpm2GetCapabilityPcrs (&Pcrs); > > > > > > - > > > > > > + DEBUG ((DEBUG_INFO, "Supported PCRs - Count =3D %08x\n", > > > + Pcrs.count)); > > > > > > + ActivePcrBankCount =3D 0; > > > > > > // > > > > > > // If error, assume that we have at least SHA-1 (and return the > > > error.) > > > > > > // > > > > > > if (EFI_ERROR (Status)) { > > > > > > - DEBUG ((EFI_D_ERROR, "GetSupportedAndActivePcrs - > > > Tpm2GetCapabilityPcrs fail!\n")); > > > > > > + DEBUG ((DEBUG_ERROR, "GetSupportedAndActivePcrs - > > > Tpm2GetCapabilityPcrs fail!\n")); > > > > > > *TpmHashAlgorithmBitmap =3D HASH_ALG_SHA1; > > > > > > *ActivePcrBanks =3D HASH_ALG_SHA1; > > > > > > + ActivePcrBankCount =3D 1; > > > > > > } > > > > > > // > > > > > > // Otherwise, process the return data to determine what algorithms > > > are supported > > > > > > // and currently allocated. > > > > > > // > > > > > > else { > > > > > > - DEBUG ((EFI_D_INFO, "GetSupportedAndActivePcrs - Count =3D %08x\= n", > > > Pcrs.count)); > > > > > > *TpmHashAlgorithmBitmap =3D 0; > > > > > > *ActivePcrBanks =3D 0; > > > > > > for (Index =3D 0; Index < Pcrs.count; Index++) { > > > > > > switch (Pcrs.pcrSelections[Index].hash) { > > > > > > case TPM_ALG_SHA1: > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > HASH_ALG_SHA1 > > > present.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA1 present.\n")); > > > > > > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA1; > > > > > > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > > > Pcrs.pcrSelections[Index].sizeofSelect)) { > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA1 active.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA1 active.\n")); > > > > > > *ActivePcrBanks |=3D HASH_ALG_SHA1; > > > > > > + ActivePcrBankCount++; > > > > > > } > > > > > > break; > > > > > > case TPM_ALG_SHA256: > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA256 present.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA256 present.\n")); > > > > > > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA256; > > > > > > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > > > Pcrs.pcrSelections[Index].sizeofSelect)) { > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA256 active.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA256 active.\n")); > > > > > > *ActivePcrBanks |=3D HASH_ALG_SHA256; > > > > > > + ActivePcrBankCount++; > > > > > > } > > > > > > break; > > > > > > case TPM_ALG_SHA384: > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA384 present.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA384 present.\n")); > > > > > > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA384; > > > > > > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > > > Pcrs.pcrSelections[Index].sizeofSelect)) { > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA384 active.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA384 active.\n")); > > > > > > *ActivePcrBanks |=3D HASH_ALG_SHA384; > > > > > > + ActivePcrBankCount++; > > > > > > } > > > > > > break; > > > > > > case TPM_ALG_SHA512: > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA512 present.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA512 present.\n")); > > > > > > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA512; > > > > > > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > > > Pcrs.pcrSelections[Index].sizeofSelect)) { > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA512 active.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SHA512 active.\n")); > > > > > > *ActivePcrBanks |=3D HASH_ALG_SHA512; > > > > > > + ActivePcrBankCount++; > > > > > > } > > > > > > break; > > > > > > case TPM_ALG_SM3_256: > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SM3_256 present.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SM3_256 present.\n")); > > > > > > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SM3_256; > > > > > > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > > > Pcrs.pcrSelections[Index].sizeofSelect)) { > > > > > > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SM3_256 active.\n")); > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > HASH_ALG_SM3_256 active.\n")); > > > > > > *ActivePcrBanks |=3D HASH_ALG_SM3_256; > > > > > > + ActivePcrBankCount++; > > > > > > } > > > > > > break; > > > > > > + default: > > > > > > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > > > + Unsupported > > > bank 0x%04x.\n", Pcrs.pcrSelections[Index].hash)); > > > > > > + continue; > > > > > > + break; > > > > > > } > > > > > > } > > > > > > } > > > > > > > > > > > > + DEBUG ((DEBUG_INFO, "GetSupportedAndActivePcrs - Count =3D %08x\n"= , > > > ActivePcrBankCount)); > > > > > > return Status; > > > > > > } > > > > > > > > > > > > @@ -837,11 +849,11 @@ Tpm2TestParms ( > > > } > > > > > > > > > > > > if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER)) { > > > > > > - DEBUG ((EFI_D_ERROR, "Tpm2TestParms - RecvBufferSize Error - > > %x\n", > > > RecvBufferSize)); > > > > > > + DEBUG ((DEBUG_ERROR, "Tpm2TestParms - RecvBufferSize Error - > > > + %x\n", > > > RecvBufferSize)); > > > > > > return EFI_DEVICE_ERROR; > > > > > > } > > > > > > if (SwapBytes32(RecvBuffer.Header.responseCode) !=3D TPM_RC_SUCCES= S) > > > { > > > > > > - DEBUG ((EFI_D_ERROR, "Tpm2TestParms - responseCode - %x\n", > > > SwapBytes32(RecvBuffer.Header.responseCode))); > > > > > > + DEBUG ((DEBUG_ERROR, "Tpm2TestParms - responseCode - %x\n", > > > SwapBytes32(RecvBuffer.Header.responseCode))); > > > > > > return EFI_UNSUPPORTED; > > > > > > } > > > > > > > > > > > > -- > > > 2.27.0.windows.1 > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > Groups.io Links: You receive all messages sent to this group. > > > > > > View/Reply Online (#62907): > > > https://edk2.groups.io/g/devel/message/62907 > > > Mute This Topic: https://groups.io/mt/75694158/1772286 > > > Group Owner: devel+owner@edk2.groups.io > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > [jiewen.yao@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D