From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.8519.1595289089638761846 for ; Mon, 20 Jul 2020 16:51:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=D2pJZ9hU; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) IronPort-SDR: vPxW2VNxO8ep1A9z+SgXMeTYW9tOFtH/Fd8+j9bV2NtFPIAE4QOD5t0fK8QCt74oYNADCihKj9 gkrIco0Gyzgg== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="130108045" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="130108045" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 16:51:29 -0700 IronPort-SDR: HXwb+ZOMor6yFafFkSoCrD2g1dX6/XWxgzDR1zAx1o5y/jyxqC3cfvlADB+ZIMBowCsw0MzlcG VdBF97PCgrig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="461872784" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 20 Jul 2020 16:51:28 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 16:51:28 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 16:51:28 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 16:51:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHnV6IP5JG27E8yT8cYFjpxxoOi/WMo9/eeihd/glze6j/qdpjqpg+RiZdkmTfH6G7vIl5B8lEkjYy3HJIz6bYdp656MWvBXMeeXaG/ln95ZdqxhATnTKBluf5/sCJxOZICjaNTJn02I6J42tF0qlm5HnIidTKTX7E8Hpwbqap2aFBm7hFTmvmNQFbbxZZdS3XXz0y1YmB5Babgu1noSMwOB395RglUVz0LjjW9reIqolxP+rzIBS65MMuET9lortSWLdVjoxPcYgnYbd4XvV2bfXbMAnaTbE8/lj10RbTjlNI1DRFrBVGF+kJQluxvPKZHUaWLJbCIjR3IeOcEZlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TfOoPMs22n1fun/fVPjRbSoPEo8KeXYZjJVTCYbboBY=; b=I1nIxJ0OvBqzJf1SeYAxalDdsm4/l6vlXUiBOO7z5vfTWpTnZYYF4DIgTqbb3Jzr1mk0DhU2M6Nq4rfQfiXwUnizw3zAWZtDbrvJ4xg7QFl4AQovArNUHGkluthf28Gj3Ji+52n0nq6WZO2OHFTkVpQEu++UXzin4cyBmqkyBhAfWuLX7jZ3nvaXVzKmP139bXFG5wzCKgLsOWUkj5y1mCff2Y1dDnFdhCsFYPp9Qr6ixB5iyDoxaSe8Imb9qdMJTixSIm7B85GwV1z9vTqgWw9vN8wp0VmyOiL1uSI0DxgK2hE3fUDoGKxx9h4TIXHoxr3A3Lfc8U2lT9ILhNhq7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TfOoPMs22n1fun/fVPjRbSoPEo8KeXYZjJVTCYbboBY=; b=D2pJZ9hU8O0rMpR5v1RVXsHDE1IqBgmQVDYSsJOi84RdaY+mD58YvJa5MxIG1lwtps9U9bfFv45VedZB1pFRLsqT7EITPAnANHAc0j1bMpnaf+EF23i0/SGl/IvPzRX07AkALtust1ivLYnr4uey9s5C95QHTfWLxGoVp8b48RY= Received: from DM5PR11MB2026.namprd11.prod.outlook.com (2603:10b6:3:10::17) by DM5PR11MB1516.namprd11.prod.outlook.com (2603:10b6:4:a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Mon, 20 Jul 2020 23:51:25 +0000 Received: from DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4]) by DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4%4]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 23:51:25 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Gonzalez Del Cueto, Rodrigo" CC: "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH] SecurityPkg: Fix GetSupportedAndActivePcrs counter calculation Thread-Topic: [edk2-devel] [PATCH] SecurityPkg: Fix GetSupportedAndActivePcrs counter calculation Thread-Index: AQHWXu8IvwMZEh93I0Cscusfeba3QKkRIrJQ Date: Mon, 20 Jul 2020 23:51:24 +0000 Message-ID: References: <20200720212637.48-1-rodrigo.gonzalez.del.cueto@intel.com> In-Reply-To: <20200720212637.48-1-rodrigo.gonzalez.del.cueto@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWUwYzc0MWItOTFkYi00OGExLTgzZmItYWViZWNkNDBkYzUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRFZJRmNIVzdiaWlpRndoaGowdXVFOTFOM1wvUDJNWmFNQjhsT3RINEhxZk0yMlRoMmFZRFlLQVpodGhyS212b3QifQ== x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 753f1c21-ca39-4b3e-84ec-08d82d07d00f x-ms-traffictypediagnostic: DM5PR11MB1516: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cmh0tSUvp4bn0kaRxj+Y7IYHY2pbJ3WAswH/0ZLl4RfeZX50/Z1mi0VI1k3xaDnfkC76Y7dgmRE9QZRfqClvt8L2qgUFVFfi8lEbe9UFeV8m1AKLPICr7cWTYpkN+0bNyg+SB5rckC9yg5NXiY7SGus46VDAIk8+XchwGp9jdnxZmK8Kj6uQ1dr2nQmVRoVG4Su1lFYDTAOR2euGKo/8mlhuFxJPmx7+Dh+PijkLgVfIjMdCm2LPlOqDaFw0lyZdHRj35BmQuYrbJ4I2nS7lSMGBT3BvTJtMF4+m9lqbhqF/cjHGz3z6XGydz1v3lPfariJYuvaMLtCOQkPLyy+KcOQuwkmgTm7YGQoW5rHQvI0VYUfsXA0sTWVPVyXctL0OGovHTC1D401pLMtEk4WPWiChkENDY0vwQRO8xQGKPYxwtW83B2GpAUUpvK/oqDEo/sWKmKZYdE1PKyC4nkXanA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB2026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(86362001)(316002)(5660300002)(2906002)(15650500001)(19627235002)(110136005)(33656002)(76116006)(66446008)(66556008)(478600001)(26005)(64756008)(66476007)(52536014)(186003)(6636002)(8676002)(53546011)(6506007)(966005)(9686003)(4326008)(7696005)(71200400001)(107886003)(83380400001)(8936002)(66946007)(55016002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: zXoBjoLY7oymuJaCUMBOZoXj8P1itPVOWepjQXkfkaw2+6N3fq6Dwzq4EHquedHxEjf/RvIGSKt+UcQ4okoqcBhWBY9N72zFirO+9/8UsbMz2BiGYoii6bX367SJtTqaXI8iWM6SmO73YQrwL7pAtMAvXzZ1xnrRm7sVW4rl6aOcGtrg9nTIY/Gl9F6wqjPRwspcB4Vn7Gy7dQOiJQdqoT8hxRMKeEKEJm8hRT4Zc+XkYCOYqfNTg3w1LPyTM1E91MSrFV4c+/HAi5kXkJoVtND+LdD/Csy72CSIDSTvyzjBB1Yr9o1z5p15I2nWJncxow3kncbPl4ekgJVJplEGm5iL+t9ZpFbzdiOTf1Rd7gtdYPQFkFco+ENammUlGStyRPOhZJ2rzn3hP4nsgQ/HhRA572wl5osLzJ6UfoSsaqaXN99UzLBXN+35aXFSnV9TpDlkXLOd3dP3CngXiaJWj9R3Sp6h/rjM4TUbp9BvKm+h3nCc0ftsrkM9qITdp268 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB2026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 753f1c21-ca39-4b3e-84ec-08d82d07d00f X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 23:51:24.9065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IDBGtgS26niJ5ox1P7Mt6edKL2habVX5IalWScJOjLvbQHvdusgyoYCEGsccYZ0GeJWQZBIEKRLqb++oVFjW7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1516 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bodrigo I have seen a patch with similar title and content earlier. May I know whic= h one the latest one? Please add *PATCH-V2* in the title to tell us which one is the latest versi= on, and always add V3/V4/V5 to future update. I will review and give comment to the latest version. Thank you Yao Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rodrigo > Gonzalez del Cueto > Sent: Tuesday, July 21, 2020 5:27 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo > Subject: [edk2-devel] [PATCH] SecurityPkg: Fix GetSupportedAndActivePcrs > counter calculation >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2855 > The Tpm2GetCapabilitySupportedAndActivePcrs function prints a > count number that should reflect the *supported and currently > active* PCR banks, but the implementation in place displays > instead the count of the *supported PCR banks* retrieved > directly from the Tpm2GetCapabilityPcrs() > TPML_PCR_SELECTION output. >=20 > The counter should only take into account those PCRs banks > which are active. >=20 > Replaced usage of EFI_D_* for DEBUG_* definitions in debug > messages. >=20 > Change-Id: I2f41bbe69834bdce41ffc0f20199b6fb881cd10b > Signed-off-by: Rodrigo Gonzalez del Cueto > > --- > SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 46 > +++++++++++++++++++++++++++++----------------- > 1 file changed, 29 insertions(+), 17 deletions(-) >=20 > diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > index 85b11c7715..07cac08c40 100644 > --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > @@ -110,7 +110,7 @@ Tpm2GetCapability ( > // Fail if command failed >=20 > // >=20 > if (SwapBytes32(RecvBuffer.Header.responseCode) !=3D TPM_RC_SUCCESS) { >=20 > - DEBUG ((EFI_D_ERROR, "Tpm2GetCapability: Response Code error! > 0x%08x\r\n", SwapBytes32(RecvBuffer.Header.responseCode))); >=20 > + DEBUG ((DEBUG_ERROR, "Tpm2GetCapability: Response Code error! > 0x%08x\r\n", SwapBytes32(RecvBuffer.Header.responseCode))); >=20 > return EFI_DEVICE_ERROR; >=20 > } >=20 >=20 >=20 > @@ -522,74 +522,86 @@ Tpm2GetCapabilitySupportedAndActivePcrs ( > EFI_STATUS Status; >=20 > TPML_PCR_SELECTION Pcrs; >=20 > UINTN Index; >=20 > + UINT8 ActivePcrBankCount; >=20 >=20 >=20 > // >=20 > - // Get supported PCR and current Active PCRs. >=20 > + // Get supported PCR >=20 > // >=20 > Status =3D Tpm2GetCapabilityPcrs (&Pcrs); >=20 > - >=20 > + DEBUG ((DEBUG_INFO, "Supported PCRs - Count =3D %08x\n", Pcrs.count)); >=20 > + ActivePcrBankCount =3D 0; >=20 > // >=20 > // If error, assume that we have at least SHA-1 (and return the error.= ) >=20 > // >=20 > if (EFI_ERROR (Status)) { >=20 > - DEBUG ((EFI_D_ERROR, "GetSupportedAndActivePcrs - > Tpm2GetCapabilityPcrs fail!\n")); >=20 > + DEBUG ((DEBUG_ERROR, "GetSupportedAndActivePcrs - > Tpm2GetCapabilityPcrs fail!\n")); >=20 > *TpmHashAlgorithmBitmap =3D HASH_ALG_SHA1; >=20 > *ActivePcrBanks =3D HASH_ALG_SHA1; >=20 > + ActivePcrBankCount =3D 1; >=20 > } >=20 > // >=20 > // Otherwise, process the return data to determine what algorithms are > supported >=20 > // and currently allocated. >=20 > // >=20 > else { >=20 > - DEBUG ((EFI_D_INFO, "GetSupportedAndActivePcrs - Count =3D %08x\n", > Pcrs.count)); >=20 > *TpmHashAlgorithmBitmap =3D 0; >=20 > *ActivePcrBanks =3D 0; >=20 > for (Index =3D 0; Index < Pcrs.count; Index++) { >=20 > switch (Pcrs.pcrSelections[Index].hash) { >=20 > case TPM_ALG_SHA1: >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - HASH_ALG_SHA= 1 > present.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA1 present.\n")); >=20 > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA1; >=20 > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > Pcrs.pcrSelections[Index].sizeofSelect)) { >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA1 active.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA1 active.\n")); >=20 > *ActivePcrBanks |=3D HASH_ALG_SHA1; >=20 > + ActivePcrBankCount++; >=20 > } >=20 > break; >=20 > case TPM_ALG_SHA256: >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA256 present.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA256 present.\n")); >=20 > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA256; >=20 > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > Pcrs.pcrSelections[Index].sizeofSelect)) { >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA256 active.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA256 active.\n")); >=20 > *ActivePcrBanks |=3D HASH_ALG_SHA256; >=20 > + ActivePcrBankCount++; >=20 > } >=20 > break; >=20 > case TPM_ALG_SHA384: >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA384 present.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA384 present.\n")); >=20 > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA384; >=20 > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > Pcrs.pcrSelections[Index].sizeofSelect)) { >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA384 active.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA384 active.\n")); >=20 > *ActivePcrBanks |=3D HASH_ALG_SHA384; >=20 > + ActivePcrBankCount++; >=20 > } >=20 > break; >=20 > case TPM_ALG_SHA512: >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA512 present.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA512 present.\n")); >=20 > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SHA512; >=20 > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > Pcrs.pcrSelections[Index].sizeofSelect)) { >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA512 active.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SHA512 active.\n")); >=20 > *ActivePcrBanks |=3D HASH_ALG_SHA512; >=20 > + ActivePcrBankCount++; >=20 > } >=20 > break; >=20 > case TPM_ALG_SM3_256: >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SM3_256 present.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SM3_256 present.\n")); >=20 > *TpmHashAlgorithmBitmap |=3D HASH_ALG_SM3_256; >=20 > if (!IsZeroBuffer (Pcrs.pcrSelections[Index].pcrSelect, > Pcrs.pcrSelections[Index].sizeofSelect)) { >=20 > - DEBUG ((EFI_D_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SM3_256 active.\n")); >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - > HASH_ALG_SM3_256 active.\n")); >=20 > *ActivePcrBanks |=3D HASH_ALG_SM3_256; >=20 > + ActivePcrBankCount++; >=20 > } >=20 > break; >=20 > + default: >=20 > + DEBUG ((DEBUG_VERBOSE, "GetSupportedAndActivePcrs - Unsupported > bank 0x%04x.\n", Pcrs.pcrSelections[Index].hash)); >=20 > + continue; >=20 > + break; >=20 > } >=20 > } >=20 > } >=20 >=20 >=20 > + DEBUG ((DEBUG_INFO, "GetSupportedAndActivePcrs - Count =3D %08x\n", > ActivePcrBankCount)); >=20 > return Status; >=20 > } >=20 >=20 >=20 > @@ -837,11 +849,11 @@ Tpm2TestParms ( > } >=20 >=20 >=20 > if (RecvBufferSize < sizeof (TPM2_RESPONSE_HEADER)) { >=20 > - DEBUG ((EFI_D_ERROR, "Tpm2TestParms - RecvBufferSize Error - %x\n", > RecvBufferSize)); >=20 > + DEBUG ((DEBUG_ERROR, "Tpm2TestParms - RecvBufferSize Error - %x\n", > RecvBufferSize)); >=20 > return EFI_DEVICE_ERROR; >=20 > } >=20 > if (SwapBytes32(RecvBuffer.Header.responseCode) !=3D TPM_RC_SUCCESS) { >=20 > - DEBUG ((EFI_D_ERROR, "Tpm2TestParms - responseCode - %x\n", > SwapBytes32(RecvBuffer.Header.responseCode))); >=20 > + DEBUG ((DEBUG_ERROR, "Tpm2TestParms - responseCode - %x\n", > SwapBytes32(RecvBuffer.Header.responseCode))); >=20 > return EFI_UNSUPPORTED; >=20 > } >=20 >=20 >=20 > -- > 2.27.0.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#62907): https://edk2.groups.io/g/devel/message/62907 > Mute This Topic: https://groups.io/mt/75694158/1772286 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D