From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.10934.1594886878460804561 for ; Thu, 16 Jul 2020 01:07:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jZOQKjyG; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) IronPort-SDR: tVpqxFv447aCbsOIxMxTZoGxI+OTUtbez5VMoAvzwfz3ICjBZMeol4q6E+JlSGEdFa69J/OEZl m6LJ8Qk3Z8SA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="146850081" X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="146850081" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 01:07:58 -0700 IronPort-SDR: pGtV/+qRdocc6LpZ5TR5xG9/RLrToN//5WYT3zt0w/Zv2eg1l8t1rA+noIHAQDuIIvIa/ZRElv Koe+5bPZC5zQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="316955731" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 16 Jul 2020 01:07:57 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 16 Jul 2020 01:07:57 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 16 Jul 2020 01:07:57 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jul 2020 01:07:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BgAbI2nTxVVAMcUGyK5oBumzVscO8UUCEzrjtbBIt9i/5BioA0LirG/420SNLZW0NjJYF5ppmFQnIrGmezqGEoMDOej7n8WgLkUZN2DTB6KQacPLyB4gHTxIFKoh6rMwceOlsH+RLIaRk+nkuKap1PujuHd2sR/Puc/6+YCoDrRxNYRcK0M2eDwixMTdDEY08Up2Y0bfL8ESb8rVP97+25UfD1vXJ6Fg2jVvSxkqn4vc2p+9uTxV90VgACMvmKodj2w7Yyai36GKEolO/68rk7mHHd3BRgx6hKjrLBguAx14AzbFUrbeRDJYa7OiVcSRBkNU4M/FkCrzocfLI6fokQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZ5omG/m+AyQsFJ3MEJe7xcq8pr+lIcTcgVMhkYd+VM=; b=kYVMu7AJbQDcfguR+DyV2AJnaZusciXn347UTh18BROxghihQYwZVJHLh6FMxrk6UR2larfNaMZFITLxXtIbO93Wcwatq+4gGW0wiF5/IL62y/08ECKNgRPCY92Az83k/OZH4EQSrom1lss6Zc5ud2CG9j8HONWXNy2NrFR/JzccFJOXYBCWtBjAhHMB28mgM4lopxFfGZb8jGTo7Js1lc638zx6VarJ1IztUAUMibfqTv/DIrzll5JPBHhgwfA1gSWXMD8NQj0TKnbKO8epMbhelAOAkKSKeWAVY6JNgAX+LCct0gbtaArsAQqty+u6zPrvgFd4X8OZ9AtkpC8X6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZ5omG/m+AyQsFJ3MEJe7xcq8pr+lIcTcgVMhkYd+VM=; b=jZOQKjyGyO4ziyh0v9bJGxds7sP3r6ItlyvO2ZIPdPMliz87ZARbxt9jU0ahD2T1AwNdoRLHsouSqqbYyfGIi5SPxvJsiZYiXeIEvd13d9r07xLkD6DqgsIfpa+6Pw8Nm+kOMT2iPCZGCLK7XYAxnmBEIPgXKuprBTTpO7YywRc= Received: from DM5PR11MB2026.namprd11.prod.outlook.com (2603:10b6:3:10::17) by DM5PR11MB0042.namprd11.prod.outlook.com (2603:10b6:4:6b::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Thu, 16 Jul 2020 08:07:55 +0000 Received: from DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4]) by DM5PR11MB2026.namprd11.prod.outlook.com ([fe80::e19d:1de4:c479:da4%4]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 08:07:55 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" Subject: Re: [PATCH v2 7/7] MdePkg/Tcg2Protocol: define Flag EFI_TCG2_PRE_HASH Thread-Topic: [PATCH v2 7/7] MdePkg/Tcg2Protocol: define Flag EFI_TCG2_PRE_HASH Thread-Index: AQHWW0UCLWIAhfu/BkeTYNZSj6s9VKkJ2Znw Date: Thu, 16 Jul 2020 08:07:55 +0000 Message-ID: References: <20200716074430.9675-1-qi1.zhang@intel.com> <20200716074430.9675-8-qi1.zhang@intel.com> In-Reply-To: <20200716074430.9675-8-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzcwNmE0ZTAtNzRjYS00MTMwLThmZGMtZDRlZmJmYWQ2NWJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1BxR1wvWEt6bFFVaGQ5NW50VUNpY29FTkRpWnVxMnN0TlQyUG5Sejd5V1JcL0YzSnBITDhSdVwvQXV1VG1md3lHZyJ9 x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a851562e-4d5e-4f08-094e-08d8295f58a9 x-ms-traffictypediagnostic: DM5PR11MB0042: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VSrZ57DMS8PH8CdddoVABPaMfFRRQCsbo95RzgwfOAu7OVLFLl6zW15iUnXyDTyrAg+Z+BaeJHRdUPsjhr3Stcr62E1Dmb8sgpIaSEtpgBQF/8lSIgENNnccsuvzI+Lf3Q2p+CIGjvITAhlIqc0ZPAAXnZSKfawdGNBT+qdxpbfKVubIubqtTY5dAqkGTCcXM5gQh77VNDtckFK35b/viue8ZtWfy3uSk7fQiS4H8r30ZeH12k5AhjXYA7qeOxuBrjJY4JGSeZmNAUsTKKiHfmLjbbE93aOI2NR+IXyyUJ2ERm8OzSDNWvlsyhwTIANqD758EhyRCHaAi6BYcLxxoEjV9oCYZrQGd3XRM9WoMO64kbs1JtLfXrxd7N3bda7B1bMbRprtdPX4avkiM+gazw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB2026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(33656002)(53546011)(2906002)(71200400001)(55016002)(54906003)(19627235002)(5660300002)(186003)(26005)(316002)(478600001)(76116006)(8676002)(6506007)(9686003)(66946007)(66476007)(64756008)(66556008)(4326008)(83380400001)(966005)(8936002)(110136005)(66446008)(107886003)(7696005)(86362001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: fJeF6RChRrHSQ23Ty3gAKDbGdKoaev/2H+gVTuV2FmiWoZ9V0TIQKfF0uj/m7FC8NOUDn03h0ZS4mjmLalKNGpWRMK7wWjd7ewmff1d/mPFCo5voIFjIpVYUQTTiuvmnRYouCDDG8P8NVg27ZzON3VmR/5iX4xkErKsET86RQxgUMQS5enMJ7bgoPc7tq/Lv8wm/kC8gya2mroXEYzsgCgR3X8J9ZfnfUGtZwricpk24Mon8X7E77iccmfpdqUQfZKkhGZwwImO0ZgSKAMasOkkMXMnFlI14HYcI2V/Z5OdwcO2R1IEWee3z7bwarpxMU0cV4tohb4tonUgODCWiouJq7KqXmOibO5/GVacIydCZamKVDE4F4ClGxHB7NjcTuCtl7rfSIU6bErIeo+zxO8OVAJBuXG5hI1eVBR6IMy91DvTnCejzqc71ZeIkpr15ru/tlPDDEwGrbxTWrFX0yNrQH7g4WTkzRGsGOLpR2wgvlhNZuHOncb0biL+rYsWY MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB2026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a851562e-4d5e-4f08-094e-08d8295f58a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 08:07:55.8710 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VCaxdd2BwEolswNYe3VBOH4kPsM686+O2qOFced3ud/73fzNVhYNvOAiz1INiWel/7ZJQf8mnmrzughvmj3HNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0042 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Qi We should not add this attribute to TCG2_PROTOCOL, which is defined by TCG. This attribute should be only applied to TCG_PPI. Please move it there. > -----Original Message----- > From: Zhang, Qi1 > Sent: Thursday, July 16, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Kinney, Michael D > ; Gao, Liming ; Yao, > Jiewen > Subject: [PATCH v2 7/7] MdePkg/Tcg2Protocol: define Flag > EFI_TCG2_PRE_HASH >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2841 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jiewen Yao > Cc: Qi Zhang > Signed-off-by: Qi Zhang > --- > MdePkg/Include/Protocol/Tcg2Protocol.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/Tcg2Protocol.h > b/MdePkg/Include/Protocol/Tcg2Protocol.h > index 5ef13cc607..4659802251 100644 > --- a/MdePkg/Include/Protocol/Tcg2Protocol.h > +++ b/MdePkg/Include/Protocol/Tcg2Protocol.h > @@ -98,6 +98,10 @@ typedef struct tdEFI_TCG2_BOOT_SERVICE_CAPABILITY { > // >=20 > #define EFI_TCG2_EXTEND_ONLY 0x0000000000000001 >=20 > // >=20 > +// This bit is shall be set when HashData is the pre-hash digest. >=20 > +// >=20 > +#define EFI_TCG2_PRE_HASH 0x0000000000000010 >=20 > +// >=20 > // This bit shall be set when the intent is to measure a PE/COFF image. >=20 > // >=20 > #define PE_COFF_IMAGE 0x0000000000000010 >=20 > -- > 2.26.2.windows.1