From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe40::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 591BA81B87 for ; Wed, 11 Jan 2017 08:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q9QFhEFGUP8cCNs01mHbPb90O0I+Y/Ksz8fQt32GjkM=; b=kLoSQOgUKuSHUWLcSetf7dNBWF1BYbYWnMvJ3gzn/9YvHw8VhB9OzyPcPdCaqdpb6Bx/hfRAOEVLnabAc3MYfHvBqyQS2oDjpvVJl5UMa/ni96b35nf7NZ+9GNhOnSid9fSZ4rjnizHZoXr69u+83NZmX3VY685gPQP5t6TGAr4= Received: from DM5PR12MB1243.namprd12.prod.outlook.com (10.168.237.22) by SN1PR12MB0671.namprd12.prod.outlook.com (10.163.208.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Wed, 11 Jan 2017 16:29:07 +0000 Received: from DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) by DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) with mapi id 15.01.0829.017; Wed, 11 Jan 2017 16:29:06 +0000 From: "Duran, Leo" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Justen, Jordan L" , "Singh, Brijesh" , "Fan, Jeff" , "lersek@redhat.com" Thread-Topic: [edk2] [PATCH 0/8] IoLib class library Thread-Index: AQHSa50d9SVIzO2mQUCxeACfCl7c3qEygHYAgAAddMCAAAsIAIAAxY+Q Date: Wed, 11 Jan 2017 16:29:06 +0000 Message-ID: References: <1484092554-26224-1-git-send-email-leo.duran@amd.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CCE7E@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CD269@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CD269@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [2605:6000:e7c4:2000:104a:99c0:3acf:2f2a] x-microsoft-exchange-diagnostics: 1; SN1PR12MB0671; 7:HSDMwgo/qPJKLSgwHATG5uKv7p843MmHHALMuX6aUcYovQ25o8VyRDBc7UhpfMUzCNsdd+CczySepE18mrxGGIXd98HEDKGVtWWfiE5EEW9App1+KWAEAXvF+7Zs28DPX03Ie6NKp7BByKJS8vUDxpqt6UNKL+JidSAFmu679P/ruOr8nzszbCcHDEehZoSSq4v0dLBNG80UcMS21TJFXL7d7fZK1OaR767+CnGGRc26I1ieLYImD6YwfiLXtIRpspWx+v3p+ktY2SZWOWn/cGoVS5yn1jGfBhRl8ytLUeFJ2dS4n+jfACIjDYnZRVwgiyqWdvETC6NyXIZkKlgp+gldMVTMOiAeECjIKUnzQdilG7vjKB00LF8oQnJPe0gajb8H8Ttks9tOtE9X0PuBDzGtXcwVW1NL/B9SsZuc3XrCyqDCFBIYoyGgmsfjtWGZlOXgPUOMwI9F9p3/kc1S2Q==; 20:vn+MRiFiQRvYsYLFM3jRNwFYi+vTrAfU+E/81z6SVU8YAzled7AnBsR8al7XTVg7TgA2CHQM2bG3SmrdKm3otB9GcULZQ0aXsucOLRG/ApYmh2ZN4y2bq6qvvAxMxWTzL4jCOjGpP1bNWXmSUQLIakXoCSXr01CPGUYdXtcwKDUDQBZxHyXk8wRxTua5BTgxhof7sFQaGsGXRMbjGgNuO/ERT5JOns5LpILMyDCyQvw1Int1IoVNT5vQMBS1OG5+ x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6029001)(6009001)(7916002)(39860400002)(39840400002)(39450400003)(39410400002)(39850400002)(199003)(13464003)(377454003)(189002)(55016002)(99286003)(93886004)(68736007)(2950100002)(305945005)(7736002)(54906002)(74316002)(101416001)(122556002)(229853002)(38730400001)(76176999)(50986999)(54356999)(77096006)(6306002)(6436002)(25786008)(81166006)(6506006)(81156014)(33656002)(8676002)(9686003)(5660300001)(3660700001)(2906002)(4326007)(97736004)(92566002)(189998001)(2900100001)(5001770100001)(106116001)(3280700002)(105586002)(7696004)(86362001)(106356001)(102836003)(6116002)(2501003)(8936002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0671; H:DM5PR12MB1243.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: 6fe8aff6-1eca-413d-da3e-08d43a3ef664 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR12MB0671; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:SN1PR12MB0671; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0671; x-forefront-prvs: 01842C458A received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2017 16:29:06.1760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0671 Subject: Re: [PATCH 0/8] IoLib class library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 16:29:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, However, here are some issues with trying to use Fifo types via the I/O pro= tocol: 1) CpuIo2Dxe.c - CpuIoCheckParameter(): Count is forced to 1 for Fifo types= : // // For FIFO type, the target address won't increase during the access, // so treat Count as 1 // if (Width >=3D EfiCpuIoWidthFifoUint8 && Width <=3D EfiCpuIoWidthFifoUint= 64) { Count =3D 1; } 2) CpuIo2Dxe.c - CpuIoCheckParameter():Fifo types are eliminated/truncated: // // Check to see if Width is in the valid range for I/O Port operations // Width =3D (EFI_CPU_IO_PROTOCOL_WIDTH) (Width & 0x03); if (!MmioOperation && (Width =3D=3D EfiCpuIoWidthUint64)) { return EFI_INVALID_PARAMETER; } 3) CpuIo2Dxe.c - CpuIoServiceRead()/CpuIoServiceWrite(): OperationWidth is only serviced for these cases: EfiCpuIoWidthUint8, EfiCpu= IoWidthUint16, and EfiCpuIoWidthUint32 So the Fifo types are not serviced. > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Tuesday, January 10, 2017 10:07 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Justen, Jordan L > ; Singh, Brijesh ; Fan, > Jeff ; lersek@redhat.com > Subject: RE: [edk2] [PATCH 0/8] IoLib class library >=20 > Leo: > edk2\UefiCpuPkg\CpuIo2Dxe\CpuIo2Dxe.c CpuIoServiceRead() bases on > IoReadFifo8() for EfiCpuIoWidthFifoUint8 width. So, IoLibCupIo2 library > instance IoReadFifo8() implementation can call mCpuIo->Io.Read (mCpuIo, > EfiCpuIoWidthFifoUint8, Port, Count, Buffer); >=20 > Thanks > Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Duran, Leo > Sent: Wednesday, January 11, 2017 11:37 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Justen, Jordan L > ; Singh, Brijesh ; Fan, > Jeff ; lersek@redhat.com > Subject: Re: [edk2] [PATCH 0/8] IoLib class library >=20 > Liming... >=20 > > -----Original Message----- > > From: Gao, Liming [mailto:liming.gao@intel.com] > > Sent: Tuesday, January 10, 2017 7:42 PM > > To: Duran, Leo ; edk2-devel@lists.01.org > > Cc: Singh, Brijesh ; Justen, Jordan L > > ; Kinney, Michael D > > ; lersek@redhat.com; Fan, Jeff > > > > Subject: RE: [edk2] [PATCH 0/8] IoLib class library > > > > Leo: > > Thanks for your update. Here is my comments. > > 1) PeiIoLib, DxeIoLibCpuIo, DxeIoLibCpuIo2 library instance can base > > on CPU IO service to do FifoIo operation. They don't implement them > again. > > 2) IntelFrameworkModulePkg CpuIoDxe and UefiCpuPkg CpuIoPei driver > can > > be updated to base on FifoIo API for their FifoIo implementation. >=20 > [Duran, Leo] I actually considered that, but the CPU I/O driver does not > provide FiFiIo service in its implementation of the EFI_CPU_IO2_PROTOCOL. > The CPU I/O driver does use the Fifo routines internally, and it does so = when > that caller request IoRead/IoWrite... see the CPU I/O service routines be= low. >=20 > > 3) One coding style issue. We don't assign value to the variable declar= ation. > > UINT8 *Buffer8 =3D (UINT8 *)Buffer; > > =3D=3D> > > UINT8 *Buffer8; > > Buffer8 =3D (UINT8 *)Buffer; >=20 > [Duran, Leo] OK, I'll change that. >=20 > > > > Thanks > > Liming > [Duran, Leo] >=20 > EFI_STATUS > EFIAPI > CpuIoServiceRead ( > IN EFI_CPU_IO2_PROTOCOL *This, > IN EFI_CPU_IO_PROTOCOL_WIDTH Width, > IN UINT64 Address, > IN UINTN Count, > OUT VOID *Buffer > ) > { > EFI_STATUS Status; > UINT8 InStride; > UINT8 OutStride; > EFI_CPU_IO_PROTOCOL_WIDTH OperationWidth; > UINT8 *Uint8Buffer; >=20 > Status =3D CpuIoCheckParameter (FALSE, Width, Address, Count, Buffer); > if (EFI_ERROR (Status)) { > return Status; > } >=20 > // > // Select loop based on the width of the transfer > // > InStride =3D mInStride[Width]; > OutStride =3D mOutStride[Width]; > OperationWidth =3D (EFI_CPU_IO_PROTOCOL_WIDTH) (Width & 0x03); >=20 > #if defined (MDE_CPU_IA32) || defined (MDE_CPU_X64) > if (InStride =3D=3D 0) { > switch (OperationWidth) { > case EfiCpuIoWidthUint8: > IoReadFifo8 ((UINTN)Address, Count, Buffer); > return EFI_SUCCESS; > case EfiCpuIoWidthUint16: > IoReadFifo16 ((UINTN)Address, Count, Buffer); > return EFI_SUCCESS; > case EfiCpuIoWidthUint32: > IoReadFifo32 ((UINTN)Address, Count, Buffer); > return EFI_SUCCESS; > default: > // > // The CpuIoCheckParameter call above will ensure that this > // path is not taken. > // > ASSERT (FALSE); > break; > } > } > #endif >=20 > for (Uint8Buffer =3D Buffer; Count > 0; Address +=3D InStride, Uint8Buf= fer +=3D > OutStride, Count--) { > if (OperationWidth =3D=3D EfiCpuIoWidthUint8) { > *Uint8Buffer =3D IoRead8 ((UINTN)Address); > } else if (OperationWidth =3D=3D EfiCpuIoWidthUint16) { > *((UINT16 *)Uint8Buffer) =3D IoRead16 ((UINTN)Address); > } else if (OperationWidth =3D=3D EfiCpuIoWidthUint32) { > *((UINT32 *)Uint8Buffer) =3D IoRead32 ((UINTN)Address); > } > } >=20 > return EFI_SUCCESS; > } >=20 > EFI_STATUS > EFIAPI > CpuIoServiceWrite ( > IN EFI_CPU_IO2_PROTOCOL *This, > IN EFI_CPU_IO_PROTOCOL_WIDTH Width, > IN UINT64 Address, > IN UINTN Count, > IN VOID *Buffer > ) > { > EFI_STATUS Status; > UINT8 InStride; > UINT8 OutStride; > EFI_CPU_IO_PROTOCOL_WIDTH OperationWidth; > UINT8 *Uint8Buffer; >=20 > // > // Make sure the parameters are valid > // > Status =3D CpuIoCheckParameter (FALSE, Width, Address, Count, Buffer); > if (EFI_ERROR (Status)) { > return Status; > } >=20 > // > // Select loop based on the width of the transfer > // > InStride =3D mInStride[Width]; > OutStride =3D mOutStride[Width]; > OperationWidth =3D (EFI_CPU_IO_PROTOCOL_WIDTH) (Width & 0x03); >=20 > #if defined (MDE_CPU_IA32) || defined (MDE_CPU_X64) > if (InStride =3D=3D 0) { > switch (OperationWidth) { > case EfiCpuIoWidthUint8: > IoWriteFifo8 ((UINTN)Address, Count, Buffer); > return EFI_SUCCESS; > case EfiCpuIoWidthUint16: > IoWriteFifo16 ((UINTN)Address, Count, Buffer); > return EFI_SUCCESS; > case EfiCpuIoWidthUint32: > IoWriteFifo32 ((UINTN)Address, Count, Buffer); > return EFI_SUCCESS; > default: > // > // The CpuIoCheckParameter call above will ensure that this > // path is not taken. > // > ASSERT (FALSE); > break; > } > } > #endif >=20 > for (Uint8Buffer =3D (UINT8 *)Buffer; Count > 0; Address +=3D InStride, > Uint8Buffer +=3D OutStride, Count--) { > if (OperationWidth =3D=3D EfiCpuIoWidthUint8) { > IoWrite8 ((UINTN)Address, *Uint8Buffer); > } else if (OperationWidth =3D=3D EfiCpuIoWidthUint16) { > IoWrite16 ((UINTN)Address, *((UINT16 *)Uint8Buffer)); > } else if (OperationWidth =3D=3D EfiCpuIoWidthUint32) { > IoWrite32 ((UINTN)Address, *((UINT32 *)Uint8Buffer)); > } > } >=20 > return EFI_SUCCESS; > } > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Leo Duran > > Sent: Wednesday, January 11, 2017 7:56 AM > > To: edk2-devel@lists.01.org > > Cc: brijesh.singh@amd.com; Justen, Jordan L > > ; Gao, Liming ; Leo > > Duran ; Kinney, Michael D > > ; lersek@redhat.com; Fan, Jeff > > > > Subject: [edk2] [PATCH 0/8] IoLib class library > > > > The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have > > duplicate implementations of I/O Fifo routines. The patch series moves > > the I/O Fifo routines into the BaseIoLibIntrinsic library and expands > > the IoLib class to include the ported I/O Fifo routines. > > > > The Fifo routines moved from the UefiCpuPkg/CpuIo2Dxe driver support > > IA32 and X64 natively, and other architectures are supported by simply > > looping through the basic IoRead/IoWrite routines as appropiate. > > > > The intent of this patch series is twofold: > > 1) Integrate I/O Fifo routines into the IoLib class library. > > 2) Allow override of IoLib as may be required to support specific > > hardware implementations, such as AMD's Secure Encrypted Virtualization > (SEV). > > > > Leo Duran (8): > > MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library > > MdePkg/DxeIoLibCpuIo2: Add new Fifo routines in IoLib class > > MdePkg/DxeIoLibEsal: Add new Fifo routines in IoLib class > > MdePkg/PeiIoLibCpuIo: Add new Fifo routines in IoLib class > > MdePkg/SmmIoLibSmmCpuIo2: Add new Fifo routines in IoLib class > > IntelFrameworkPkg/DxeIoLibCpuIo: Add new Fifo routines in IoLib class > > UefiCpuPkg: Modify CpuIo2Dxe to use new IoLib class library > > OvmfPkg: Modify QemuFwCfgLib to use new IoLib class library > > > > IntelFrameworkPkg/Library/DxeIoLibCpuIo/IoLib.c | 203 > > +++++++++++++++++++++ > > MdePkg/Include/Library/IoLib.h | 158 +++++++++++++= +++ > > .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 6 +- > > .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm | 1 + > > .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm | 1 + > > MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c | 182 > > ++++++++++++++++++ > > MdePkg/Library/BaseIoLibIntrinsic/IoLibEbc.c | 179 > > ++++++++++++++++++ > > MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c | 201 > > ++++++++++++++++++++ > > .../Library/BaseIoLibIntrinsic}/X64/IoFifo.asm | 1 + > > .../Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm | 1 + > > MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 203 > > +++++++++++++++++++++ > > MdePkg/Library/DxeIoLibEsal/IoLib.c | 203 > > +++++++++++++++++++++ > > MdePkg/Library/PeiIoLibCpuIo/IoLib.c | 203 > > +++++++++++++++++++++ > > MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c | 203 > > +++++++++++++++++++++ > > OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 ------ > > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 54 +----- > > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | 7 +- > > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 7 +- > > OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm | 52 ------ > > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c | 3 +- > > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf | 11 +- > > UefiCpuPkg/CpuIo2Dxe/IoFifo.h | 176 -------------= ----- > > 22 files changed, 1751 insertions(+), 359 deletions(-) rename > > {UefiCpuPkg/CpuIo2Dxe =3D> > > MdePkg/Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm (94%) rename > > {UefiCpuPkg/CpuIo2Dxe =3D> > > MdePkg/Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm (94%) rename > > {UefiCpuPkg/CpuIo2Dxe =3D> > > MdePkg/Library/BaseIoLibIntrinsic}/X64/IoFifo.asm (95%) rename > > {UefiCpuPkg/CpuIo2Dxe =3D> > > MdePkg/Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm (95%) delete mode > > 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm > > delete mode 100644 > > OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm > > delete mode 100644 UefiCpuPkg/CpuIo2Dxe/IoFifo.h > > > > -- > > 1.9.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel