Re: [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

["Duran, Leo" <leo.duran@amd.com>]

> -----Original Message-----
> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Thursday, October 12, 2017 4:41 PM
> To: Duran, Leo <leo.duran@amd.com>; edk2-devel@lists.01.org
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>; Jordan Justen
> <jordan.l.justen@intel.com>; Liming Gao <liming.gao@intel.com>; Jiewen
> Yao <jiewen.yao@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use
> global variables to replace macros
> 
> On 11/10/2017 21:45, Leo Duran wrote:
> > +  // Override PSD offset for AMD
> > +  //
> > +  if (SmmStandardSignatureIsAuthenticAMD ()) {
> > +    gStmPsdOffset = AMD_SMM_PSD_OFFSET;  }
> > +
> 
> I think the right thing to do here would be to use the SMM state save map
> revision; in the case of AMD, the low 16 bits (IIRC) would be 0x0064.
> 
> Paolo
Hi Paolo,

In its current form, the patch merely replaces the macros with global variables, and does not attempt to disrupt the existing execution flow.
But perhaps you can provide a bit more context (or an example) so that may better understand your suggestion?

Thanks,
Leo.