From: "Duran, Leo" <leo.duran@amd.com>
To: "edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
"jeff.fan@intel.com" <jeff.fan@intel.com>,
"liming.gao@intel.com" <liming.gao@intel.com>,
'Laszlo Ersek' <lersek@redhat.com>
Subject: LocalApicLib: Why two separate directories?
Date: Fri, 28 Oct 2016 19:03:54 +0000 [thread overview]
Message-ID: <DM5PR12MB124388F52311AD97E78926CFF9AD0@DM5PR12MB1243.namprd12.prod.outlook.com> (raw)
All,
Just a quick observation to request comments:
Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is the same, how about we merge the common code and build the libraries from the same directory?
UefiCpuPkg/Library/LocalApilLib/
- LocalApicLib.c --> common code
- BaseXApicLib.c --> legacy APIC code
- BaseXApicX2ApicLib.c --> X2APIC code
- BaseXApicLib.inf -> builds from LocalApicLib.c + BaseXApicLib.c
- BaseXApicX2ApicLib.inf -> builds from LocalApicLib.c + BaseXApicX2ApicLib.c
Of course, doing this would require modification to existing .DSC files, to point to the appropriate .INF under the merged LocalApicLib directory.
Would that be too disruptive?
Leo.
next reply other threads:[~2016-10-28 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 19:03 Duran, Leo [this message]
2016-10-28 19:22 ` LocalApicLib: Why two separate directories? Laszlo Ersek
2016-10-28 19:31 ` Duran, Leo
2016-10-28 19:28 ` Kinney, Michael D
2016-10-28 19:36 ` Duran, Leo
2016-10-28 19:40 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB124388F52311AD97E78926CFF9AD0@DM5PR12MB1243.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox