From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0623.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe42::623]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59FC481D74 for ; Fri, 28 Oct 2016 12:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NBfI4y4kvdcYnnigpRDE5D2Y1beh1wheXZJfwwC9n/o=; b=cwkbme5akUDIt5cbHOnp902H2t4ubDO/vHxxOGTq1l1z1rxvFyxdjqq3930m0mxaHVfN8k3x9yM6vrMpzHliSIEvvNT/bTOUjZlPZhwnFwH+p0h+6M5//3wlpps54o8ObJRBTQesbD9HPlGQMTJX/JXohyXSyF1y76UrWNCRsSE= Received: from DM5PR12MB1243.namprd12.prod.outlook.com (10.168.237.22) by DM5PR12MB1242.namprd12.prod.outlook.com (10.168.237.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Fri, 28 Oct 2016 19:03:54 +0000 Received: from DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) by DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) with mapi id 15.01.0679.018; Fri, 28 Oct 2016 19:03:54 +0000 From: "Duran, Leo" To: "edk2-devel@ml01.01.org" CC: "michael.d.kinney@intel.com" , "jeff.fan@intel.com" , "liming.gao@intel.com" , 'Laszlo Ersek' Thread-Topic: LocalApicLib: Why two separate directories? Thread-Index: AdIxTgPHfJzAAk7nTwONwEQmJGazqw== Date: Fri, 28 Oct 2016 19:03:54 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.77.1] x-ms-office365-filtering-correlation-id: 60a2314d-389f-4cd7-65b6-08d3ff6529ed x-microsoft-exchange-diagnostics: 1; DM5PR12MB1242; 7:FWW7ZJHOsAQpAkbCYVK28yrCLGYY/9woPavzSBmfz1ioTdOiNpe0qyI1t6wf9LkIjkAWCucYjQAZzk0dNgUUsLtAvSJoc91RqTUwR1PzB2TV4YMcchFye5Zm8UqpaIzqEMNdscQWyKKFhAckjxffexWmEFs6fDwpcck3j2jp3/0Sdr9VLh2nhU3fGbn4RllLXTBfROEysqRs3iuctLuKXgGXvZTKhdajyl69StL0DFoFvAypHoCAZGW/AVQK6fe8GpSULkTJt1Ys6MjK6novzLgPQv32i1+h5YeDUtZ9ubGXkn+KyvlG9u5/tTWT7MkB/dvltunO/fkY+5DA+pbRl1dQplN/hM2D7wSbp538W5A=; 20:r6jrn8Y60C1HO+pnNl9v70n1odn/8j4tCOkcpT8gHC8rH9cWlHkph+fZQrPPB2uF0R4buL4UIOWaEr+QcGCIWUT1JCXdppNWripiA/nO1M4oz3qXhN48NQaAx/MXCcYJ4DkSlZs55Vxcf+yGu8phsr8hGOZnF82ngVLMeUuoZgfbqlka95DIFhqu1hEwqPmmqpBdl1wid4/BWGm2MDY3lzZRlKkBQGgkyqCZ3pRyQS+DiuSlgWzRi5gbKUwuMhec x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1242; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:DM5PR12MB1242; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1242; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(189002)(199003)(305945005)(86362001)(5660300001)(102836003)(586003)(3846002)(6116002)(11100500001)(2900100001)(97736004)(9686002)(68736007)(3660700001)(81166006)(8676002)(74316002)(81156014)(3280700002)(77096005)(5002640100001)(6916009)(2906002)(7696004)(7736002)(87936001)(10400500002)(189998001)(4326007)(33656002)(122556002)(99286002)(66066001)(229853001)(105586002)(106356001)(2351001)(110136003)(92566002)(54356999)(50986999)(101416001)(7846002)(76576001)(19580395003)(8936002)(2501003)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1242; H:DM5PR12MB1243.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2016 19:03:54.6733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1242 Subject: LocalApicLib: Why two separate directories? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 19:03:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable All, Just a quick observation to request comments: Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is the sam= e, how about we merge the common code and build the libraries from the same= directory? UefiCpuPkg/Library/LocalApilLib/ - LocalApicLib.c --> common code - BaseXApicLib.c --> legacy APIC code - BaseXApicX2ApicLib.c --> X2APIC code - BaseXApicLib.inf -> builds from LocalApicLib.c + BaseXApicLib.c - BaseXApicX2ApicLib.inf -> builds from LocalApicLib.c + BaseXApicX2ApicLib= .c Of course, doing this would require modification to existing .DSC files, to= point to the appropriate .INF under the merged LocalApicLib directory. Would that be too disruptive? Leo.