From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0074.outbound.protection.outlook.com [104.47.40.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC8BA21CE73FC for ; Thu, 6 Jul 2017 14:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=F3avxRDCwHf/7551bvq43ZvWhuXC9kbFe6r4OYtSfNA=; b=kdOPC4UmarFEQKGdtNfPtREbWJrRksCSXFVa8tm8oTLt0TYJ4Mm3BAQEjzNc4M4oUZ/4zfNN5Ti/mbOs/I6E8v4dbmDe9AdwcexwRT4FQoUOie8zZAsmRZYJzNeCxTAe17I/stBoZV8dzt5Bh2VZi3tSY/x4OUp4raosFLMPEoc= Received: from DM5PR12MB1243.namprd12.prod.outlook.com (10.168.237.22) by DM5PR12MB1146.namprd12.prod.outlook.com (10.168.236.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Thu, 6 Jul 2017 21:49:45 +0000 Received: from DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) by DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) with mapi id 15.01.1220.018; Thu, 6 Jul 2017 21:49:44 +0000 From: "Duran, Leo" To: "'afish@apple.com'" , Jordan Justen CC: "Singh, Brijesh" , edk2-devel-01 , "Lendacky, Thomas" , Liming Gao , Mike Kinney , Jiewen Yao , Laszlo Ersek , Jeff Fan Thread-Topic: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD) Thread-Index: AQHS1i6U3/oib+mTnUqFRoKwjvO/2aJGEHsAgAExzICAADlXgIAAGZcAgAAA9ICAAAA3IA== Date: Thu, 6 Jul 2017 21:49:44 +0000 Message-ID: References: <1495809845-32472-1-git-send-email-brijesh.singh@amd.com> <2c3b8722-0e91-af09-5d3b-c5751dd53a9f@amd.com> <149935954954.18473.9057866656909328887@jljusten-skl> <6b79e292-e587-46a8-1f6a-a0483a01f8f7@amd.com> <149937735857.21467.1917283905856299959@jljusten-skl.jf.intel.com> <4E33B8F1-DE1D-4E19-9C73-2A1DEDF7C47C@apple.com> In-Reply-To: <4E33B8F1-DE1D-4E19-9C73-2A1DEDF7C47C@apple.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: apple.com; dkim=none (message not signed) header.d=none;apple.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.77.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR12MB1146; 20:br3TjlGexWRHR3pqpYuCLBkZnxPUMypIrORVK0DOWplEj/HMxo2ZS/oeBvgDMG0nFyT6q/0+N6Hq+kx4+eJnoSp/tMpvzYw+Sdhjb0lPISx3qR7Z4NEEv9qXMyc3ksArVRuHdmUqZ5+cs62hhGyYFe8S1lx3meosm55h9EElQt/arXBIXcyZ6sYC0/4vPq+GKKyrIlpJYcSqkxzOzhEfnUMs+gaom5oQwOTupaEtTY7u+1nfEmJEbGNMjMv64fBb x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39450400003)(39410400002)(39860400002)(39850400002)(39400400002)(377454003)(13464003)(377424004)(24454002)(7736002)(229853002)(14454004)(478600001)(3280700002)(102836003)(7696004)(9686003)(50986999)(3660700001)(66066001)(76176999)(966005)(54906002)(6306002)(99286003)(55016002)(3846002)(54356999)(74316002)(5660300001)(2906002)(8666007)(6436002)(6116002)(4326008)(2900100001)(33656002)(2950100002)(561944003)(8676002)(305945005)(189998001)(81166006)(53546010)(38730400002)(8936002)(93886004)(86362001)(53936002)(6506006)(77096006)(25786009)(491001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1146; H:DM5PR12MB1243.namprd12.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-office365-filtering-correlation-id: 58a1008d-0a9c-454f-2d52-08d4c4b8ea27 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR12MB1146; x-ms-traffictypediagnostic: DM5PR12MB1146: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(125551606395959)(236129657087228)(767451399110)(162533806227266)(31960201722614)(228905959029699)(247924648384137); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(2017060910053)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR12MB1146; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR12MB1146; x-forefront-prvs: 03607C04F0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2017 21:49:44.5703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1146 Subject: Re: [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 21:48:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Andrew,=20 > -----Original Message----- > From: afish@apple.com [mailto:afish@apple.com] > Sent: Thursday, July 06, 2017 4:46 PM > To: Jordan Justen > Cc: Singh, Brijesh ; edk2-devel-01 devel@lists.01.org>; Lendacky, Thomas ; > Liming Gao ; Duran, Leo ; > Mike Kinney ; Jiewen Yao > ; Laszlo Ersek ; Jeff Fan > > Subject: Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization > (AMD) >=20 >=20 > > On Jul 6, 2017, at 2:42 PM, Jordan Justen > wrote: > > > > On 2017-07-06 13:11:03, Brijesh Singh wrote: > >> > >> > >> On 07/06/2017 11:45 AM, Jordan Justen wrote: > >>> On 2017-07-05 15:31:20, Brijesh Singh wrote: > >>>> Hi Jordan and Laszlo, > >>>> > >>>> Ping. > >>>> > >>>> It has been a while, Do you have any further feedbacks on this serie= s ? > >>>> If you want then I can rebase the patches before you commit into > upstream repos. > >>>> > >>> > >>> I'm still dissappointed by the APRIORI usage. > >>> > >>> As I understand it, you are also dissatisfied with this approach and > >>> you hope to improve things by somehow hooking into DXE Core. Is that > >>> true? If so, can you create a bugzilla regarding this feature? When > >>> would you plan to work to address that? > >>> > >> > >> I think we agree in that this particular use-case has shown the need > >> for re-thinking the existing GCD interface. However, the problem we > >> are trying to solve with this patch-set is enabling the SEV feature. > >> As it turns out, we can do so within the existing GCD framework by sim= ply > leveraging the APRIORI hook already in use by OvmfPkg. > >> > >> In that context, our proposal is that we limit the scope of this > >> patch-set to simply enabling the SEV feature, and then allow the 'GCD > >> experts' to separately propose updates to the framework. > > > > This sounds like you don't plan to work on this, but will just leave > > it to the 'GCD experts'. Is that right? > > > > I am asking that you file and own a bugzilla for this. You'd obviously > > need to work with the package owners though. Unless you drive this, I > > don't think anyone will be motivated enough to get it fixed. > > >=20 > If some one will make a write up on this mailing list summarizing the iss= ue > with the GCD design, and what features are needed I can start a > conversation on the PI working group list. >=20 > Thanks, >=20 > Andrew Fish [Duran, Leo]=20 Excellent proposal, thanks! How about we do that on a separate thread (maybe with a reference back to t= his one, if needed for context)? Basically, we would like these patch-set to move upstream independent of th= e GCD write-up. I hope that's reasonable & agreeable by all. Leo. >=20 > > -Jordan > > > >> > >>> I guess with that resolved, you could add an Acked-by from me. > >>> > >>> In general, it'd also be nice to move the processor features to more > >>> generic places, although that may be challenging if the next step is > >>> some kind of platform hook from DXE Core. Maybe if the DXE Core > >>> calls out to some protocol or signals an event then a driver in > >>> UefiCpuPkg could handle the protocol implementation to modify the > page tables. > >>> > >>> -Jordan > >>> > >>> > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel