From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0625.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe40::625]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 328F081A14 for ; Fri, 6 Jan 2017 08:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eLKY/GW2HMKfXgCW1zR43ZXViNUgbrBtfrQOYpQ+mg4=; b=Dkf5K26vaEql0YlboySDNRCQy9r9PVSvAlpp31ohJttN3U09rMwRJoXqpOWvWIMi/qCt4dhlz1eoGbk15MXciz+HQtndd/7vamxGpHnRQKjXIivp1QDKM5A38/3MnvIhVVUHiL9jfw7QynUYKGnIuXiuq+dQGodlSLT+kG/2u14= Received: from DM5PR12MB1243.namprd12.prod.outlook.com (10.168.237.22) by BY2PR12MB0663.namprd12.prod.outlook.com (10.163.113.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.817.10; Fri, 6 Jan 2017 16:30:16 +0000 Received: from DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) by DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) with mapi id 15.01.0817.009; Fri, 6 Jan 2017 16:30:15 +0000 From: "Duran, Leo" To: "edk2-devel@lists.01.org" CC: "Singh, Brijesh" , "lersek@redhat.com" , "jordan.l.justen@intel.com" , "jeff.fan@intel.com" , "michael.d.kinney@intel.com" , "liming.gao@intel.com" , "maurice.ma@intel.com" , "prince.agyeman@intel.com" , "ruiyu.ni@intel.com" , "kelly.steele@intel.com" , "david.wei@intel.com" , "mang.guo@intel.com" Thread-Topic: [PATCH v4 0/9] BaseIoFifoLib Thread-Index: AQHSaDl3EltVQHvzMU6662cywTevr6Ero2WA Date: Fri, 6 Jan 2017 16:30:14 +0000 Message-ID: References: <1483719899-16125-1-git-send-email-leo.duran@amd.com> In-Reply-To: <1483719899-16125-1-git-send-email-leo.duran@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.77.1] x-microsoft-exchange-diagnostics: 1; BY2PR12MB0663; 7:B4x/w9XvVVCq589rV+n6nIjRypZymYxtLUxK7nY2v+x62j3kRZhjE/2WY8wfMn/gWNLalKgscpkU0UR521FEmxMtkrPgxKNJkArplrQvZQE8nE23kJvNfZUzs5W6Yd5ulzisA9YnRSHvK1IBrRTfp2bv67onjI5yCwe1lAEgQCaLG8qUOuAZUTyX+wYfnrDHNZGnrvU5nFauFB+kRaz/j1W32hbDZOV7Nm8m8UUHVkY1y+2cdrmjRHlT4mmYqrpXPRId5czb21S2WFof0TcAHNKAubnX2fGMkEXAAyvYyfEFRD3rOVnjSCDGlHg2CDk2Cz7D2xpJ++ffuwPuNlf4E/lFK052AqeJrTUKKIrpUCwHl7OLUMZzRFvspsfUDwq5tXBBVMDeVdpKfQNv3TN2xR/0mX9GrfpcZ0r/3Dt9YIYX7AOjRwZmqPdxPSP9ZhK+jf+zYEdgpzSMKMC9FKoonw==; 20:bra84R6a7EludvbroJQHE7dnZ9w2DKVrutX455kjKYee1ADMdXvZ805lXl/BpSqPRfyo6KIXy3Pm0CljWR/DZjStkJ9skb3tGnp/QyUrGTyzBjfz/RH8Syq1Hd2c98TRePnQQbQhSS+1XKdNUn48P9VgNkLfyfCvS+0utqOqGLRPv679B7OpPlAaJC+NHSDwmn5TUYljE2wWLYASjCMQQ0bKMRHMwiELCsihbhkzF7cDL6CwuOeytmLVSIlJIFUl x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6029001)(6009001)(7916002)(39840400002)(39450400003)(39850400002)(39860400002)(39410400002)(13464003)(377454003)(189002)(199003)(9686002)(25786008)(7416002)(3846002)(7736002)(305945005)(2501003)(74316002)(4326007)(105586002)(102836003)(2351001)(33656002)(81156014)(6116002)(3900700001)(86362001)(2906002)(5660300001)(3280700002)(8676002)(68736007)(76176999)(6916009)(81166006)(122556002)(66066001)(50986999)(189998001)(7696004)(6436002)(106116001)(106356001)(2900100001)(97736004)(38730400001)(92566002)(110136003)(229853002)(55016002)(54906002)(3660700001)(6506006)(77096006)(101416001)(54356999)(5640700003)(99286003)(2950100002)(8936002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR12MB0663; H:DM5PR12MB1243.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: fcaa1878-d403-4f62-6207-08d436514b55 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR12MB0663; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558021)(6072148); SRVR:BY2PR12MB0663; BCL:0; PCL:0; RULEID:; SRVR:BY2PR12MB0663; x-forefront-prvs: 01792087B6 received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2017 16:30:14.8809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0663 Subject: Re: [PATCH v4 0/9] BaseIoFifoLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 16:30:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In "Changes since v3:" I forgot to include: - Add #include directive to"QemuFwCfgLib.c". Thanks, Leo. > -----Original Message----- > From: Duran, Leo > Sent: Friday, January 06, 2017 10:25 AM > To: edk2-devel@lists.01.org > Cc: Singh, Brijesh ; lersek@redhat.com; > jordan.l.justen@intel.com; jeff.fan@intel.com; michael.d.kinney@intel.com= ; > liming.gao@intel.com; maurice.ma@intel.com; prince.agyeman@intel.com; > ruiyu.ni@intel.com; kelly.steele@intel.com; david.wei@intel.com; > mang.guo@intel.com; Duran, Leo > Subject: [PATCH v4 0/9] BaseIoFifoLib >=20 > The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have > duplicate implementations of I/O Fifo routines. The patch series moves th= e > I/O Fifo routines into a common BaseIofifoLib library supporting IA32 and= X64 > architectures under MdePkg. >=20 > The intent of this patch series is twofold: > 1) Consolidate I/O Fifo routines into a common BaseIofifoLib library. > 2) Allow override of BaseIofifoLib for specific platform implementations. > For example, the OVMF package can provide its own version of BaseIoFifoLi= b > to support Secure Encrypted Virtualization (SEV) guests, since SEV does n= ot > support string I/O instructions (rep ins/outs), and requires unrolled loo= ps of > single in/out instructions. >=20 > Changes since v3: > - Split patch (1 to 6 patches) to modify .DSC files per top-level package >=20 > Brijesh Singh (9): > MdePkg: Add BaseIoFifoLib library > CorebootPayloadPkg: Modify .DSC files that include > UefiCpuPkg/CpuIo2Dxe > DuetPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe > OvmfPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe > QuarkPlatformPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe > UefiCpuPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe > Vlv2TbltDevicePkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe > Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library. > Modify QemuFwCfgLib to use new BaseIoFifoLib library. >=20 > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 3 + > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 3 + > DuetPkg/DuetPkgIa32.dsc | 2 + > DuetPkg/DuetPkgX64.dsc | 2 + > MdePkg/Include/Library/IoFifoLib.h | 176 +++++++++++++ > MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf | 44 ++++ > .../Library/BaseIoFifoLib}/Ia32/IoFifo.asm | 280 ++++++++++-----= ------ > .../Library/BaseIoFifoLib}/Ia32/IoFifo.nasm | 272 ++++++++++-----= ----- > .../Library/BaseIoFifoLib}/X64/IoFifo.asm | 252 +++++++++------= ---- > .../Library/BaseIoFifoLib}/X64/IoFifo.nasm | 250 +++++++++------= --- > MdePkg/MdePkg.dec | 4 + > MdePkg/MdePkg.dsc | 2 + > OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 ---- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 55 +--- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | 8 +- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 8 +- > OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm | 52 ---- > OvmfPkg/OvmfPkgIa32.dsc | 2 + > OvmfPkg/OvmfPkgIa32X64.dsc | 2 + > OvmfPkg/OvmfPkgX64.dsc | 2 + > QuarkPlatformPkg/Quark.dsc | 2 + > QuarkPlatformPkg/QuarkMin.dsc | 2 + > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c | 3 +- > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.h | 3 + > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf | 12 +- > UefiCpuPkg/UefiCpuPkg.dsc | 2 + > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 + > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 + > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 + > 29 files changed, 795 insertions(+), 709 deletions(-) create mode 10064= 4 > MdePkg/Include/Library/IoFifoLib.h > create mode 100644 MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf > rename {UefiCpuPkg/CpuIo2Dxe =3D> > MdePkg/Library/BaseIoFifoLib}/Ia32/IoFifo.asm (96%) rename > {UefiCpuPkg/CpuIo2Dxe =3D> > MdePkg/Library/BaseIoFifoLib}/Ia32/IoFifo.nasm (96%) rename > {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoFifoLib}/X64/IoFifo.asm > (97%) rename {UefiCpuPkg/CpuIo2Dxe =3D> > MdePkg/Library/BaseIoFifoLib}/X64/IoFifo.nasm (97%) delete mode 100644 > OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm > delete mode 100644 > OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm >=20 > -- > 1.9.1