Re: [RFC v2 0/6] DxeBmDmaLib (BmDmaLib class) library

["Duran, Leo" <leo.duran@amd.com>]

Feng, Star, et al, 

Any comments, questions or concerns?

Thanks,
Leo.

> -----Original Message-----
> From: Duran, Leo
> Sent: Friday, January 13, 2017 4:14 PM
> To: edk2-devel@lists.01.org
> Cc: lersek@redhat.com; jordan.l.justen@intel.com; feng.tian@intel.com;
> star.zeng@intel.com; maurice.ma@intel.com; prince.agyeman@intel.com;
> ard.biesheuvel@linaro.org; Singh, Brijesh <brijesh.singh@amd.com>; Duran,
> Leo <leo.duran@amd.com>
> Subject: [RFC v2 0/6] DxeBmDmaLib (BmDmaLib class) library
> 
> This series provides an abstraction layer for Bus-master DMA operations as
> currently implemented by the PciHostBridgeDxe driver. The intent is to then
> allow override of this library as may be required by specific hardware
> implementations, such as AMD's Secure Encrypted Virtualization (SEV).
> 
> Please refer to the RFC discussion for SEV here:
> http://marc.info/?l=linux-mm&m=147190814023863&w=2
> 
> This new (BmDmaLib class) library is cloned from the existing DmaLib with an
> additional DmaAbove4GB (BOOLEAN) parameter for the Map and Allocate
> interfaces, so that decisions can be made about the need to allocate DMA
> buffers below the 4GB boundary.
> 
> NOTE: The abstraction layer is intended for Bus-master (DMA capable)
> devices, and not restricted to the PCI Root-Bridge use-case. Thus the
> rationale for not using EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_OPERATION
> types.
> 
> Changes since RFC v1:
> - Patch 1: Restrict LIBRARY_CLASS to DXE_DRIVER in INF file.
> - Patches 2 through 5:
>   Change Subject: XxxPkg: Resolve BmDmaLib class for PciHostBridgeDxe
> driver
>   Add Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> - Add clarifications from RFC discussion to this cover letter.
> 
> Leo Duran (6):
>   MdeModulePkg: Add DxeBmDmaLib (BmDmaLib class) library
>   ArmVirtPkg: Resolve BmDmaLib class for PciHostBridgeDxe driver
>   CorebootPayloadPkg: Resolve BmDmaLib class for PciHostBridgeDxe driver
>   MdeModulePkg: Resolve BmDmaLib class for PciHostBridgeDxe driver
>   OvmfPkg: Resolve BmDmaLib class for PciHostBridgeDxe driver
>   MdeModulePkg: Modify PciHostBridgeDxe to use new BmDmaLib library
> 
>  ArmVirtPkg/ArmVirtQemu.dsc                         |   1 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                   |   1 +
>  CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc      |   1 +
>  CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc   |   1 +
>  .../Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf  |   1 +
>  .../Bus/Pci/PciHostBridgeDxe/PciRootBridge.h       |  13 +-
>  .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c     | 272 +++++----------------
>  MdeModulePkg/MdeModulePkg.dsc                      |   3 +
>  OvmfPkg/OvmfPkgIa32.dsc                            |   1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                         |   1 +
>  OvmfPkg/OvmfPkgX64.dsc                             |   1 +
>  11 files changed, 76 insertions(+), 220 deletions(-)
> 
> --
> 1.9.1