Re: LocalApicLib: Why two separate directories?

["Duran, Leo" <leo.duran@amd.com>]

> -----Original Message-----
> From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
> Sent: Friday, October 28, 2016 2:28 PM
> To: Duran, Leo <leo.duran@amd.com>; edk2-devel@ml01.01.org; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Fan, Jeff <jeff.fan@intel.com>; Gao, Liming <liming.gao@intel.com>;
> 'Laszlo Ersek' <lersek@redhat.com>
> Subject: RE: LocalApicLib: Why two separate directories?
> 
> Leo,
> 
> Your observation is correct, but the reason not to make this change now is
> the DSC file changes required that would break platform builds.  As Laszlo
> points out, it is possible to do this type of change and coordinate update to all
> platforms in edk2/master.  However, there are many other platforms that
> use edk2 and a change like this would break them on next pull of
> edk2/master.
> 
> I believe the original X2 APIC implementation did not have as much common
> code, so that was likely why it was added as a different library.
> 
> I recommend we just leave them in their own directories for right now.
> 
> Thanks,
> 
> Mike
> 
[Duran, Leo] 
Yes, that was my main concern.
I suppose that in hindsight the two libraries could have being  built from a common directory, allowing for (future) refactoring of code with breaking the .DSC's
But, it is what it is... Thanks for the comments.
Leo


> 
> > -----Original Message-----
> > From: Duran, Leo [mailto:leo.duran@amd.com]
> > Sent: Friday, October 28, 2016 12:04 PM
> > To: edk2-devel@ml01.01.org
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Fan, Jeff
> > <jeff.fan@intel.com>; Gao, Liming <liming.gao@intel.com>; 'Laszlo
> > Ersek' <lersek@redhat.com>
> > Subject: LocalApicLib: Why two separate directories?
> >
> > All,
> > Just a quick observation to request comments:
> >
> > Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is
> > the same, how about we merge the common code and build the libraries
> from the same directory?
> >
> > UefiCpuPkg/Library/LocalApilLib/
> > - LocalApicLib.c --> common code
> > - BaseXApicLib.c --> legacy APIC code
> > - BaseXApicX2ApicLib.c --> X2APIC code
> > - BaseXApicLib.inf -> builds from LocalApicLib.c + BaseXApicLib.c
> > - BaseXApicX2ApicLib.inf -> builds from LocalApicLib.c +
> > BaseXApicX2ApicLib.c
> >
> > Of course, doing this would require modification to existing .DSC
> > files, to point to the appropriate .INF under the merged LocalApicLib
> directory.
> > Would that be too disruptive?
> >
> > Leo.
> >
> >
> >
> >