From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on062a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe4a::62a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 43D5181DEF for ; Fri, 28 Oct 2016 12:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=grwaLeSdVXJXNYD2QnYDFi2MJiyr5n+xvxtxSFQebo0=; b=MzXx7kuME47RWBmyr0p9fnRm33rnI3SyyPIUQjCd3JwVLaHTlN2/B8A6FmYu2BnQMj49w52Eleb3ThggtMn1kknb0/Wth5HsvGu22CQt6gmzGST+yWmYBuEqA2KPJxkK1KpGhzhhcf3Y4T33s0MBut7tl8FSMyQFa69bkDJs0eY= Received: from DM5PR12MB1243.namprd12.prod.outlook.com (10.168.237.22) by DM5PR12MB1241.namprd12.prod.outlook.com (10.168.237.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Fri, 28 Oct 2016 19:36:58 +0000 Received: from DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) by DM5PR12MB1243.namprd12.prod.outlook.com ([10.168.237.22]) with mapi id 15.01.0679.018; Fri, 28 Oct 2016 19:36:58 +0000 From: "Duran, Leo" To: "'Kinney, Michael D'" , "edk2-devel@ml01.01.org" CC: "Fan, Jeff" , "Gao, Liming" , 'Laszlo Ersek' Thread-Topic: LocalApicLib: Why two separate directories? Thread-Index: AdIxTgPHfJzAAk7nTwONwEQmJGazqwAAFg9wAADgWrA= Date: Fri, 28 Oct 2016 19:36:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.77.1] x-ms-office365-filtering-correlation-id: f9dacdd7-c5a1-4faa-4d0b-08d3ff69c7fd x-microsoft-exchange-diagnostics: 1; DM5PR12MB1241; 7:6ZqIMSzz99arrshx9K9Wyqu0ZzzcI0J6kgwjDNyv2DEDFrV+ck4wMHou4bHZ5ikMs50Up8wYHD0TLE3Rjh1NwdzgMMWrM17vdwN/BhR5HnYnfWrFVZL/5UTG34sd6hnPBwizUMm7dJjehdMgUJdRExKwPm/R5pQFvdkXDfu5FOP73mfGuj+7ueKz2gYs6d241Zoereuu9ycjpphRX5sxZ03qI1l0+F55lJ/hyc+nbUslNObCEaBxhyR4uBpt4yq0coU/Z9wl/z341usrXH4OFQcLIFTCbZDHeRWs2q0hqvvbb+nYdVOPoifnzla/2R9TlTWGnuK6jCwwWZ7U834zXVMJE2L2HXpqAVl7NxTNqXQ=; 20:tPU5rutUQUxD07+eZTcIBC0fXUW6Lqjeb/Ov9LscdjJQW6Zh03tb08ujdeBopI/r88y6Rl8mMSrtDstS/Mn9zVVX//YEHYdaFblIql9aifJUWGnriWMzd2eFcLRnWWme/J5wupImZysnaHq3E/uw4HzuRafqNovQaalSfIGWKev+n0nrfYsM2xQRGybWx7t8EVO95Jzwsj4oOLIc+Lo6jY5loI2YZj1xNZVgeDWqx1ZYCTNdanYMZCqD8CVaGaAT x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1241; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:DM5PR12MB1241; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1241; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(199003)(51914003)(189002)(377454003)(106356001)(2501003)(99286002)(101416001)(7846002)(105586002)(92566002)(11100500001)(4326007)(10400500002)(33656002)(5002640100001)(86362001)(9686002)(7736002)(2900100001)(189998001)(77096005)(2906002)(81156014)(586003)(19580405001)(19580395003)(2950100002)(5001770100001)(3280700002)(81166006)(8676002)(3846002)(3660700001)(102836003)(76576001)(7696004)(74316002)(6116002)(66066001)(97736004)(8936002)(305945005)(68736007)(50986999)(54356999)(87936001)(5660300001)(76176999)(122556002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1241; H:DM5PR12MB1243.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2016 19:36:57.8975 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1241 Subject: Re: LocalApicLib: Why two separate directories? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 19:36:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Kinney, Michael D [mailto:michael.d.kinney@intel.com] > Sent: Friday, October 28, 2016 2:28 PM > To: Duran, Leo ; edk2-devel@ml01.01.org; Kinney, > Michael D > Cc: Fan, Jeff ; Gao, Liming ; > 'Laszlo Ersek' > Subject: RE: LocalApicLib: Why two separate directories? >=20 > Leo, >=20 > Your observation is correct, but the reason not to make this change now i= s > the DSC file changes required that would break platform builds. As Laszl= o > points out, it is possible to do this type of change and coordinate updat= e to all > platforms in edk2/master. However, there are many other platforms that > use edk2 and a change like this would break them on next pull of > edk2/master. >=20 > I believe the original X2 APIC implementation did not have as much common > code, so that was likely why it was added as a different library. >=20 > I recommend we just leave them in their own directories for right now. >=20 > Thanks, >=20 > Mike >=20 [Duran, Leo]=20 Yes, that was my main concern. I suppose that in hindsight the two libraries could have being built from = a common directory, allowing for (future) refactoring of code with breaking= the .DSC's But, it is what it is... Thanks for the comments. Leo >=20 > > -----Original Message----- > > From: Duran, Leo [mailto:leo.duran@amd.com] > > Sent: Friday, October 28, 2016 12:04 PM > > To: edk2-devel@ml01.01.org > > Cc: Kinney, Michael D ; Fan, Jeff > > ; Gao, Liming ; 'Laszlo > > Ersek' > > Subject: LocalApicLib: Why two separate directories? > > > > All, > > Just a quick observation to request comments: > > > > Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is > > the same, how about we merge the common code and build the libraries > from the same directory? > > > > UefiCpuPkg/Library/LocalApilLib/ > > - LocalApicLib.c --> common code > > - BaseXApicLib.c --> legacy APIC code > > - BaseXApicX2ApicLib.c --> X2APIC code > > - BaseXApicLib.inf -> builds from LocalApicLib.c + BaseXApicLib.c > > - BaseXApicX2ApicLib.inf -> builds from LocalApicLib.c + > > BaseXApicX2ApicLib.c > > > > Of course, doing this would require modification to existing .DSC > > files, to point to the appropriate .INF under the merged LocalApicLib > directory. > > Would that be too disruptive? > > > > Leo. > > > > > > > >