From: "Duran, Leo" <leo.duran@amd.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems.
Date: Sat, 14 Oct 2017 16:04:08 +0000 [thread overview]
Message-ID: <DM5PR12MB1243F2CB6F244F7F882A2BE9F9490@DM5PR12MB1243.namprd12.prod.outlook.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A9E505E@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Yao, Jiewen [mailto:jiewen.yao@intel.com]
> Sent: Thursday, October 12, 2017 8:53 PM
> To: Duran, Leo <leo.duran@amd.com>; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based
> x86 systems.
>
> HI Leo
> Thank you very much. This patch looks good to me in general.
>
> Some minor comment:
>
> 1) For AMD smm save state.
> I saw Paolo gave the comment on how to detect AMD save state. I do not
> have strong opinion on that. I think you and Paolo can make decision.
>
> I recommend we move AMD_SMRAM_SAVE_STATE_MAP_OFFSET to
> UefiCpuPkg\Include\Register\Amd\SmramSaveStateMap.h, because it is
> standard.
Hi Yao,
Sure thing, I will do that.
Leo
> +//
> +// Definitions for AMD systems are based on contents of the // AMD64
> +Architecture Programmer's Manual // Volume 2: System Programming,
> +Section 10 System-Management Mode // #define
> +AMD_SMRAM_SAVE_STATE_MAP_OFFSET 0xfe00
>
> We can leave AMD_SMM_PSD_OFFSET in UefiCpuPkg/PiSmmCpuDxeSmm,
> if it is implementation specific.
> +#define AMD_SMM_PSD_OFFSET 0xfc00
>
>
>
> 2) For Intel save state, I assume you already did some test to make sure
> there is no regression.
> If so, would you please add some description on what test you have done?
> For example,
> If both IA32 and X64 are validated?
> If all three .S, .asm, .nasm are validated?
> If OS boot and S3 resume are validated?
>
> If you did any other test, please also add.
>
Hi Yao,
I have not done runtime validation testing.
Instead, I tested the assembly code snippets in a vacuum (in their .asm, .nasm, and .S forms),
to ensure the source produced the expected compiled code, and the expected execution.
So any runtime 'Tested-by' would be greatly appreciated
Thanks,
Leo.
> Thank you
> Yao Jiewen
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Leo Duran
> > Sent: Thursday, October 12, 2017 3:45 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based x86
> > systems.
> >
> > This patch-set replaces Intel-specific macros with global variables to
> > provide support for AMD-based x86 systems.
> >
> > The replaced macros are:
> > 1) SRAM_SAVE_STATE_MAP_OFFSET
> > 2) TXT_SMM_PSD_OFFSET
> > 3) SMM_PSD_OFFSET
> >
> > Changes since v4:
> > Make runtime CPUID checks and use global variables instead of PCD's.
> >
> > Changes since v3:
> > Correction on cover letter.
> >
> > Changes since v2:
> > The intent of this revision is to maintain compatibility with existing
> > packages. To that end, changes to OvmgfPkg and QuarkSocPkg are
> reverted.
> > Moreover, pertinent macros are replaced in the C code, rather than on
> > header files that are shared globally.
> >
> > Changes since v1:
> > Revision to Cc list for UefiCpuPkg.
> >
> > Leo Duran (2):
> > UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros
> > UefiCpuPkg/PiSmmCpuDxeSmm: Use global variables to replace macros
> >
> > .../Library/SmmCpuFeaturesLib/Ia32/SmiEntry.S | 28 ++++++---
> > .../Library/SmmCpuFeaturesLib/Ia32/SmiEntry.asm | 29 ++++++---
> > .../Library/SmmCpuFeaturesLib/Ia32/SmiEntry.nasm | 43 +++++++++----
> > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCommon.h | 48
> > +++++++++++++++
> > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 59
> > +++++++++++++++---
> > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 3 +
> > .../SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf | 3 +
> > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 39 ++++++++++-
> -
> > .../Library/SmmCpuFeaturesLib/X64/SmiEntry.S | 28 ++++++---
> > .../Library/SmmCpuFeaturesLib/X64/SmiEntry.asm | 30 ++++++---
> > .../Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 47 ++++++++++----
> > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/Semaphore.c | 22 ++++---
> > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.S | 28 ++++++---
> > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm | 21 +++++--
> > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 43
> > +++++++++----
> > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 72
> > ++++++++++++++++++++--
> > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 17 ++++-
> > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 18
> +++---
> > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 20 +++---
> > UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 22 ++++---
> > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S | 34 ++++++----
> > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm | 22 +++++--
> > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 45
> > ++++++++++----
> > 23 files changed, 547 insertions(+), 174 deletions(-) create mode
> > 100644 UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCommon.h
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-10-14 16:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 19:45 [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems Leo Duran
2017-10-11 19:45 ` [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros Leo Duran
2017-10-12 21:40 ` Paolo Bonzini
2017-10-14 15:51 ` Duran, Leo
2017-10-15 15:26 ` Paolo Bonzini
2017-10-17 14:19 ` Duran, Leo
2017-10-17 14:23 ` Laszlo Ersek
2017-10-17 14:37 ` Paolo Bonzini
2017-10-17 14:50 ` Duran, Leo
2017-10-17 15:16 ` Paolo Bonzini
2017-10-17 14:50 ` Yao, Jiewen
2017-10-17 15:14 ` Laszlo Ersek
2017-10-17 16:40 ` Duran, Leo
2017-10-18 1:50 ` Yao, Jiewen
2017-10-18 14:36 ` Duran, Leo
2017-10-19 7:00 ` Laszlo Ersek
2017-10-19 17:02 ` Duran, Leo
2017-10-17 16:30 ` Duran, Leo
2017-10-11 19:45 ` [PATCH v5 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: " Leo Duran
2017-10-13 1:52 ` [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems Yao, Jiewen
2017-10-13 2:36 ` Yao, Jiewen
2017-10-14 16:04 ` Duran, Leo [this message]
2017-10-15 0:58 ` Yao, Jiewen
2017-10-16 17:06 ` Laszlo Ersek
2017-10-16 17:08 ` Paolo Bonzini
2017-10-16 17:31 ` Duran, Leo
2017-10-16 18:44 ` Laszlo Ersek
2017-10-16 18:56 ` Duran, Leo
2017-10-14 16:08 ` Duran, Leo
2017-10-16 17:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB1243F2CB6F244F7F882A2BE9F9490@DM5PR12MB1243.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox