From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=216.228.121.143; helo=hqemgate14.nvidia.com; envelope-from=jbrasen@nvidia.com; receiver=edk2-devel@lists.01.org Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D56C0211A206C for ; Thu, 13 Dec 2018 11:14:28 -0800 (PST) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 13 Dec 2018 11:14:24 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 13 Dec 2018 11:14:27 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 13 Dec 2018 11:14:27 -0800 Received: from HQMAIL102.nvidia.com (172.18.146.10) by HQMAIL108.nvidia.com (172.18.146.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 13 Dec 2018 19:14:27 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL102.nvidia.com (172.18.146.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 13 Dec 2018 19:14:27 +0000 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.52) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 13 Dec 2018 19:14:27 +0000 Received: from DM5PR12MB2439.namprd12.prod.outlook.com (52.132.141.32) by DM5PR12MB1818.namprd12.prod.outlook.com (10.175.91.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.22; Thu, 13 Dec 2018 19:14:25 +0000 Received: from DM5PR12MB2439.namprd12.prod.outlook.com ([fe80::b466:38b9:472b:54d8]) by DM5PR12MB2439.namprd12.prod.outlook.com ([fe80::b466:38b9:472b:54d8%6]) with mapi id 15.20.1404.026; Thu, 13 Dec 2018 19:14:25 +0000 From: Jeff Brasen To: Leif Lindholm , Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Girish Pathak Thread-Topic: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function Thread-Index: AQHUh1oZxy8arM6ru0amFYDIUKOd+6Vw6Nq8gAEQ5wCAAAEjsIAAA0kAgAmJvgCAABWxUA== Date: Thu, 13 Dec 2018 19:14:25 +0000 Message-ID: References: <51b70aa08f34e31ac4e19bebdc96d5298691e9ba.1543437347.git.jbrasen@nvidia.com> <20181212184846.6e7tortqtl2lxnvc@bivouac.eciton.net> In-Reply-To: <20181212184846.6e7tortqtl2lxnvc@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=jbrasen@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2018-12-13T19:14:23.9580820Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic; Sensitivity=Unrestricted authentication-results: spf=none (sender IP is ) smtp.mailfrom=jbrasen@nvidia.com; x-originating-ip: [216.228.112.22] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR12MB1818; 6:A71DMEINnQdJumo5gjhZe7f0IQQP/lcHqHW31uC8W7TORFnaFBMSv+dPXmrsEJSCkHAHjiawdQlz0TL/Kdo/bfvHt1Q35RlKeUrYN1x9FtbiDetIf9hadqJ88s0MO3nNeBzohA94Q9h/XQTG2+hb1S62fXVWN7UsBpRIjLcrLSi5gMKbWh90eoYC9qsir5v/cXvBzt6zVIHfOA2KGdDutOGziuZZ5BNxlpBNyTdzIZ9JFjomUXqeSjr7b9ggdRiL82aw5C+vwcaAUds0chzoRHtOriIcnpYrokLoK2bVR7A1lPUXrqXK/IrOmtiHL0mk0wxm445fp9rdU6xpVk2sYDyJNkeZicTFgljpb/DxBgArN8FNNVCKlWV4EOa2v5MgRbbE5eYJlAvG3GDqRLF8+j/9nsNTBzXxVgipvTb4E6Hh9ZOj7tJtXYZKiQe/GKEpzOVPJKFSX8BsfjpP4ma+ZA==; 5:ReRQqs8APbtORXsfVTFrXEe6rKASjvKbJsOy5cqtufsJ9jhapQrB8xylPsKfdRzZOrewX0p/OLfNOpcmwWkCbS0lU2TYWGWhhotOe7F2AVxuM/gSfyHN8MZpOO6YFytKSE4a98iK43TKnJMLP5nPPE6OYjjGYYw8ttJuIFLJAbA=; 7:UCZ84Hm1X+vYNx78FL7xVsbAxJEmSgNjpkxBilBAsqoRLl0g5MwwbLfYfvqaSK7mxDTvmzWeBI1+SWPrJFVNK/CxCiu84UR9QbFUlGMLMuzAN6sRJBJ7BRMPDKW2xkxCUJty6G66wIXldi8ZA53UBw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: dd356edd-a108-4724-7f3c-08d6612f3278 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM5PR12MB1818; x-ms-traffictypediagnostic: DM5PR12MB1818: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231475)(944501520)(52105112)(10201501046)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DM5PR12MB1818; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1818; x-forefront-prvs: 088552DE73 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(396003)(366004)(199004)(189003)(13464003)(11346002)(229853002)(2906002)(316002)(71190400001)(66066001)(14454004)(110136005)(93886005)(54906003)(4326008)(6436002)(71200400001)(68736007)(7696005)(74316002)(305945005)(53936002)(476003)(5660300001)(33656002)(53546011)(106356001)(9686003)(478600001)(55016002)(81156014)(81166006)(186003)(486006)(99286004)(8676002)(105586002)(102836004)(25786009)(256004)(6246003)(6506007)(7736002)(97736004)(26005)(3846002)(8936002)(446003)(76176011)(6116002)(14444005)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1818; H:DM5PR12MB2439.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: SuuZtxBijIRGMHcpZkKSC9fJbG7Io99Qx1/tvmvWwPYrRbFjgxloc0OxuiDq/SEzQOPdeEr85e+FhJQ2O9YKAsb/g962Xxmr6I7QBRNwl+nAMWjaUNCzygHMjyXojhvUCO5f9evrZjhZS27FTSOqBd31QZfD+bhrEoiIqAvKIGprGatmj4PUSyZxGQpIVVaKmgTEIVieBAwPhvmUSnNlWXbVPg5qbZnA8iZv/DNLlYC3o2cB8zf0S3Afaw4EG3XUHTdpbpxQtVe2pAlLN72M76K2b1gylxoyc+4ah+gxsoK4I10+EHVUWC2+Ebp8iovY spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dd356edd-a108-4724-7f3c-08d6612f3278 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2018 19:14:25.5797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1818 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1544728464; bh=bci4ijgWT+qvVLQ6gwZ8rci2knv9hIZhQj5K/UaxjZ8=; h=X-PGP-Universal:From:To:CC:Subject:Thread-Topic:Thread-Index:Date: Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:msip_labels:authentication-results: x-originating-ip:x-ms-publictraffictype: x-microsoft-exchange-diagnostics: x-ms-exchange-antispam-srfa-diagnostics: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck:x-exchange-antispam-report-cfa-test: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-microsoft-antispam-message-info:spamdiagnosticoutput: spamdiagnosticmetadata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=AjWTwnI0ozzYSZqHu7u8RMiJhvgWUSsmtaK2fdn3hF2PLS/pTkJjE1FPJawnIHecz YVrpahJuMpHjwjL9szvvaGgCfcfoUMgyKJB32BWpMa3/PSoBm8C4yJE+UZxLXL6jm8 I4VslFV627EQNTY/8bIUzva4oy5Qh/CiDu13pLX8wljTE74GlLTpqq8mY0VmbaG2RP yPel6G5Xzb23vp+YXvJ+GRTtwnqToSyLGqbMgUJplsk8jmVjv91prkytFc1NOcYOTE aPvPrkoeT3Zgjo4OrjxXtV6GBgpGY81FjGXEbCCVTZBpsFBpWUmDg80Qefr1hXkN3V pKVdH6LeuUf3w== Subject: Re: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 19:14:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: Leif Lindholm =20 Sent: Wednesday, December 12, 2018 11:49 AM To: Ard Biesheuvel Cc: Jeff Brasen ; edk2-devel@lists.01.org; Girish Pat= hak Subject: Re: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function On Thu, Dec 06, 2018 at 06:09:26PM +0100, Ard Biesheuvel wrote: > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Thursday, December 6, 2018 9:54 AM > > To: Jeff Brasen > > Cc: edk2-devel@lists.01.org; Leif Lindholm=20 > > ; Girish Pathak > > Subject: Re: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function > > > > On Thu, 6 Dec 2018 at 01:37, Jeff Brasen wrote: > > > > > > Leif/Ard, > > > > > > > > > Any comments on this v2 patch for this? > > > > > > > > > > Hi Jeff, > > > > I'm not sure what level of bikeshedding is justified when it comes=20 > > to a driver such as this one, which is very recent, and mostly for=20 > > platform internal use. However, I will note that the current=20 > > versioning approach permits a *client* of the old=20 > > SCMI_CLOCK_PROTOCOL to be built that invokes ->Enable(), which is=20 > > not defined for it. This somewhat defeats the purpose of the=20 > > versioning, since the whole point is to avoid invoking ->Enable() on = > > older implementations of the protocol. > > > > I'd be fine with just modifying the protocol, but if we decide we=20 > > need versioning, we should not modify the public interface of the=20 > > old one. > > How the driver reuses one implementation to back the other is another= =20matter, of course. > > [JMB] I can either just change without versioning (that was my=20 > > original approach but I also changed the guid which would primarily=20 > > catch new clients running on old platforms from calling an undefined = > > function), I am fine with either that (with maybe a switch back to=20 > > original guid if we are not concerned about that > > issue) or a future update that creates a full v2 version of the=20 > > protocol in the header. >=20 > Maybe Leif disagrees, but I am not too concerned about just changing=20 > it. This is not a protocol that 3rd party drivers would invoke, right? It's a protocol that a 3rd party driver _could_ invoke. Whether that is a likely thing to happen, I just don't know. Or whether BIOS vendors cherry-picking things badly would cause interesti= ng things to happen. On the one hand, I would prefer to see a complete version duplication of = the protocol, just so we _won't_ let existing apps/drivers call the Enabl= e function. On the other hand, I don't think this would be the last protocol update w= e would ever see, and moving to an internally versioned interface may mak= e more sense (i.e. adding Version and possibly Size fields) would be more resilient for that. But that would still require a = full Protocol2 implementation. At which point, if we don't want to add the Version field, we may just ch= ange the original and see if we break anything? [JMB] If we add a version to this we should probably add one to the other= =20SCMI protocols as well for consistency right? I'll make a cleaner vers= ion of v2 that separates the protocols better and upload that / =20 Leif -------------------------------------------------------------------------= ---------- This email message is for the sole use of the intended recipient(s) and m= ay contain confidential information. Any unauthorized review, use, disclosure or di= stribution is prohibited. If you are not the intended recipient, please contact the= =20sender by reply email and destroy all copies of the original message. -------------------------------------------------------------------------= ----------