From: Chris Co <Christopher.Co@microsoft.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 0/2] add DwMmcHcDxe driver
Date: Wed, 15 Aug 2018 03:10:24 +0000 [thread overview]
Message-ID: <DM5PR2101MB1128723CB3F1078C580E4263943F0@DM5PR2101MB1128.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20180814163211.etfac2lrin4eecyu@bivouac.eciton.net>
> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Tuesday, August 14, 2018 9:32 AM
> To: Haojian Zhuang <haojian.zhuang@linaro.org>
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> Chris Co <Christopher.Co@microsoft.com>
> Subject: Re: [edk2][PATCH v1 0/2] add DwMmcHcDxe driver
>
> Haojian,
>
> This is kind of massive.
> Is there any way it could be broken into more patches?
> The NonDiscoverableDeviceDxe patch is OK, but the changes to
> DwMmcHcDxe are gargantuan.
>
> Chris - does any of this turn into something you could use for your platforms?
>
Thanks for pointing this out Leif. One of the main reasons we wrote our own was that we needed to support eMMC and SD, which was missing from the original EmbeddedPkg driver. I'd like to use this if possible, but I will need to spend some time reviewing it to make sure it suits our needs.
Haojian, please CC me on any followup reviews if possible.
Thanks,
Chris
> /
> Leis
>
> On Fri, Aug 10, 2018 at 04:49:13PM +0800, Haojian Zhuang wrote:
> > Changelog:
> > v1:
> > *Add NonDiscoverableDeviceDxe for embedded platform. Make
> DwMmcHcDxe driver
> > to support both eMMC and SD controller.
> >
> > Haojian Zhuang (2):
> > EmbeddedPkg: add NonDiscoverableDeviceDxe driver
> > EmbeddedPkg: add DwMmcHcDxe driver
> >
> > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec |
> 40 +
> > EmbeddedPkg/EmbeddedPkg.dec | 1 +
> > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf |
> 69 +
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eDxe.inf | 52 +
> > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h |
> 815 +++++++
> > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h |
> 983 ++++++++
> > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 +
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eIo.h | 92 +
> > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c
> | 214 ++
> > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c |
> 1295 +++++++++++
> > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c |
> 2366 ++++++++++++++++++++
> > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c |
> 1042 +++++++++
> > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104
> +++++++++
> > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c
> | 124 +
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eDxe.c | 243 ++
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eIo.c | 972 ++++++++
> > 16 files changed, 9491 insertions(+)
> > create mode 100644
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec
> > create mode 100644
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf
> > create mode 100644
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eDx
> > e.inf create mode 100644
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h
> > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h
> > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h
> > create mode 100644
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eIo
> > .h create mode 100644
> EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c
> > create mode 100644
> EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c
> > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c
> > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c
> > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c
> > create mode 100644
> > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c
> > create mode 100644
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eDx
> > e.c create mode 100644
> >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> eIo
> > .c
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > --
> > 2.7.4
> >
prev parent reply other threads:[~2018-08-15 3:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 8:49 [PATCH v1 0/2] add DwMmcHcDxe driver Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 1/2] EmbeddedPkg: add NonDiscoverableDeviceDxe driver Haojian Zhuang
2018-08-10 8:49 ` [PATCH v1 2/2] EmbeddedPkg: add DwMmcHcDxe driver Haojian Zhuang
2018-08-14 16:32 ` [PATCH v1 0/2] " Leif Lindholm
2018-08-15 3:10 ` Chris Co [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR2101MB1128723CB3F1078C580E4263943F0@DM5PR2101MB1128.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox