From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.37.120; helo=nam02-cy1-obe.outbound.protection.outlook.com; envelope-from=christopher.co@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0120.outbound.protection.outlook.com [104.47.37.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BA0A210EFAFF for ; Tue, 14 Aug 2018 20:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19RO4rvt3IgZY/ieBvAUVqtn571l/dVLqa13Da1lHPE=; b=SYhLLCthk2Y7HkapolWq3Feyx56JKDUFK/RswxLKeO/5FO7kX+rzs8/+V2nqvV5vDJ0pQnkatONQFO8TWZoGimCU9qTZ+rlxKUCRE7FXH1R32/HFuYBEZjENhQ0mqB5VEFcr+qbOPPVYnnJyBTAlBYAQHzZ550y7bu3ARQI546w= Received: from DM5PR2101MB1128.namprd21.prod.outlook.com (52.132.133.20) by DM5PR2101MB0919.namprd21.prod.outlook.com (52.132.132.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.5; Wed, 15 Aug 2018 03:10:24 +0000 Received: from DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::95a8:6c24:9ca4:e80e]) by DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::95a8:6c24:9ca4:e80e%4]) with mapi id 15.20.1080.007; Wed, 15 Aug 2018 03:10:24 +0000 From: Chris Co To: Leif Lindholm , Haojian Zhuang CC: "edk2-devel@lists.01.org" , Ard Biesheuvel Thread-Topic: [edk2][PATCH v1 0/2] add DwMmcHcDxe driver Thread-Index: AQHUM+xdWR55qtrKo06B5xZJfdDBH6TAICtg Date: Wed, 15 Aug 2018 03:10:24 +0000 Message-ID: References: <1533890955-13005-1-git-send-email-haojian.zhuang@linaro.org> <20180814163211.etfac2lrin4eecyu@bivouac.eciton.net> In-Reply-To: <20180814163211.etfac2lrin4eecyu@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=chrco@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-08-15T03:10:22.5268445Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2:3c57:6a0a:e127:3f61] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0919; 6:XztGJtkhsMNLljOwe/ysyVQzMNTiowVn+W/GeztQDdMymGybpZc+T8g+KxW3GQlcoBQg2BKAvic61qr+Gor856Ut6UfplX27hSf1e95G3YytbwP3lrF1AsfQQO8+uz8s7ijF5/+wFZiMIdt/jKQ2gb3p0b/vhUrgQVLfvmbl8xiQH5xq7/2lcFpn/KtnngQ5McQdo81U1hgttdUfLgmEukXD2wcZqeNefkXEuxO3o/5CwIKSTmtCarLVz/e31XZEuFlbFLEOURugnOpozu3Hho0vX428x2i4dHDEJH2h6eOfzocIDMYezyzZHauikjYoHPEU/x4GM+KkPAuuPtZlKI1FhVaBRgmyoudzTF5agRn9iwVd7IqtDVlv1jks2RPZK0XoIGQZZhigXWpEnR2y/rMgiBT5Sk3aIn0uc/VInq2ImGVEhfc3nQoCOoRpWX8R4SebtW6Kj1zRMlmAIaWVdw==; 5:0AJMQ8k+0bWud2Qto07pEqq7R74/cAfc+FOGQqOt84y2SnZgmDyaDK8C/EmGpnjntGo6FqI3o1STvdfT7GWdL/t2gKuX6BYOrRUxRxiyFIbQIv3d0WmDl5vsxizqIxg91q3QjxcUkx31hSv68Va2+KxVk5dKfE97C7CI1Qc19r0=; 7:57rWMuKdcK8wg/PL6ODsgSCCw1LYvGBKHkf+qFaDnMQB5GZ4TTiIH/8366DMQ4XB7MDovHPPHMi5oH5A5Lkno1T74WIOAHU2DIxJSeLq/FQoVruuel2BIWwBHq6p0nyQySiJ4DrX0g9YdPLhIVHE/0lElePoHzFw4A0eqZlUz4pEVJJUjCYaQxik7opfpumOih/0VeA7H8Oduv1CR7hawwZoqNjA50YmMNcT8M21taXaJz+CwmJIxOzBJrUlxeow x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 4a0d28ce-205f-4749-10d8-08d6025ca4a4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7193020); SRVR:DM5PR2101MB0919; x-ms-traffictypediagnostic: DM5PR2101MB0919: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Christopher.Co@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(162533806227266); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231328)(8210008)(944501410)(52105095)(2018427008)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DM5PR2101MB0919; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0919; x-forefront-prvs: 07658B8EA3 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6029001)(346002)(39860400002)(376002)(136003)(396003)(366004)(199004)(189003)(54534003)(13464003)(81166006)(8936002)(305945005)(81156014)(105586002)(2906002)(186003)(53546011)(6506007)(6116002)(102836004)(106356001)(33656002)(68736007)(8676002)(76176011)(46003)(7696005)(7736002)(4326008)(25786009)(53936002)(6246003)(478600001)(10290500003)(72206003)(97736004)(2900100001)(14454004)(8990500004)(5660300001)(99286004)(22452003)(229853002)(10090500001)(316002)(110136005)(54906003)(6436002)(86612001)(256004)(476003)(9686003)(11346002)(55016002)(86362001)(74316002)(446003)(486006)(5250100002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0919; H:DM5PR2101MB1128.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: pOmOLhz+wtoqzYd601dpC6pKXEqALUq9ZVe7Hr95dw9i1KKYf4ux0unNUeOAYiKqfkfoYS2u8hKYJ8puwwSR2yr27xth0h0zTSDUY6HwAZIC6jZyPXjfkgooeCyHcBwzUXIYlvOTrv0VDmm+8J96LvbjPu3auywTgOeAvDHnVfrEFdloWvzIuE1yIpAdX2PFzdlrOGFzagmH5V1nzl9fXma4XxIqjktRx13e36etKpkxcHs//sL9M0N3fxkCyNdKtYUNREmtC2I/+4ZC5Nh4XxcVgtjlKWfdSLFL1ShxkjQhj9OfzHwQSm8roChj0BYICNfsVry0wTeWqhwEzi9f4/s/hafcQWQkIPv7a3LiWt8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a0d28ce-205f-4749-10d8-08d6025ca4a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2018 03:10:24.0315 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0919 Subject: Re: [PATCH v1 0/2] add DwMmcHcDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 03:10:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, August 14, 2018 9:32 AM > To: Haojian Zhuang > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Chris Co > Subject: Re: [edk2][PATCH v1 0/2] add DwMmcHcDxe driver >=20 > Haojian, >=20 > This is kind of massive. > Is there any way it could be broken into more patches? > The NonDiscoverableDeviceDxe patch is OK, but the changes to > DwMmcHcDxe are gargantuan. >=20 > Chris - does any of this turn into something you could use for your platf= orms? > Thanks for pointing this out Leif. One of the main reasons we wrote our ow= n was that we needed to support eMMC and SD, which was missing from the ori= ginal EmbeddedPkg driver. I'd like to use this if possible, but I will nee= d to spend some time reviewing it to make sure it suits our needs. Haojian, please CC me on any followup reviews if possible. Thanks, Chris > / > Leis >=20 > On Fri, Aug 10, 2018 at 04:49:13PM +0800, Haojian Zhuang wrote: > > Changelog: > > v1: > > *Add NonDiscoverableDeviceDxe for embedded platform. Make > DwMmcHcDxe driver > > to support both eMMC and SD controller. > > > > Haojian Zhuang (2): > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > > EmbeddedPkg: add DwMmcHcDxe driver > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec = | > 40 + > > EmbeddedPkg/EmbeddedPkg.dec = | 1 + > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf = | > 69 + > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eDxe.inf | 52 + > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h = | > 815 +++++++ > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h = | > 983 ++++++++ > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h = | 79 + > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eIo.h | 92 + > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > | 214 ++ > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c = | > 1295 +++++++++++ > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c = | > 2366 ++++++++++++++++++++ > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c = | > 1042 +++++++++ > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c = | 1104 > +++++++++ > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > | 124 + > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eDxe.c | 243 ++ > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eIo.c | 972 ++++++++ > > 16 files changed, 9491 insertions(+) > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > > create mode 100644 > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eDx > > e.inf create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > > create mode 100644 > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eIo > > .h create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > > create mode 100644 > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > > create mode 100644 > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eDx > > e.c create mode 100644 > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > eIo > > .c > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > -- > > 2.7.4 > >