From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.72.119; helo=nam05-co1-obe.outbound.protection.outlook.com; envelope-from=christopher.co@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-eopbgr720119.outbound.protection.outlook.com [40.107.72.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D9CCD210D512B for ; Wed, 1 Aug 2018 18:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HkGDyNt9kJafHMpc7VkPZGu6w1ty8BVNdkUnsmITwVs=; b=FCjcglz0rkai/lCTSI6tGeuzb+WHjpu0zijLSxeNIY4+jMOLnh3gOl3HkhpqUVEyms7uWB63kraX5XhWr6TZ4XTMQ0VTYfDjxWSk9LpM9OvgfxGcg93hMaWPu5GGan1XB/eTxEjIfvbCqxtbhXdgWnfEXkZROc3fzvPN4NLTEFQ= Received: from DM5PR2101MB1128.namprd21.prod.outlook.com (52.132.133.20) by DM5PR2101MB0807.namprd21.prod.outlook.com (10.167.110.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.6; Thu, 2 Aug 2018 01:27:16 +0000 Received: from DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::95a8:6c24:9ca4:e80e]) by DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::95a8:6c24:9ca4:e80e%3]) with mapi id 15.20.1038.003; Thu, 2 Aug 2018 01:27:16 +0000 From: Chris Co To: Leif Lindholm , Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Michael D Kinney Thread-Topic: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library Thread-Index: AQHUHXKrAFwrC5JoCEOD88Z1/HY/IKSp5wyAgAAAxACAANRfAIAA81hw Date: Thu, 2 Aug 2018 01:27:16 +0000 Message-ID: References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-4-christopher.co@microsoft.com> <20180731205637.wxvzwq2xnbiaieju@bivouac.eciton.net> <20180801093927.6hja7qgkiwpyvt3m@bivouac.eciton.net> In-Reply-To: <20180801093927.6hja7qgkiwpyvt3m@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=chrco@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-08-02T01:27:14.7515830Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:0:c95d:632a:42fc:503e] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0807; 6:2LUDWtRmVsIFLQLKkMya+fmFVdw9DCNrW+t0qUoS5sipOneczTdkb4EZ/F+9nGtzMShcnIEdwUYp/rd16lo05z2llWKY71JZAAba9+n5pLeQynSSV83eRNxNmZ3/9atCag2kwMRa1JD9Vxp6JaV3KRQnwcXnJfrt7SQjJYhm92jg38fQ7lek0te8lCFPH4XyhsNXwGcIOJDb6OX7L1OJBEvhX9ofDWOjf3YYpC0UcujYJs+VDfbbaiKutLukQPOBe2ovbphn1CyPwSiz79wRDTKkixHXUW5j64CFPO2qLNW9w0hnixqiUo05vILRxoERtPNRtkfCWr96zE1KMcKQ7dJfoT9Tdl4oguWXUaHZUJtzhymEsNOWwX76tZwBsF9Xrmf151cM+g7uTg1xIpZt/6RCQVnYJqZMg0y3ZM8oIZSbJGKJgjGg/1vSlxnhBTsOtRfw3EXa5H69iXfpT5UA+g==; 5:yM2wawVjoJSZr0hBC06e99V9tjhPDVeDxdwiQaMZKJCFF9atGE631/R3n3Lsgh9N1qRWuJMRwI/0l+3pbmCmCVPstqP0/uDtVZKfI4wbSuiThD/CjU2dF7rCYo/BCYaheUXjPjyMME9mzV1Fl3BVjMwlxJZnwbr3gQY6FbLaQ/U=; 7:ktyquOxPx5FtxeZa3fjeol/2+waBueKVYy2hnCkeYXmVMip2jj/6+KnyQTeaxJHKRv+L5zQdLhjJ5F7jeekRwqskC61/mjtvb+T0J4KAMTebGBO+JYiWeQLn320azLbF3rV/QwQL1H0iENcdPHHnd4+8VHQkXHWeE0dWzoI71jUGGsdEUVg7sAgHMzJUCvvzybiMHBTUYFHIkE1S+63XUl7IoTq5ehWhEJw6kdyJpz3ZdW1PBBmjiCjKy0wtx317 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9943783c-0d1b-4374-6310-08d5f8171501 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:DM5PR2101MB0807; x-ms-traffictypediagnostic: DM5PR2101MB0807: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Christopher.Co@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(162533806227266)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(2018427008)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DM5PR2101MB0807; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0807; x-forefront-prvs: 07521929C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39860400002)(366004)(136003)(376002)(346002)(47530400004)(189003)(199004)(13464003)(76176011)(7696005)(229853002)(5660300001)(2900100001)(8936002)(186003)(53546011)(99286004)(6506007)(6246003)(97736004)(256004)(5250100002)(478600001)(10090500001)(8990500004)(446003)(25786009)(11346002)(86362001)(2906002)(86612001)(81156014)(81166006)(110136005)(54906003)(8676002)(33656002)(102836004)(105586002)(55016002)(476003)(68736007)(93886005)(46003)(72206003)(316002)(10290500003)(106356001)(53936002)(4326008)(6436002)(9686003)(6116002)(486006)(74316002)(7736002)(22452003)(305945005)(14454004); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0807; H:DM5PR2101MB1128.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 70pBLQTceEOX1kuaI8THc3li/e0MPmWrj75u+diMXYTdAKaN7GTOprWXF/qpRsVa+LxixrbPeTNvV0KNOLLqBCJacybGLUYr4pMRqXkoZZPUIh7bv3gOS+cV7f/N7Iz2+aIMIxgy3/W78AkTJZUgEaEn/mbTUdouPYJcTdRa2uWWI6XV8P3/urzsd6Vb1lY3k6/tDA6QmjoJoKtnPYbFjo4h3Yv+dp0Enml7K6Mffu+poYIynNaoBSbXPKqs1Zi8BGqnPKgODGyQYuv381cS4STxIv16qjUAvFI9WxLsnvJ4NKOmslTzPOnhQTiJaM2J7SZxbv/FF2QN5M/tvwbyYVH2xq0KNdULsOqUm7veOyU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9943783c-0d1b-4374-6310-08d5f8171501 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2018 01:27:16.2673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0807 Subject: Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 01:27:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Wednesday, August 1, 2018 2:39 AM > To: Ard Biesheuvel > Cc: Chris Co ; edk2-devel@lists.01.org; > Michael D Kinney > Subject: Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add > Lauterbach debug library >=20 > On Tue, Jul 31, 2018 at 10:59:22PM +0200, Ard Biesheuvel wrote: > > On 31 July 2018 at 22:56, Leif Lindholm wrot= e: > > > On Tue, Jul 17, 2018 at 02:05:45AM +0000, Chris Co wrote: > > >> This debug library provides support for importing symbols to debug > > >> using Lauterbach. > > >> > > >> Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib > > > > > > I'm not seeing any difference between this one and the original > > > other than the addition of the Microsoft copyright statement and > > > updating of the debug printouts to modern style. > > > > > > I would be happy to take this as a patch to the original, but I > > > don't see what benefit this copy brings. What prevents you from > > > using the original? > > > > The 'data.load.elf' statement in > > PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach >=20 > Oh, right. >=20 > That (original) code badly needs reformatting. >=20 > Still, if that's the only difference - and in a debug printout, why fork = the > module? >=20 > If there is a way to identify which debugger is being used, use that. > If not, dump all the possible strings. >=20 Currently I didn't find a way to identify the debugger being used. Default= behavior of the original code assumes ARM platforms use DS5 debugger. I c= ould introduce a PCD or compile flag so the developer can indicate DS5 vs L= auterbach debugger and key the debug print off of that. Regarding dumping all possible strings, I am not sure exactly how the DS5 o= utput string is being used. i.e. does the DS5 software receive the serial = info directly? If so, does it expect to see a specific format? Is the sof= tware resilient enough that it can handle the Lauterbach spew on the same c= hannel? > We really don't want a situation where you need to hard-code which > debugger you are using for a specific platform. And even if that is > unavoidable, it needs to live in the main edk2 repository. >=20 Agreed > / > Leif