From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.40.127; helo=nam03-co1-obe.outbound.protection.outlook.com; envelope-from=christopher.co@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0127.outbound.protection.outlook.com [104.47.40.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB57C2117D298 for ; Thu, 1 Nov 2018 18:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FgTHCJXPKh/LBamPewihK97qLpxoZZN4qHe+YR0cmGo=; b=lTOzzp8apxpFbp0JxKPEmG+rq0XmY8OWblew+aFEWQt/mWIl+sEoip0Wx1fss0tkYkPfo8Fm+1eUg0Tl2bVjeNuzySLTMkdg4UcGyqt9GLvSS1Rc1SUXwJehHIorKyHAWp1Ar/XeZ3Fd5gkxZW6+vzib1qlV4ELFftSwesXy7/M= Received: from DM5PR2101MB1128.namprd21.prod.outlook.com (52.132.133.20) by DM5PR2101MB0983.namprd21.prod.outlook.com (52.132.133.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.25; Fri, 2 Nov 2018 01:46:56 +0000 Received: from DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::a5e3:1236:5d97:60a7]) by DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::a5e3:1236:5d97:60a7%6]) with mapi id 15.20.1294.014; Fri, 2 Nov 2018 01:46:56 +0000 From: Chris Co To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Thread-Topic: [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library support for i.MX platforms Thread-Index: AQHUUYS4zw/+/uAlkEKOwFu9Zy/TkaU633CAgAEYGJA= Date: Fri, 2 Nov 2018 01:46:56 +0000 Message-ID: References: <20180921082542.35768-1-christopher.co@microsoft.com> <20180921082542.35768-6-christopher.co@microsoft.com> <20181101085947.m5ncoqydqxvohp6c@bivouac.eciton.net> In-Reply-To: <20181101085947.m5ncoqydqxvohp6c@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=chrco@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-11-02T01:46:54.7723004Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:b:7944:1fd8:5bd5:f0dd] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0983; 6:YsQcQkEfCVCy/0EXO7ukFborZqLkvebtExToHeeyBGWElkka2pAKcB/T0G48Cwt19su6ar4/8wXe/b345n8R6R6zyEtHxnwh4YPcQmUS7SSwQkgsPfEek5/Kme4ol0GNa41+lUYCZmGrKwGks8D3mpYsajYVV1mKQ6ZqWhUrfwQ6bo3HO6k6XBwmx4ZYGySGCpVWwcT/Y+1IHW2nHrZxEMYWqujIY86GLYSZgyqqIY8hTKFkfdCXYBau8pAzKU8lwoCuQz0q60xnfL6VuAGOMM0nrIx/L2S+OmkOKbff5cdvaCc2/ZCu8nLWPN4oeW16gC+rGpRiNNWiUk/GTSraornwAqz/tQinipponQADRoH7/n8eK2xOyKJ+7cuprlgd/5BYJuBFsd0b3YgKB5qAYHsMdf7gdilxkI8LIe2RBw9GhnIg994KVan7zhpvamr8wP6si5Mu1TbUcDB2YkB41g==; 5:w9LM06AJZCUAitVaMsDeCveohl0lLc7MlVrIXrjSfHiDEOS/rRW/zBetWW5edfDRZr2E8bRt5NxFjoE1L0xB9A3v1TbclcU1u53UDdnOfSGoj1kgH360q4Wb5lyV2deXlidSgv0623iXn6GVNVolMpAMV5CI1SJWqkoChFeWyrU=; 7:Ba7YMl6eg3OJCnhXyQHslvApjEPLpOMI+lglKEn2XNZG0iwGqPaigW5F62Hcmd8xi1fUeC67zvK4qj3BgHtl/pVlaG/KLSzmdRZjnegBsU5GhbwjIFHSKAzVdXL/79JkiwSIndHKTjoXNsjJA7hlgw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 16db5f3c-1cfc-484e-4f24-08d640651258 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:DM5PR2101MB0983; x-ms-traffictypediagnostic: DM5PR2101MB0983: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Christopher.Co@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(35073007944872)(28532068793085)(89211679590171)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(8220035)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231382)(944501410)(52105095)(2018427008)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DM5PR2101MB0983; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0983; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(346002)(366004)(136003)(396003)(13464003)(199004)(189003)(316002)(97736004)(478600001)(6436002)(105586002)(53936002)(106356001)(10290500003)(9686003)(72206003)(68736007)(6116002)(86362001)(86612001)(8936002)(14454004)(71200400001)(33656002)(71190400001)(74316002)(11346002)(446003)(8990500004)(486006)(6246003)(6506007)(53546011)(102836004)(476003)(8676002)(305945005)(2900100001)(186003)(76176011)(81166006)(81156014)(7696005)(7736002)(229853002)(54906003)(256004)(2906002)(55016002)(46003)(22452003)(10090500001)(25786009)(5660300001)(4326008)(99286004)(6916009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0983; H:DM5PR2101MB1128.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 2D94fZpAZ2ck5GHM7+6aJVYJNrOgslf2CYVr4PnCPT+URI4f+ScCStVMWKKnVZr2k4uWZ/WZZAzwF73O5v47HKPngFzJ2DEP7aAwxv5/SAhfcfvsHW3uxrEbbj3palO6XA4xpmjdFV7yR4JCZXVPww8EkWJt4vFCn10ZYPMAbIjTzJgij42SxtLowvn2Bc1K4RTGijuni/Xn8XtH8THpMvK1r7tidnYoEqVnt5lZ5aXmd2N+MELIYYCg8VnwI+RSNL+X3fcdowF4IYogcgwcGwNVvHFE1jS3PlN4xXlpzambxqaaWgS97f6gm0J1GHzZGUDOxpGo/houDDRcxb8KCsE9yJozLKmZI1YImKDKEUA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16db5f3c-1cfc-484e-4f24-08d640651258 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2018 01:46:56.1954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0983 Subject: Re: [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library support for i.MX platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 01:46:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, > -----Original Message----- > From: Leif Lindholm > Sent: Thursday, November 1, 2018 2:00 AM > To: Chris Co > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Michael D Kinney > Subject: Re: [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library > support for i.MX platforms >=20 > On Fri, Sep 21, 2018 at 08:25:56AM +0000, Chris Co wrote: > > This adds support for interact with the UART controller on NXP i.MX > > platforms. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Christopher Co > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > --- > > + > > +**/ > > +RETURN_STATUS > > +EFIAPI > > +SerialPortInitialize ( > > + VOID > > + ) > > +{ > > + MX6UART_REGISTERS *UartBase; > > + UINT32 Ucr1; >=20 > ... once we create variables to hold data from those registers, those var= iables > should really be FullyCompliantCamelCase. > But really, something like this could just be "Data" or "Value" or someth= ing > like that. Or if you want a bit more, "ControlRegister". >=20 > Not going to comment on each function, but the pattern repeats throughout > the file. >=20 Noted. I'll change variable names throughout all of the files. Chris