public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables
@ 2018-07-23 12:04 Mark Kettenis
  2018-07-23 22:09 ` Chris Co
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2018-07-23 12:04 UTC (permalink / raw)
  To: edk2-devel

Hi Chris,

I noticed that in the DSDT for this platform, the _DSD for some
devices uses the Device Porperties UUID.  Existing uses of this UUID
on ARM platforms within the edk2 use device properties aligned with
the DeviceTree specification (https://www.devicetree.org/).  The
device properties in this patch clearly are not, even though existing
bindings for the i.MX6 hardware you're targetting exist.

I also noted that the "RegisterBasePA" property duplicates information
provided by _CRS, which is something that the Device Properties UUID
specification explicitly forbids.

Cheers,

Mark



^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH edk2-platforms 0/4] Import Solidrun Hummingboard Edge package
@ 2018-07-22  1:30 Chris Co
  2018-07-22  1:30 ` [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables Chris Co
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Co @ 2018-07-22  1:30 UTC (permalink / raw)
  To: edk2-devel@lists.01.org; +Cc: Leif Lindholm, Michael D Kinney, Ard Biesheuvel

REF: https://github.com/christopherco/edk2-platforms/tree/import_Hmb_v1

This patch set is the last in the overall series of patches to bring up
Windows 10 IoT Core on Solidrun's Hummingboard Edge board running NXP's
i.MX6Q SoC.

Patch Series:
1. import Platform/Microsoft
2. import Silicon/NXP/iMXPlatformPkg
3. import Silicon/NXP/iMX6Pkg
4. import Platform/Solidrun/HummingboardEdge_iMX6Q_2GB

This patch set imports the Hummingboard Edge platform-specific
ACPI tables and board initialization code.

Please let me know if it is preferred to import this series of patches
as one patch set.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christopher Co <christopher.co@microsoft.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Christopher Co (4):
  Platform/Solidrun: Add Hummingboard SmBios
  Platform/Solidrun: Add Hummingboard Peripheral Initialization
  Platform/SolidRun: Add Hummingboard ACPI tables
  Platform/Solidrun: Add Hummingboard dsc and fdf files

 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/AcpiTables.inf                       |   51 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/DSDT.asl                             |   37 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Audio.inc                       |   66 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-AudioCodec.inc                  |   29 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Pwm.inc                         |   30 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Rhp.inc                         |  201 +++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Sdhc.inc                        |  436 +++++++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Spi.inc                         |   42 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Uart.inc                        |  197 +++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Usb.inc                         |  410 +++++++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c   |  801 ++++++++++++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf |   54 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/HummingboardEdge_iMX6Q_2GB.dsc                  |   74 ++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/HummingboardEdge_iMX6Q_2GB.fdf                  |   13 +
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardInit.c            | 1295 ++++++++++++++++++++
 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardLib.inf           |   96 ++
 16 files changed, 3832 insertions(+)
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/AcpiTables.inf
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/DSDT.asl
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Audio.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-AudioCodec.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Pwm.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Rhp.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Sdhc.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Spi.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Uart.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/AcpiTables/Dsdt-Usb.inc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/HummingboardEdge_iMX6Q_2GB.dsc
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/HummingboardEdge_iMX6Q_2GB.fdf
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardInit.c
 create mode 100644 Platform/SolidRun/HummingboardEdge_iMX6Q_2GB/Library/iMX6BoardLib/iMX6BoardLib.inf

-- 
2.16.2.gvfs.1.33.gf5370f1



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-23 22:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-23 12:04 [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables Mark Kettenis
2018-07-23 22:09 ` Chris Co
  -- strict thread matches above, loose matches on Subject: below --
2018-07-22  1:30 [PATCH edk2-platforms 0/4] Import Solidrun Hummingboard Edge package Chris Co
2018-07-22  1:30 ` [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables Chris Co

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox