Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver

[Chris Co <Christopher.Co@microsoft.com>]

Hi Leif,

> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Tuesday, July 31, 2018 1:33 PM
> To: Chris Co <Christopher.Co@microsoft.com>
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc
> Dxe Driver
> 
> Hi Chris,
> 
> On Tue, Jul 17, 2018 at 02:05:42AM +0000, Chris Co wrote:
> > This SdMmc driver adds support to boot Windows from SD and eMMC.
> > It implements RPMB protocol support for eMMC, unique device path
> > creation for each slot on the SD bus, high speed modes, eMMC bus width
> > auto-detection, and support for high capacity SDXC cards.
> >
> > Derived from: EmbeddedPkg\Universal\MmcDxe
> 
> Hmm, I'm already slightly unhappy that we have duplication between
> EmbeddedPkg and MdeModulePkg (not to mention the extra fork for
> Marvell's XenonDxe).
> 
> I'm obviously keen for the added functionality to be available to more
> platforms. Is there any way for this support to be added into either the
> EmbeddedPkg or the MdeModulePkg driver?
> 

Understood - from talking with the other developers, we duplicated since we didn't know if these changes would be desired in edk2 core.  As part of the review, do let me know if changes would be better placed in edk2 core instead of platform.  I will be happy to refactor and submit patches to edk2 core.

Chris

> (Deferring comments on specific content.)
> 
> /
>     Leif
>