From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe51::715; helo=nam05-dm3-obe.outbound.protection.outlook.com; envelope-from=christopher.co@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-dm3nam05on0715.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe51::715]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9899B2097E27C for ; Wed, 1 Aug 2018 17:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PafzAFPZXd2YEYtOj1+66V1BwCNky9jI0p9PBrTeuTk=; b=Llm2GmEEVw95osyS5npccynCgWWH7PO9im5qLwPVHgbcKUTNC5IhulpdZ8c0904x0HIx+KUqFc0t4eK08AaWArKSIzx4X7wj99XCksT6qKoSx7GE6nX1MYxMMV4EDFqKcy/Azo33/HYj8hWpXjrvMx6TuFr5qLSEMYn2E/q/dbE= Received: from DM5PR2101MB1128.namprd21.prod.outlook.com (52.132.133.20) by DM5PR2101MB1080.namprd21.prod.outlook.com (52.132.130.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.7; Thu, 2 Aug 2018 00:05:39 +0000 Received: from DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::95a8:6c24:9ca4:e80e]) by DM5PR2101MB1128.namprd21.prod.outlook.com ([fe80::95a8:6c24:9ca4:e80e%3]) with mapi id 15.20.1038.003; Thu, 2 Aug 2018 00:05:39 +0000 From: Chris Co To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Thread-Topic: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver Thread-Index: AQHUHXKql0LJjOelxkSqfeJnGz+ao6Sp4ISAgAHMBpA= Date: Thu, 2 Aug 2018 00:05:38 +0000 Message-ID: References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-2-christopher.co@microsoft.com> <20180731203315.a334nudun6qu43ds@bivouac.eciton.net> In-Reply-To: <20180731203315.a334nudun6qu43ds@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=chrco@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-08-02T00:05:36.1292277Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:0:c95d:632a:42fc:503e] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1080; 6:MEqdM1FMgr8wb4L0wJNdzSUuQTgLU1sPwomcXHOYUwQ0K5ym3zUzLSe4EvRjZ5MGC46iS6Rsb4g4AS5qNTiUb9cerRKmKz+dVFFO95a10KP96ds46Qpf1oxzxpIoEgE7icVEOuBQ8NvX2JA8eHiUdpWBnWjEw6F2K/SBAlSZQ9po/QbmPsLXHdDwVq9Fysbl6y0zOlhDeWIyTDYQSWDzuQu7IkWpJ/2IsglGe2ZqW8jj9sK3fqMEOKtd1A46MSfKVA4OPllaeRYHT4MAwBtQ6MQ/pkK1bX+NtyKVRpNSNBIMMi/z7Z2NWgMiDDqfzYiYeQFNBGxNB325/OfEE8xEeNKhGdTAYK3908Td9Jf3LSwbi03YpUZemvKB5i9m84VdYIirZ9KaJSvXegV1f62IFd/F0gJlNCrWJCWSsXlYSZMZb7PD+KMyvz6fGBKjp6faXaZcbgdpQpYrAVMwdCVD7A==; 5:YStbH6B+vgeINFg75v16pLfkmovfWgeIVHl6/MHycUxxNs9+lJJell1/qtc5RiMgvJcpeo6b4zu1J414FxYrOsQbOJ6TM/TmpvA+/lOS+eQ7XQAykNXfP7aDvAMPkQFeoH7nWda2mPrZKVFPkpiryEMvgLp225hP1MWCYFiyL+Q=; 7:IAMyZ7gQCHz+quLKIupdr5s1NDZuBtfRK7MYDtpls0BSvcErDuKJU/wefRrUkWipLi+qbpRErUs2WjPLS32w/Gq7U2brvGazJ5p3+ErtvOyGiEiJla3tsnKrgHeIjdzoZIpJ1y1AfljWQ4AHuFuwRRzMlXW3vGPJcC8uEYa/iusS4zofbyY8dDKp31R5BvZ0YBpm/OsmSVM62sTCVOZ1r0gOfHPW+uk/RdHg0Jz7K9TOohmfjjLUXodWDkRQ3y61 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 227bf4ee-1cb0-445b-9e9e-08d5f80badff x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7193020); SRVR:DM5PR2101MB1080; x-ms-traffictypediagnostic: DM5PR2101MB1080: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Christopher.Co@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(162533806227266)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231311)(944501410)(52105095)(2018427008)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DM5PR2101MB1080; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1080; x-forefront-prvs: 07521929C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6029001)(136003)(39860400002)(366004)(376002)(396003)(346002)(47530400004)(13464003)(199004)(189003)(14454004)(5660300001)(5250100002)(478600001)(102836004)(68736007)(10290500003)(106356001)(46003)(6436002)(105586002)(2906002)(6916009)(97736004)(9686003)(8990500004)(72206003)(74316002)(229853002)(186003)(54906003)(446003)(2900100001)(55016002)(33656002)(11346002)(256004)(7696005)(53546011)(10090500001)(316002)(8676002)(86362001)(22452003)(6506007)(6116002)(8936002)(99286004)(76176011)(476003)(25786009)(6246003)(53936002)(86612001)(7736002)(4326008)(305945005)(486006)(81166006)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1080; H:DM5PR2101MB1128.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: LO6wwKD+N+ALQQgHNDaIXRU9tCoM8bDaHFT3Rkq1l+tMjkzFwYZjkcwksg4Ye2NLOAnH2P0T5mcKIMdAaC7mWPwwTgF+Yzg+R+WmRvRa/ow7PIbioQMiJcq6TFbB//ec+9NYeDBQ+A+4p9+yykkZkdJMZ6Ub3uHK6mDs7Ka3nimZpt8X43JLBwVZq4JZTnjGKvODSrzEGUnVEGGQn6jh37C9jzx63ZfTgtzl72pEowls/3AyDpWL9LLlC7Oo5mNoSq6qJPbH+tacPA54HPDSNpxb0Xgs/drv9gzIuVOsdS91b7dVktwkCKZAoGdoquK7fZQxjgqw1Zw3azPD0yXVu9j8LdxFzGNKNYs+BKFI6tE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 227bf4ee-1cb0-445b-9e9e-08d5f80badff X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2018 00:05:38.8613 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1080 Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 00:05:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, July 31, 2018 1:33 PM > To: Chris Co > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Michael D Kinney > Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc > Dxe Driver >=20 > Hi Chris, >=20 > On Tue, Jul 17, 2018 at 02:05:42AM +0000, Chris Co wrote: > > This SdMmc driver adds support to boot Windows from SD and eMMC. > > It implements RPMB protocol support for eMMC, unique device path > > creation for each slot on the SD bus, high speed modes, eMMC bus width > > auto-detection, and support for high capacity SDXC cards. > > > > Derived from: EmbeddedPkg\Universal\MmcDxe >=20 > Hmm, I'm already slightly unhappy that we have duplication between > EmbeddedPkg and MdeModulePkg (not to mention the extra fork for > Marvell's XenonDxe). >=20 > I'm obviously keen for the added functionality to be available to more > platforms. Is there any way for this support to be added into either the > EmbeddedPkg or the MdeModulePkg driver? >=20 Understood - from talking with the other developers, we duplicated since we= didn't know if these changes would be desired in edk2 core. As part of th= e review, do let me know if changes would be better placed in edk2 core ins= tead of platform. I will be happy to refactor and submit patches to edk2 c= ore. Chris > (Deferring comments on specific content.) >=20 > / > Leif >=20