public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Sean Brogan <sean.brogan@microsoft.com>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: Edk2 uni file encoding
Date: Thu, 8 Nov 2018 07:10:32 +0000	[thread overview]
Message-ID: <DM5PR21MB01855E70A574C80913000743E1C50@DM5PR21MB0185.namprd21.prod.outlook.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E366631@SHSMSX104.ccr.corp.intel.com>

Liming,
That was exactly what I was looking for.  

Thanks
Sean




-----Original Message-----
From: Gao, Liming <liming.gao@intel.com> 
Sent: Wednesday, November 7, 2018 10:01 PM
To: Sean Brogan <sean.brogan@microsoft.com>
Cc: edk2-devel@lists.01.org
Subject: RE: Edk2 uni file encoding

Sean:
  EDKII UNI spec (https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Specifications&amp;data=02%7C01%7Csean.brogan%40microsoft.com%7C5ffeb105737e4c00150208d6453fa46a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636772536983024335&amp;sdata=veov60rbEtr3ub7RcreuFuqJvc4%2BdtAowph7kBGXW54%3D&amp;reserved=0) Chapter 2 defines UNI file format. EdkCompatibilityPkg is obsolete. BZ https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D1103&amp;data=02%7C01%7Csean.brogan%40microsoft.com%7C5ffeb105737e4c00150208d6453fa46a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636772536983024335&amp;sdata=LOLezJzuK9kwu8QK78UM5nnCD%2FZEY5fxr1VQzk8sqY8%3D&amp;reserved=0 is submitted to delete EdkCompatibilityPkg from edk2/master. We will work on it. 

EDK II Unicode files are used for mapping token names to localized strings that are identified by an RFC4646 language code. The format for storing EDK II Unicode files on disk is UTF-8 (without a BOM character) or UTF-16LE (with a BOM character). The character content must be UCS-2.

Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
>Sean Brogan via edk2-devel
>Sent: Thursday, November 08, 2018 7:00 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] Edk2 uni file encoding
>
>Is there a definitive answer for the file encoding for all UNI files in edk2?
>If not I would like to propose one.  Incorrect encoding causes tool 
>issues and is something we can easily check for and fix.
>
>Proposal: All UNI files in edk2 should be
>
>
>  1.  UTF-8
>Or
>
>  1.  Use a BOM and be UTF-16
>
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wik
>ipedia.org%2Fwiki%2FByte_order_mark&amp;data=02%7C01%7Csean.brogan%40mi
>crosoft.com%7C5ffeb105737e4c00150208d6453fa46a%7C72f988bf86f141af91ab2d
>7cd011db47%7C1%7C0%7C636772536983024335&amp;sdata=1IET4LN5l9FfMscffzgk0
>t7IqYGyYNU9IrZafvi9osU%3D&amp;reserved=0
>
>Results from searching edk2:
>1 - UTF-16 LE BOM file:
>EdkCompatibilityPkg\Compatibility\FrameworkHiiOnUefiHiiThunk\Strings.un
>i
>919 - Without BOM and decoded as UTF-8
>
>Thoughts?
>
>Future question:  Can we make rule for all other standard file types 
>(c, h, dec, dsc, fdf, inf,)?
>
>Thanks
>Sean
>
>
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
>01.org%2Fmailman%2Flistinfo%2Fedk2-devel&amp;data=02%7C01%7Csean.brogan
>%40microsoft.com%7C5ffeb105737e4c00150208d6453fa46a%7C72f988bf86f141af9
>1ab2d7cd011db47%7C1%7C0%7C636772536983024335&amp;sdata=HhfPaCyS0sKHu1fF
>Gkfh%2FQ4pm34X68YKiaM6IN7%2Fzj0%3D&amp;reserved=0


  reply	other threads:[~2018-11-08  7:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 23:00 Edk2 uni file encoding Sean Brogan
2018-11-08  6:00 ` Gao, Liming
2018-11-08  7:10   ` Sean Brogan [this message]
2018-11-08 16:46     ` Kinney, Michael D
2018-11-08 16:55       ` Oram, Isaac W
2018-11-08 13:38 ` Laszlo Ersek
2018-11-08 16:42 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR21MB01855E70A574C80913000743E1C50@DM5PR21MB0185.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox