public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Giri Mudusuru via groups.io" <GIRIMUDUSURU=microsoft.com@groups.io>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ellie.lewis@arm.com" <ellie.lewis@arm.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>,
	Giri Mudusuru <girimudusuru@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/SmbiosView: Add Type 45 entry to query table
Date: Tue, 23 Apr 2024 15:54:47 +0000	[thread overview]
Message-ID: <DM5PR21MB17526653C8829142B3FDFE18DC112@DM5PR21MB1752.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20240423105155.19829-2-ellie.lewis@arm.com>

[-- Attachment #1: Type: text/plain, Size: 2991 bytes --]

Reviewed-By: Giri Mudusuru <girimudusuru@microsoft.com>
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ellie Lewis via groups.io <ellie.lewis=arm.com@groups.io>
Sent: Tuesday, April 23, 2024 3:51 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] ShellPkg/SmbiosView: Add Type 45 entry to query table

[You don't often get email from ellie.lewis=arm.com@groups.io. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

The type field value is currently undefined for type 45 SMBIOS tables
in smbiosview. An entry is added in the query table to display the
correct value for type 45 tables.
Bugzilla: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D4733&data=05%7C02%7CGIRIMUDUSURU%40microsoft.com%7Cffd3eb0d33e4454bda3108dc63a5c7b7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638494810879613185%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=TKB1DcLEXngmx12y8vaLsPLZPkm9uL%2Be51Ui%2FI8rwrg%3D&reserved=0<https://bugzilla.tianocore.org/show_bug.cgi?id=4733>

Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Ellie Lewis <ellie.lewis@arm.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 36f8739d6c87..d786b14f3877 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -5,6 +5,7 @@
   Copyright (c) 2005 - 2024, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR>
   Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+  Copyright (c) 2024, Arm Limited. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/
@@ -3918,6 +3919,10 @@ TABLE_ITEM  StructureTypeInfoTable[] = {
     44,
     L" Processor Additional Information"
   },
+  {
+    45,
+    L" Firmware Inventory Information"
+  },
   {
     0x7E,
     L" Inactive"
--
2.25.1

\x01«¢êlS'âzK\x18¢êÞqè¯y©e(tm)ë,j\a¬±éí¶<aSÈ+¢êU?ì?EêeÈéåSwµ×Ízö^[m¦ÏÿyÙ6'º.¦È¨þ\x0fÝz÷¥þg¬±¨\x1eÿ]|ׯLº×"?+\x13¢~oe?Ûi³ÿà®<©²*?sßõÓz½ÓÞ|ÿÎ9ã]ô\x1aº.¤ì'z·^½é~£ Þ­çdÚ
èº>"¡Iì¹»\x1c®&Þ?Ûi³ÿÞvM ®<©²*?f÷^½é\x7fº{.lb\x11 Å\x03Q%\x11Rhoe®<(~×(


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118242): https://edk2.groups.io/g/devel/message/118242
Mute This Topic: https://groups.io/mt/105690958/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4802 bytes --]

  reply	other threads:[~2024-04-25  0:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 10:51 [edk2-devel] [PATCH v1 0/1] ShellPkg/SmbiosView: Add Type 45 entry to query table Ellie Lewis
2024-04-23 10:51 ` [edk2-devel] [PATCH v1 1/1] " Ellie Lewis
2024-04-23 15:54   ` Giri Mudusuru via groups.io [this message]
2024-04-24  0:52     ` Gao, Zhichao
  -- strict thread matches above, loose matches on Subject: below --
2024-04-23  9:34 [edk2-devel] [PATCH v1 0/1] " Ellie Lewis
2024-04-23  9:34 ` [edk2-devel] [PATCH v1 1/1] " Ellie Lewis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR21MB17526653C8829142B3FDFE18DC112@DM5PR21MB1752.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox