[edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error

[edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

Declare InternalAssertJumpBuffer as EXTERN

Signed-off-by: "Liu, Shun Cheng" <aliu@synaptics.com>
---
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
index 6ec8f35f2c..397593ceaf 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
@@ -4,6 +4,7 @@
; SPDX-License-Identifier: BSD-2-Clause-Patent
;
;------------------------------------------------------------------------------
+  EXTERN InternalAssertJumpBuffer
   EXPORT SetJump
   EXPORT InternalLongJump
--
2.22.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114795): https://edk2.groups.io/g/devel/message/114795
Mute This Topic: https://groups.io/mt/104056947/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5599 bytes --]

[edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

Declare InternalAssertJumpBuffer as EXTERN

Signed-off-by: "Liu, Shun Cheng" <aliu@synaptics.com<mailto:aliu@synaptics.com>>
---
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
index 6ec8f35f2c..397593ceaf 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
@@ -4,6 +4,7 @@
; SPDX-License-Identifier: BSD-2-Clause-Patent
;
;------------------------------------------------------------------------------
+  EXTERN InternalAssertJumpBuffer

   EXPORT SetJump
   EXPORT InternalLongJump
--
2.22.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115169): https://edk2.groups.io/g/devel/message/115169
Mute This Topic: https://groups.io/mt/104198930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5789 bytes --]

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error

[Laszlo Ersek]

On 2/6/24 07:11, Adam Liu wrote:
> Declare InternalAssertJumpBuffer as EXTERN

CC'ing maintainers per Maintainers.txt.

Other than that -- the patch seems to be HTML mail; did you send it with
git-send-email?

Laszlo


> 
>  
> 
> Signed-off-by: "Liu, Shun Cheng" <aliu@synaptics.com
> <mailto:aliu@synaptics.com>>
> 
> ---
> 
> MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
> 
> 1 file changed, 1 insertion(+)
> 
>  
> 
> diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> 
> index 6ec8f35f2c..397593ceaf 100644
> 
> --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> 
> +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> 
> @@ -4,6 +4,7 @@
> 
> ; SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> ;
> 
> ;------------------------------------------------------------------------------
> 
> +  EXTERN InternalAssertJumpBuffer
> 
>  
> 
>    EXPORT SetJump
> 
>    EXPORT InternalLongJump
> 
> --
> 
> 2.22.0.windows.1
> 
>  
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115255): https://edk2.groups.io/g/devel/message/115255
Mute This Topic: https://groups.io/mt/104198930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error

[Adam Liu]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hello Laszlo,

No, I sent the content with outlook. Do I need to send out patch again with git-send-email?

Adam


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115502): https://edk2.groups.io/g/devel/message/115502
Mute This Topic: https://groups.io/mt/104198930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 918 bytes --]

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Fix AARCH64 compilation error

[Laszlo Ersek]

On 2/15/24 10:02, Adam Liu wrote:
> Hello Laszlo,
> 
> No, I sent the content with outlook. Do I need to send out patch again
> with git-send-email? 

Please find the official contribution guide here:

  https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Some personal (unofficial) tips on top:

  https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115503): https://edk2.groups.io/g/devel/message/115503
Mute This Topic: https://groups.io/mt/104198930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-