From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.62]) by mx.groups.io with SMTP id smtpd.web08.4534.1607509463655605876 for ; Wed, 09 Dec 2020 02:24:24 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=Xsh5xoJY; spf=pass (domain: outlook.com, ip: 40.92.41.62, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z3OA9u6fhVikMKc7gDn1NbWaSysICKorAgEWZO3zsvXDsu6JoF9tHe+t5QUpUKGfTnUL5rI8pcyPVLkNeCbJGT9CEnwpznI1aUIcsaArHa2ah0NlJET1KFfa5kurkDcr6keEErlFm+PCz1Hg3Ocbwc2XEKZ8Lh19nDvk/vKYzytvaTQyo0M/RMRsN5+aDbz9ZVqa72Km7mYEqq3G3YlOyczspy9w6ALXfxN4ozvVw5Qln1J9R1uUOGI9KHObQY0ziXLg+Lc133XhWhU/Bm66mX53STBiLRc8t3DW7yV+828mPe34pdSrela4NdRRGgIsXkykjXCMpJoio6T50VuXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E4pjqYcn191rfbEfZQw2oUlc3cOLHkt1l9tE6zMMVO8=; b=BiOyMh36GzmV6Mywybr8eGbExskmCedVgeySaDjxlR3QRKevIHsdvrNB2uSJEcQOtPGtZeXUCoHnuH/IlnPqgy9kqF/QM9nomTKTFtKNGWwhUxfEST4YFHjuCWsPeKtpn9A5/bYoR57HopvlZuQ2+69dg3vT7QvEh1LAjZL1N8wNPwGFswE88iBUcH4bZ/iXjd3Qhz3kS9ePOS4Bowkl4++Dv1UUr7ow6BfJrs9tT30UfJTjj7m6LJ+MQMr0Sh3FKAkk4cDF7bC7V+kuyDnJsRsFxA6tFqynQERwfrUYD0DgcZYFDmqadAJXJgHskdkhWcH+aCxR69UgsrtlMcB4ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E4pjqYcn191rfbEfZQw2oUlc3cOLHkt1l9tE6zMMVO8=; b=Xsh5xoJYH3wud3Cq84rPqKoKuV/41Eqq9kt3twkT2krhC2K2gVVFT6JeF8KtRzM6efVT3pLdM/N2bh1U2Cpr6AkQbDZWxI4+IByQco2izk+xm9EZiCJ1FaoundFep2m94O+rIzwnVnXYZqjuESG7qHtZz4SPv0qLO+D4SV5Hv7aVdT4cE4EzoFqE0CsB91pUY0WwSSUAIb4wJuqtasVbh1swDktk6Bvigdbb2NoKBnOuG7kcV5V99TrITwswT+aCkmKoRqHxsVhlcE4VKqaoSiiLtqRug3El4c6SNiQ0RhDEGS5+tJ8O/rFixp4U4Y/TIAKNit7Nm5e8mwEDUmONHg== Received: from DM6NAM10FT019.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::4f) by DM6NAM10HT098.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::264) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.20; Wed, 9 Dec 2020 10:24:22 +0000 Received: from DM6PR07MB7180.namprd07.prod.outlook.com (2a01:111:e400:7e86::42) by DM6NAM10FT019.mail.protection.outlook.com (2a01:111:e400:7e86::96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 10:24:22 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:9749B5F6E351B2932B8178B1CB8E93FDF47BB86631E8EDE9D64EBC38D1568D84;UpperCasedChecksum:7BB59364271C7E8288EED965A9206D53D42A6988B2DEA41A28F2A87F9BD77B53;SizeAsReceived:9081;Count:48 Received: from DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0]) by DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0%9]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 10:24:22 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIHBsZWFzZSBsZXQncyBkaXNhYmxlIHRoZSBFQ0MgcGx1Z2luIGluIENJLCBpbiBpdHMgY3VycmVudCBmb3Jt?= From: "Sean" To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, lersek@redhat.com, 'Michael Kinney' , 'Sean Brogan' , "'Ard Biesheuvel (ARM address)'" , "'Leif Lindholm (Nuvia address)'" , 'Andrew Fish' Reply-To: devel@edk2.groups.io, spbrogan@outlook.com References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com> <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn> <164ED1ABFE90B1B0.9298@groups.io> Message-ID: Date: Wed, 9 Dec 2020 02:24:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <164ED1ABFE90B1B0.9298@groups.io> X-TMN: [+Yu1yYavGCO1zj5hrVnkyEsJLhTB2LYF] X-ClientProxiedBy: CO2PR04CA0132.namprd04.prod.outlook.com (2603:10b6:104:7::34) To DM6PR07MB7180.namprd07.prod.outlook.com (2603:10b6:5:1e1::15) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <4510bc01-9642-a398-4117-d7268ebbf491@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by CO2PR04CA0132.namprd04.prod.outlook.com (2603:10b6:104:7::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 9 Dec 2020 10:24:21 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 6c0f6a0e-2e8f-415b-7848-08d89c2c9879 X-MS-TrafficTypeDiagnostic: DM6NAM10HT098: X-MS-Exchange-MinimumUrlDomainAge: groups.io#3684 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZzgHYP2Llb0LPq1Pw9iAv73AdBdx8PQLIbkkxgb3uhAyjpGhJNP/V/+vccYv0uLRQlmCIInfc4EdzD8HHfZwRRte6TAxZErWOaw+fpBEfTnNr17zYfwC46GQL9uIo5lZqZL59LCXpMdi6c7JPX4OfAbfsbDrxo/nZdO1M230gqGGF6torKce4d1wMUBPLxkcnevgLtEN+uGKMj49zW9m+GvnUQyPbEbKz/evJHmi+QSQBxGbP2UmbhsdDyNLpvDn X-MS-Exchange-AntiSpam-MessageData: BmVmi2qAkBNs7NWnYyqSWu9ZcWn3ZW6L8K3LvV18pzI91UiqahX9QIWiOPMA97UZOvspQr3uROH17L3ebXF5tO58w20GivKH2h5ipN2WUkHhIvqry+2r7PZpxsJXgoxvyLNJ4oqKTO99w68osDANvA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2020 10:24:22.3118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 6c0f6a0e-2e8f-415b-7848-08d89c2c9879 X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT019.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT098 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Laszlo, Two options provided here for disabling EccCheck. See commits in PR https://github.com/tianocore/edk2/pull/1201 Thanks Sean On 12/8/2020 10:37 AM, Sean wrote: > Liming >=20 > I agree it would be great to get to a place where a package maintainer= =20 > could turn this on but because of this bug=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2986 I think this needs= = =20 > to be completely disabled until the above is resolved. >=20 > Thanks > Sean >=20 >=20 > On 12/8/2020 7:38 AM, gaoliming wrote: >> Laszlo: >> =C2=A0=C2=A0 ECC tool is not perfect. It is still helpful. I am OK to d= isable=20 >> ECC plugin in CI. But, I request to expose the option to enable it per= =20 >> package. If the package maintainer thinks ECC is valuable, he can=20 >> enable ECC plugin in one package. As MdePkg maintainer, I can help to= =20 >> resolve ECC issue in MdePkg patch. So, I would keep ECC plugin in MdePk= g. >> >> Thanks >> Liming >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68414+4905953+8761045@groups= .io >>> =E4=BB=A3=E8=A1=A8 Lasz= lo Ersek >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=888=E6=97= =A5 10:05 >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kinney ; Sean Brogan >>> ; Ard Biesheuvel (ARM address) >>> ; Leif Lindholm (Nuvia address) >>> ; Andrew Fish >>> =E6=8A=84=E9=80=81: edk2-devel-groups-io >>> =E4=B8=BB=E9=A2=98: [edk2-devel] please let's disable the ECC plugin i= n CI, in its=20 >>> current form >>> >>> Hi All, >>> >>> in my opinion, the ECC plugin in CI has not been productive or helpful= . >>> The errors it reports are not convincing, and exceptions are difficult >>> to add, or even express. I request that we disable ECC globally for >>> edk2, or at least make it controllable through a github PR flag (not >>> through CI metafile changes in edk2). >>> >>> (Metafile changes could be an acceptable way of controlling ECC if (a) >>> they didn't have to go through review, (b) if technically such changes >>> would take effect in CI even if they were included in the patch series >>> subject to the CI run. Then a maintainer could evaluate and >>> *immediately* suppress such ECC issues by adding the exceptions as a >>> prepended patch, and force-pushing the updated branch to the same open >>> PR. But this would remain much inferior to simply disabling ECC, or >>> controlling it through a PR label.) >>> >>> Thanks >>> Laszlo >>> >>> >>> >>> >>> >> >> >> >> >> >> >> >> >=20 >=20 >=20 >=20 >=20