From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.92.47.41]) by mx.groups.io with SMTP id smtpd.web09.14211.1607453139273779643 for ; Tue, 08 Dec 2020 10:45:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=g8wBY8BM; spf=pass (domain: outlook.com, ip: 40.92.47.41, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEthXSEdN2tOsGyt7sXR9J+UZUTV7SytbX8NrWWq16LQ8wGm0QbRXr7l5w9VRtK4vLQJZjcGBv6gGJ+Ru69KgOyT57f4v/z/H5EFVflpg5/epp8nc6tukd4OY47CAgQl+PHFqiNcdaQVxrV1Ba/Rmyw0l18U8HvpVFxu77PKCHh+wZToXFkk6AJxC+CcB1fW6elTfMbVOUrovzGDijJ3U7oxXWCgyTlwTQLSF+r79IaweWBLOAX+bMS1U5PdTIFmuUKnVggiCd92Ok6MU+sLqF4lokXn1YcmllACxpCYhL2RRUJUuIL7PGweHYZI49Axq/fVSKyGcqUrjLva9+B9oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cV+EBUORPwjaMgvTmxUsRohI++ds18Ov3MbQ1kmGnks=; b=jBBSqQ7JD2JgUFHcp0uTOq3FRDNfJV4pqvUEqAjXVIT7Pgg1MHmmsGgG2K+1OqWKOp1jzBRwwr3GLwIgazN2dKb0rMPG1COOJJMLDmhhE6nBHK//X1aGOp0UOaeHCfKc4mdfGwk/W54v+fBGw/D/PMVuOZYV3Y+Kbw79kyJrpl5uuxNdDks/inWRNVceioScjsff5ftNhgbTYCJyhTRTaoBzzFbcVlitRzMb55r0Gz1l5qkYPxd8jzxeEtJGOMYdyk4ALdAvaUknkL8JsV9zDXb2utAfV43OJzBwQSQiFPdAQRhNTDZk+duHvgyNLc9zAl84WFoRHAALm5029KADeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cV+EBUORPwjaMgvTmxUsRohI++ds18Ov3MbQ1kmGnks=; b=g8wBY8BMaZS3j+1E8SSazHpG/2aUn+pBMM9eoqosRGFn83QctaY1gfxCgBR7VY8i4jqyOSGiZvIIThwcLD88oEpsTIDPm+6Lr5ogbbvwkjY/RsLFQVHwEV2wR9NIKc3g6bhF2dsJUP2aecQjvktkz/4Y0u8ey4hofJxkOXRioHpBsrlL7XVo7RAqJKSlJiSsbZqmuPybZZPFUFgfocfPwXm5hvRGfy/M3EeK4ejtsw3Hwkwlr/r2BmYJ5ASUfebYR2nbZSDqkxmTfQsgL7OxfkQDtX3eYHqrmyinA5FRR3x6n1oFQcFjTZyrejNPwu/is+4BjKUNYOTQdAcfVcmrQg== Received: from CO1NAM04FT036.eop-NAM04.prod.protection.outlook.com (10.152.90.55) by CO1NAM04HT195.eop-NAM04.prod.protection.outlook.com (10.152.90.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Tue, 8 Dec 2020 18:45:37 +0000 Received: from DM6PR07MB7180.namprd07.prod.outlook.com (2a01:111:e400:7e4d::4b) by CO1NAM04FT036.mail.protection.outlook.com (2a01:111:e400:7e4d::402) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21 via Frontend Transport; Tue, 8 Dec 2020 18:45:37 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:88137D371E56706A51D98DE24B7783F58B365B997A264F312BB1ADE6BA73EE94;UpperCasedChecksum:5DF6FDB63B0172A4885369461E8F98E5A7820E6E2D3329F7F4BBE2215215A6E0;SizeAsReceived:9277;Count:48 Received: from DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0]) by DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0%9]) with mapi id 15.20.3654.012; Tue, 8 Dec 2020 18:45:37 +0000 Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg: start using the ECC plugin exception list To: Laszlo Ersek , Ard Biesheuvel , devel@edk2.groups.io, James Bottomley Cc: Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Tom Lendacky , "Leif Lindholm (Nuvia address)" References: <20201204032116.31321-1-lersek@redhat.com> <20201204032116.31321-2-lersek@redhat.com> <7c57b6dc-de1a-8f2b-9b40-c1faf9b46bfe@redhat.com> <6989494d-4dca-6a92-d748-9c413206e781@arm.com> <3b931320-5afb-0dae-e8d2-f2e56be88177@redhat.com> From: "Sean" Message-ID: Date: Tue, 8 Dec 2020 10:45:35 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <3b931320-5afb-0dae-e8d2-f2e56be88177@redhat.com> X-TMN: [fyc0JaPsKg84Q8JtqsWFzqKUBY6owo9I] X-ClientProxiedBy: MWHPR13CA0037.namprd13.prod.outlook.com (2603:10b6:300:95::23) To DM6PR07MB7180.namprd07.prod.outlook.com (2603:10b6:5:1e1::15) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <76bd91ca-1a27-2497-df1e-fb6125de05c3@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR13CA0037.namprd13.prod.outlook.com (2603:10b6:300:95::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.5 via Frontend Transport; Tue, 8 Dec 2020 18:45:36 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: f60dca7b-4639-4f3d-0fb3-08d89ba97442 X-MS-TrafficTypeDiagnostic: CO1NAM04HT195: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U1Qf2nghRS/j2jSen85HeJ5Zo/7b3bFglSO3h4vogedmwCeE/tvR/7+Azo9Fuik+CTs6kzJgTXjICfPnr2cyROviEKXRV7R9HpHjb4/TbDxJTNvs6d8K8u2nTT950MeuTPjMovkDdzajrvCz6aAxLZyP3RB/2I3lf5Sa0LmezUANQuwpjlS+s+QSrTscm89fCr21LPPUdrJjE+z2e86IaA== X-MS-Exchange-AntiSpam-MessageData: K/huSiBdwaPAMe2wLpuHMEK0LmqoaJsTMDX1MHXRKbTyZAJDBlYsWpBb0mqAys+mGKBk1MLoH/qhLkExvXPHo0HcxHzgxj5RFdzIOnZfkYDe5PK4kfKR9I3iqG+Fzq8FJqGINg6CnXWSymF5a9Djww== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2020 18:45:37.4687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: f60dca7b-4639-4f3d-0fb3-08d89ba97442 X-MS-Exchange-CrossTenant-AuthSource: CO1NAM04FT036.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM04HT195 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Laszlo, Trying to understand this. On 12/7/2020 5:56 PM, Laszlo Ersek wrote: > ... I would still much prefer of course if that patch (= the exception > to GuidCheck) could simply be included in James's series. The PR based CI runs on the entire series. It does not run on individual commits and thus you can add this to the series and in fact i would suggest it get added to the series. Any changes in the series will take effect when running the CI. This is great for how Project Mu uses "PR gates" because we squash merge but in Edk2 with a patch series this can mean that commits in the middle can break things. It is on developer and reviewer to catch those types of things. For this case why can't this change be part of the commit that introduces the guid/global? Or if that is undesirable you should be able to add the ignore in a commit prior to introduction and then you would never have a break. Either way there is no reason this isn't part of a single series. Thanks Sean