From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, leif@nuviainc.com, gaoliming@byosoft.com.cn
Cc: rebecca@nuviainc.com,
'Michael D Kinney' <michael.d.kinney@intel.com>,
'Zhiguang Liu' <zhiguang.liu@intel.com>,
'Laszlo Ersek' <lersek@redhat.com>
Subject: Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Date: Thu, 3 Dec 2020 19:03:22 -0800 [thread overview]
Message-ID: <DM6PR07MB71809EF2D2CE342BDE19F5F3C8F10@DM6PR07MB7180.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20201203112408.GP1664@vanye>
As a downstream consumer and maintainer I strongly support correcting
these fields.
If a platform dev model can't handle this type of breaking change then
this project is paralyzed and bigger things should be addressed.
Thanks
Sean
On 12/3/2020 3:24 AM, Leif Lindholm wrote:
> Liming,
>
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
>
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
>
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
>
> /
> Leif
>
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
>> Rebecca:
>> I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
>> There are many platform SmbiosDxe driver to depend on them.
>> So, this change impacts widely. This change is just to rename field name.
>> There is no real functionality change. I suggest to add comments for those
>> typo fields instead of changing them.
>>
>> Thanks
>> Liming
>>> -----邮件原件-----
>>> 发件人: bounce+27952+68193+4905953+8761045@groups.io
>>> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
>>> 发送时间: 2020年12月3日 3:03
>>> 收件人: devel@edk2.groups.io
>>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>>> Zhiguang Liu <zhiguang.liu@intel.com>
>>> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>>>
>>> Since the edk2-stable202011 tag has been created, I'm resubmitting the
>>> SmBios.h typo fixes.
>>>
>>> Rebecca Cran (3):
>>> MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
>>> struct
>>> MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>>> ProcessorManufacturer
>>> MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
>>> FirmwareVersion
>>>
>>> MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>>> 1 file changed, 13 insertions(+), 13 deletions(-)
>>>
>>> --
>>> 2.26.2
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
>
>
>
prev parent reply other threads:[~2020-12-04 3:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 19:03 [PATCH 0/3] MdePkg: fix typos in SmBios.h Rebecca Cran
2020-12-02 19:03 ` [PATCH 1/3] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct Rebecca Cran
2020-12-02 19:03 ` [PATCH 2/3] MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field ProcessorManufacturer Rebecca Cran
2020-12-02 19:03 ` [PATCH 3/3] MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field FirmwareVersion Rebecca Cran
2020-12-03 1:18 ` 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h gaoliming
2020-12-03 1:29 ` Rebecca Cran
2020-12-03 11:24 ` Leif Lindholm
2020-12-04 1:24 ` 回复: " gaoliming
2020-12-04 3:03 ` Sean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR07MB71809EF2D2CE342BDE19F5F3C8F10@DM6PR07MB7180.namprd07.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox