From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.92.45.98]) by mx.groups.io with SMTP id smtpd.web08.9167.1607051006362669706 for ; Thu, 03 Dec 2020 19:03:26 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=NM0a2VHm; spf=pass (domain: outlook.com, ip: 40.92.45.98, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2KwvpKekda/QSa7hsLOFasp5sh6BIlPVANYUO2In6mCqfQ/XPgVPgPhM4a7nFyXJJHVEmuqBaF+V2qHYdoSGv2NJ+jYBOKYAMBo6N33+V/+DUXIwkcwNdv2ZGGzkVNDYwSkh4RGp57OYskch8m8v2hoSF/16Uo6YtyqwmDmRddtwFT9T4TZWTZjvBXVNRzhsEorvPx9g08msa9m0EoOwC0OCO7upJrr9iDV/Jgw1jT5TVoC6+mddVwgc9hRFoufkKCjtQ5ZBKTXwECJYpT1VyGeCld+sn5yGS1quxM/MuhGYshwmerXC4G/I+8RfREyGRJnnA9qbLEksodANW9rYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Ky/jWoa1XLTltHhCc3Ola22ozEAsCTOplJhcD+T2a4=; b=PcgroD55Ju519lU+meoAY2hhpqreSFOFy4CdTCpJxFcpMGJ2gHGrX9Q556kmpaGw9FL4ALeQl9+z4bOJayLl1u3RE+na2eg3lyZlWLDtZM/WnEoXBWuDrhqkNkmC2pnNWd9U1/qIpEjXm6cJPBtukVpMxzSaOTX9EpVvCXv5f+OHdlu47XoPZuKDBTFshivqQ7XAqwdHMsNwb4VNOhqDCF0xVfvqeGcE1LDeQDrLvJ3rlXi1Ln9WF/FPByGwb7maL5DYSu6Yn1nvEEjpC9dPhqYYHKZNlF1Da+UZg+XM/K6a3HDPqPOk7/QXeCZczqDv9JoXdbcRNntbEHTcoLa7vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Ky/jWoa1XLTltHhCc3Ola22ozEAsCTOplJhcD+T2a4=; b=NM0a2VHmoByb46J34ZjbVpLQt4X1bxNTFH35IIz55fkRfxlwV2HoA7ntWAB2rAn6ZkjrC8OBwjNhBqtyHxjvFJ9mEvdNScNNeq15ZzrIHG2i7QurMurkm8C8Qlhq6SCorbK01j+p7J8efnsA9HeMBTe9WnvZfSkuCdAytgM/aau21smtCXG/ORykCWaYL65vDJdYGR3+WqjzJyRTuOzXVPqLmbo6wEijLzhM3A6EhK9i730mqZxiRnTUVVA2NkkoIr6qEv/eXFuNLFwbcCyojfWe9E6OL9wV3XlV+R06eCJBl/hXf+O7RbxLdWMU0IItCXzVV7eZ7wFekl7hhFobLg== Received: from SN1NAM04FT014.eop-NAM04.prod.protection.outlook.com (10.152.88.56) by SN1NAM04HT068.eop-NAM04.prod.protection.outlook.com (10.152.89.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Fri, 4 Dec 2020 03:03:25 +0000 Received: from DM6PR07MB7180.namprd07.prod.outlook.com (2a01:111:e400:7e4c::51) by SN1NAM04FT014.mail.protection.outlook.com (2a01:111:e400:7e4c::112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21 via Frontend Transport; Fri, 4 Dec 2020 03:03:25 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:DA867ED8567116C18B50BC9AD6DB58C1B36AE4C3848696E0B37BB39C8EC55959;UpperCasedChecksum:85D3B17BFD177B91691E09F3ABDC546776900F7705CD20F914C88248712D7E5A;SizeAsReceived:8918;Count:48 Received: from DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0]) by DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0%9]) with mapi id 15.20.3632.020; Fri, 4 Dec 2020 03:03:24 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCAwLzNdIE1kZVBrZzogZml4IHR5cG9zIGluIFNtQmlvcy5o?= To: devel@edk2.groups.io, leif@nuviainc.com, gaoliming@byosoft.com.cn CC: rebecca@nuviainc.com, 'Michael D Kinney' , 'Zhiguang Liu' , 'Laszlo Ersek' References: <20201202190325.20310-1-rebecca@nuviainc.com> <005b01d6c912$2d94d050$88be70f0$@byosoft.com.cn> <20201203112408.GP1664@vanye> From: "Sean" Message-ID: Date: Thu, 3 Dec 2020 19:03:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <20201203112408.GP1664@vanye> X-TMN: [DLA7ZmMD+lErgSbnNe0Vn5Ltifz+xtw4] X-ClientProxiedBy: CO1PR15CA0058.namprd15.prod.outlook.com (2603:10b6:101:1f::26) To DM6PR07MB7180.namprd07.prod.outlook.com (2603:10b6:5:1e1::15) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by CO1PR15CA0058.namprd15.prod.outlook.com (2603:10b6:101:1f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Fri, 4 Dec 2020 03:03:23 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 6c0ef2ce-97b1-4a2f-301b-08d898012a01 X-MS-TrafficTypeDiagnostic: SN1NAM04HT068: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yhuuimCBWTnZVz/vCQ6uH+PRzwUYRQmOqzvt2XhaANut9I2nvWh35OXselRvqNoVYaEOI7VfcGhbkmLYr2F1+QBhDUSsPdSdl9bLQrx31PPnMM2kp/cNV+eqd9Dpk5lWNI6YXk7Ime5N+8+1nWvk0DluTelr43KKpdTVWOGxxTDuRVZqtG9jWESW5VL/nHtimryHboQYLzjJiexNNPIzrm26fT1U7T598jvh3AOsR6LTAx7w9+QgN26KFlj6E4m/ X-MS-Exchange-AntiSpam-MessageData: 9vfMGdRFl3r9haQSGs02hl5M7JuS0UygZ18nuPdhCbW8DQQD6jq4w0VKSQJoIzD36jKmCkTxJLQPH8WchYzkn9ZugV8m0n7TPD0ANyMJZr86Zesam1mIIK7nL68bSUqx3030Dsx07TfKRVS+2jmlAw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c0ef2ce-97b1-4a2f-301b-08d898012a01 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2020 03:03:24.9294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: SN1NAM04FT014.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT068 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable As a downstream consumer and maintainer I strongly support correcting=20 these fields. If a platform dev model can't handle this type of breaking change then=20 this project is paralyzed and bigger things should be addressed. Thanks Sean On 12/3/2020 3:24 AM, Leif Lindholm wrote: > Liming, >=20 > These aren't randomly named fields, they are incorrect representations > of an industry standard. >=20 > We are now in the period just after stable tag, breaking platforms is > perfectly acceptable. >=20 > Also, we just happily broke all known platforms during soft freeze by > merging the VariablePolicy set. >=20 > / > Leif >=20 > On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote: >> Rebecca: >> I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platform= s. >> There are many platform SmbiosDxe driver to depend on them. >> So, this change impacts widely. This change is just to rename field = name. >> There is no real functionality change. I suggest to add comments for th= ose >> typo fields instead of changing them. >> >> Thanks >> Liming >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68193+4905953+8761045@groups= .io >>> =E4=BB=A3=E8=A1=A8 Rebe= cca Cran >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=883=E6=97= =A5 3:03 >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >>> =E6=8A=84=E9=80=81: Rebecca Cran ; Michael D Kin= ney >>> ; Liming Gao ; >>> Zhiguang Liu >>> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBi= os.h >>> >>> Since the edk2-stable202011 tag has been created, I'm resubmitting the >>> SmBios.h typo fixes. >>> >>> Rebecca Cran (3): >>> MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS >>> struct >>> MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field >>> ProcessorManufacturer >>> MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field >>> FirmwareVersion >>> >>> MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++---------- >>> 1 file changed, 13 insertions(+), 13 deletions(-) >>> >>> -- >>> 2.26.2 >>> >>> >>> >>> >>> >> >> >> >> >> >> >> >> >=20 >=20 >=20 >=20 >=20