From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.92.21.85]) by mx.groups.io with SMTP id smtpd.web12.14128.1607452653369943650 for ; Tue, 08 Dec 2020 10:37:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=I3xZAvHi; spf=pass (domain: outlook.com, ip: 40.92.21.85, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DV8BxN2TSPsYHBHsHeQfSAQSls/18uSxl1mr9QH6BprqDF2eYQD8xUWlfBJIJ762x0+ZpSM00mFR4SGjt80/33MmOGPXU1JsftMMf3Va+x6Md4B0+iPzJmpuDp7M2SP3TdHY/7fe4Rkr+l0QCBFEgqazA9FU/z4SroC/dlof9i7KsDUGx8MRE8OcOXIruAmYYruR6F7CLhTrop70tFNQ+7otN+3bShcMX2z97xPlXbLFT8ThGyWJnDDAlwDUQj08ayILKfHw7WKyvqq4igusiWw6d4iFpXaTSnubYTO+fS6rUGtBNmh6nMbrFYh9JPuNm5JXf9woZb2vJC2e7hRwPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIk0gIEcs4N25C0mGciNioys/axCppVv1b4q+aL/A/E=; b=eBl4oGHhGI0u+WWZuKCELCW69EoIWcFoo2JoBF5+2cXVMjuZW6KH4SNCskWPFD17S1n6rnBA7YAF5hq5UP2Lh856SeE6WgRcsaXB8NEMPkp1bSfNbdycYmaTteDX2AZbubKc9V26Q2syx3bDSaYXKVw6YO8TqxbDgrdEN0ZmMwbSVjapfhD1jR8pWeMsa6IKOMtBTz3Iw5VtsP0VHLbioO/yw5IYQGuwbJvHgqpkYXbnxiBsEtNADc7kS1fLOO8CrWQkr0C4Z9f7GsGxEFrCAo77jm7jZA6j9zP9SVlzuPZLXecDO1wECj2TzbTeANeGcOcpbqzy2YxFarPpJ648TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIk0gIEcs4N25C0mGciNioys/axCppVv1b4q+aL/A/E=; b=I3xZAvHihu98sjBT0UZGmKpj+5GX0AYjGd7upkG/EF0fmLIv+3d4QAefQWpbXDCiiJPsaazNQLaapH6da8/HDcOaK6t05djNkFOMP/8dE9R2CExmc3bHZuIR3xdO6cjmfIdhEb6kePP7XJ4kpDO7MlPQyqwlimVkvXblmT2MRiV3udpLmnRo1k6M7NU96N+kxG6hHJ2mBPRurO4PIXwChGMN4d6v8CJiITjNA6oY6Lj8rJ4Xw3LyYkMzUt7KeitGrgIx79tq9Tlu9mWY/bsd0CiqwAY6U1hsXYPGkuOEMVWsNEekI9GNZVTg58O9H8ot7GysUVCS5RT5TR3KhDGnwg== Received: from BN8NAM12FT055.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::45) by BN8NAM12HT154.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::277) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.10; Tue, 8 Dec 2020 18:37:32 +0000 Received: from DM6PR07MB7180.namprd07.prod.outlook.com (2a01:111:e400:fc66::42) by BN8NAM12FT055.mail.protection.outlook.com (2a01:111:e400:fc66::252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.10 via Frontend Transport; Tue, 8 Dec 2020 18:37:32 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:03D2631163350E8C2924A3E8B9BE3679800920BA1ECBDA174527F56BC81FB1CB;UpperCasedChecksum:7D94F09356DD728D9BEF7D4ED65D3F0C75CDD6A46E73CAF2B34E8BF6C9B1F0D6;SizeAsReceived:9016;Count:47 Received: from DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0]) by DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0%9]) with mapi id 15.20.3654.012; Tue, 8 Dec 2020 18:37:32 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIHBsZWFzZSBsZXQncyBkaXNhYmxlIHRoZSBFQ0MgcGx1Z2luIGluIENJLCBpbiBpdHMgY3VycmVudCBmb3Jt?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, lersek@redhat.com, 'Michael Kinney' , 'Sean Brogan' , "'Ard Biesheuvel (ARM address)'" , "'Leif Lindholm (Nuvia address)'" , 'Andrew Fish' References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com> <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn> From: "Sean" Message-ID: Date: Tue, 8 Dec 2020 10:37:29 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn> X-TMN: [1boP3HNH2RiNtsUt5j+05kOuvxT9CYgK] X-ClientProxiedBy: MWHPR11CA0023.namprd11.prod.outlook.com (2603:10b6:301:1::33) To DM6PR07MB7180.namprd07.prod.outlook.com (2603:10b6:5:1e1::15) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <9a2f6005-fc4b-de6c-5bf8-52e755464271@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR11CA0023.namprd11.prod.outlook.com (2603:10b6:301:1::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Tue, 8 Dec 2020 18:37:30 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a9d828c8-c671-46f8-1a50-08d89ba852de X-MS-TrafficTypeDiagnostic: BN8NAM12HT154: X-MS-Exchange-MinimumUrlDomainAge: groups.io#3683 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZW/rXK2JE4xn0ot5dFS58Bjh/HS2lbmuWknMI1FH2fMZwMppk05ZKh1ck4col+5PtdTvOgeKj5AkO69cAspgHIppH2C/460aW+baZXN3/bzWNp/Xu2kkvWfgSqNi9Mwt0dAizQ+NHy7LnSlyRYOjfZeFito+IEGZrAjCAiSbrloF14lGwL8Fn+O9niC19yPwD2bJr/R31Z/IrIRaD6who4uYw8iAd9j6Xe0S1Dwwp2QcMtYj9MDNxE1BRtz2eK1 X-MS-Exchange-AntiSpam-MessageData: scMxhE2Rd0D2ZPCrRsdO2udC1TB/hcvrfM+B/hD5RqJGEDC7EYEiuaFNy6F/NUJVq7j5AKBpG7AaZ5L9FIsVQkjlx/C3U4HRYSHPCW/JuREQCt6evT5MiZBEnOjBywUInvB6jIpBZtUE6kOXyoEAwQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2020 18:37:31.8779 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: a9d828c8-c671-46f8-1a50-08d89ba852de X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT055.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT154 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Liming I agree it would be great to get to a place where a package maintainer=20 could turn this on but because of this bug=20 https://bugzilla.tianocore.org/show_bug.cgi?id=3D2986 I think this needs= =20 to be completely disabled until the above is resolved. Thanks Sean On 12/8/2020 7:38 AM, gaoliming wrote: > Laszlo: > ECC tool is not perfect. It is still helpful. I am OK to disable ECC = plugin in CI. But, I request to expose the option to enable it per package.= If the package maintainer thinks ECC is valuable, he can enable ECC plugin= in one package. As MdePkg maintainer, I can help to resolve ECC issue in M= dePkg patch. So, I would keep ECC plugin in MdePkg. >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68414+4905953+8761045@groups.= io >> =E4=BB=A3=E8=A1=A8 Laszl= o Ersek >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=888=E6=97= =A5 10:05 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kinney ; Sean Brogan >> ; Ard Biesheuvel (ARM address) >> ; Leif Lindholm (Nuvia address) >> ; Andrew Fish >> =E6=8A=84=E9=80=81: edk2-devel-groups-io >> =E4=B8=BB=E9=A2=98: [edk2-devel] please let's disable the ECC plugin in= CI, in its current form >> >> Hi All, >> >> in my opinion, the ECC plugin in CI has not been productive or helpful. >> The errors it reports are not convincing, and exceptions are difficult >> to add, or even express. I request that we disable ECC globally for >> edk2, or at least make it controllable through a github PR flag (not >> through CI metafile changes in edk2). >> >> (Metafile changes could be an acceptable way of controlling ECC if (a) >> they didn't have to go through review, (b) if technically such changes >> would take effect in CI even if they were included in the patch series >> subject to the CI run. Then a maintainer could evaluate and >> *immediately* suppress such ECC issues by adding the exceptions as a >> prepended patch, and force-pushing the updated branch to the same open >> PR. But this would remain much inferior to simply disabling ECC, or >> controlling it through a PR label.) >> >> Thanks >> Laszlo >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20