From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.92.5.105]) by mx.groups.io with SMTP id smtpd.web10.9640.1607054716832597271 for ; Thu, 03 Dec 2020 20:05:16 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=W3LXmQQ4; spf=pass (domain: outlook.com, ip: 40.92.5.105, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGf0E1qWd7njI9zTVU+EtvCI/2pH1B/foMm3O112XF+Mj+dazEFwWPIWKRroxXScm11sSTZSZ5ORAnHIB8PRjGSgBls3CK7b86jjlbfONbncUl5MLEfMv5P7Pl0+aOWqHpBjhNn2c1xFZEUBFV3fvlcn3iWKap/IO1KZH5ezYRIKGVihNRULMcoH7QgaQ1uYkkDVJGiTBW0sGYvmuaQzUpPoKC0XCb5A6MCE82w5lWHAB+NT694Filu85FJXfTfkYJ2AoibVZdUjRmjxGQrUFfrnddFmsVT8m8IgWSg5WuZD6aZuvIcayUInXngh6ysc4Fsqbhnvc4HmsBfGqlNKjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QjAd9/rQQHRUoZo4AsQoDo8D9d8VBE5y7PuWrk0Mfro=; b=Ci3F64B3+CI0vSWRFhtmHrIWGqQZfr3sBpH2Q16dVqYl9FJNHkxOushxvcKHy4VNHikPJzSS3SotuFUtmQ0MCuaYBcK8Y/VL5mdmAv+h+kQuB9Bp/zbFqlRMZe2hxvEXl9tRCefqCx/A4SW2O6HiAPr3pX6r+8yiwmG8DbmGlKB3aJ2eT60SiPEc4e+pdzpCzD+HUiv6zU1igwh2UeMMx3D4HLhhw5SXCIs0rL+qInZiYJa+KBWgozA40B4WzW4dimFSVFXwr/dVwXaOE2mZoQhsNnApDKKUtiiCnvu6n+Ob/llTXpbxSyVRRpgGJtby24LwzYuwVqN6ewLA9Z4fNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QjAd9/rQQHRUoZo4AsQoDo8D9d8VBE5y7PuWrk0Mfro=; b=W3LXmQQ4k/ZMXwBoESpfuLsNnZHPJM3XzzqybjQtk9xmn1BeJpXXM1+6uVzxw4LPi7fTtLVvzMrqFtXif6InuKG61dKnvbNzBLaPYfP8D1Mvn2+4zZeVo77WQ0MlazeKReMObd/pHNZUOUkUqw5TC4aSupngprMALqufdSMQQkqS2M1BSaJx9HbnuLO1Q+u7zC2pPz+33ILtXaJnAQDHL7wj76VyxGTKFqb3WM9/k6F9aUjUmsWwul0jHC5isnWWtDS/QxNnm+VeNFjH0bCiojxg9tztSDyQUp6usHZdBshjQw+H367TcDJqENk5Uw1HffbNtdylhL1oQnKviz7CuQ== Received: from CY1NAM02FT045.eop-nam02.prod.protection.outlook.com (10.152.74.57) by CY1NAM02HT083.eop-nam02.prod.protection.outlook.com (10.152.75.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.27; Fri, 4 Dec 2020 04:05:15 +0000 Received: from DM6PR07MB7180.namprd07.prod.outlook.com (2a01:111:e400:7e45::4a) by CY1NAM02FT045.mail.protection.outlook.com (2a01:111:e400:7e45::367) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21 via Frontend Transport; Fri, 4 Dec 2020 04:05:15 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:E6471D27C3040BFFD90105BEE80716B15452DD1712A632A5FAB618A12B11E1CF;UpperCasedChecksum:CA3018AD93F2C381F7AC536F5BE0015E5E21D62EEAEA9F522CC560765349CBE8;SizeAsReceived:8922;Count:48 Received: from DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0]) by DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0%9]) with mapi id 15.20.3632.020; Fri, 4 Dec 2020 04:05:15 +0000 Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg: start using the ECC plugin exception list To: devel@edk2.groups.io, lersek@redhat.com CC: Ard Biesheuvel , James Bottomley , Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Tom Lendacky References: <20201204032116.31321-1-lersek@redhat.com> <20201204032116.31321-2-lersek@redhat.com> From: "Sean" Message-ID: Date: Thu, 3 Dec 2020 20:05:13 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <20201204032116.31321-2-lersek@redhat.com> X-TMN: [dzBaCBCZVUUrsAA+AnKBR47hv68S0tRJ] X-ClientProxiedBy: MWHPR21CA0034.namprd21.prod.outlook.com (2603:10b6:300:129::20) To DM6PR07MB7180.namprd07.prod.outlook.com (2603:10b6:5:1e1::15) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <45d943a0-5c40-1717-9518-b689715a2592@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR21CA0034.namprd21.prod.outlook.com (2603:10b6:300:129::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.2 via Frontend Transport; Fri, 4 Dec 2020 04:05:14 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 2f75dda7-2427-4a05-b4e3-08d89809cde9 X-MS-TrafficTypeDiagnostic: CY1NAM02HT083: X-MS-Exchange-MinimumUrlDomainAge: groups.io#3679 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KjbgQZmyPlwpN/SiDNLRzDWSWJlBVixKYmATdfFeRXEqfbkZqAxaAUbHooGJtk2PPKhuU8iYn+IGHFh68V1VV6H0jviqklStzC+iiXApsAHDgI+GrTuXqGszJBoMh1xLFAereIkN57WkRow0isK2fvaDAmWdjO/CQUwcJLsYXM8IPwX8U95SA0UHPYTAKrC0mBYTTt+I/tBHPj0ZzRPAWqCdiA/VFcfF9xgUbDFWl4vPiVa6LQOHi0v+UBMxnpIE X-MS-Exchange-AntiSpam-MessageData: 967DBEt+0BSHKEeFruT/iBgv5eCF+nQ4F29uz3bF4cxg/FfSpeLlr/fOimCAxoADTXP283ts4dt5Q26egDakkASn9qeFlly7dfx1yp8tKcjEIPWiWrtMMnwVQhQMWpgziTzvulhXJSSLMJIN5DsJMw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f75dda7-2427-4a05-b4e3-08d89809cde9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2020 04:05:15.1848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CY1NAM02FT045.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT083 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable 3 things 1. I would support disabling any ci plugins that can be destructive to=20 your local environment. I think EccCheck needs to be re-evaluated=20 regarding how it gets the change set. What it does now is not a pattern=20 I have encouraged and although i understand the desire (for server ci) i=20 think it has caused more trouble than it is worth. 2. Not sure if license check has same problem or not. On 12/3/2020 7:21 PM, Laszlo Ersek wrote: > In the recent past, ECC has wreaked havoc at least twice: >=20 > - rejected Tom Lendacky's perfectly valid and clean code: >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3008#c5 > https://edk2.groups.io/g/devel/message/67097 >=20 > - rejected James Bottomley's series for bogus reasons: >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3077#c4 > https://edk2.groups.io/g/devel/message/68302 >=20 > There isn't capacity to improve ECC: >=20 > - Liming filed an ECC bug about the first case noted above, but it has > received no feedback in 25 days (as of this writing): >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3060 >=20 > And running CI or ECC on developer machines is difficult: >=20 > - I had to set up a separate VM for it, >=20 > - Shenglei gave Windows-based usage instructions only, >=20 > https://edk2.groups.io/g/devel/message/61966 >=20 > - experimenting with a CI outside of a VM is somewhat risky: >=20 > https://github.com/tianocore/edk2-pytool-extensions/issues/231 3. Running CI locally should not be "somewhat risky". More work needs=20 to be done to identify the root cause of the above behavior but my guess=20 is that it has to do with EccCheck and nothing to do with=20 pytool-extensions. >=20 > ECC should be considered an experimental tool; I agreed to its enablement > in CI specifically because we were offered an exception list: >=20 > https://edk2.groups.io/g/devel/message/60961 > https://www.redhat.com/archives/edk2-devel-archive/2020-June/msg00473.= html >=20 > The github.com-based pull request process is already very inefficient for > both contributors and maintainers; it's time to put the ECC exception lis= t > to use. >=20 > Now, I've tried adding those error codes that were reported against > James's series (after evaluating each entry in the report at > ), > namely 4001, 4002, 5007, 8001, 8004, 8005. However, to my horror, > "EccCheck.ExceptionList" only supports the following format: >=20 > "", "", "", "", ... >=20 > where each pair binds a particular error ID to a particular "offending" > identifier, such as C variable name. There is no wildcard support, so it'= s > impossible to disable entire classes of ECC reports. >=20 > Therefore, I have to use "EccCheck.IgnoreFiles". It also doesn't support > the "." subdirectory or the "*" wildcard. But, with some sweat, I can > still use it to disable ECC for all of OvmfPkg. >=20 > Cc: Ard Biesheuvel > Cc: James Bottomley > Cc: Jordan Justen > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Tom Lendacky > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfPkg.ci.yaml | 49 ++++++++++++++++++++ > 1 file changed, 49 insertions(+) >=20 > diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml > index 3128aefe9ed1..68d2de704d19 100644 > --- a/OvmfPkg/OvmfPkg.ci.yaml > +++ b/OvmfPkg/OvmfPkg.ci.yaml > @@ -22,6 +22,55 @@ > ], > ## Both file path and directory path are accepted. > "IgnoreFiles": [ > + "8254TimerDxe", > + "8259InterruptControllerDxe", > + "AcpiPlatformDxe", > + "AcpiTables", > + "AmdSev", > + "AmdSevDxe", > + "Bhyve", > + "CompatImageLoaderDxe", > + "CpuHotplugSmm", > + "CpuS3DataDxe", > + "Csm", > + "EmuVariableFvbRuntimeDxe", > + "EnrollDefaultKeys", > + "Include", > + "IncompatiblePciDeviceSupportDxe", > + "IoMmuDxe", > + "Library", > + "LinuxInitrdDynamicShellCommand", > + "LsiScsiDxe", > + "MptScsiDxe", > + "OvmfXenElfHeaderGenerator.c", > + "PciHotPlugInitDxe", > + "PlatformDxe", > + "PlatformPei", > + "PvScsiDxe", > + "QemuFlashFvbServicesRuntimeDxe", > + "QemuKernelLoaderFsDxe", > + "QemuRamfbDxe", > + "QemuVideoDxe", > + "SataControllerDxe", > + "Sec", > + "SioBusDxe", > + "SmbiosPlatformDxe", > + "SmmAccess", > + "SmmControl2Dxe", > + "Tcg", > + "Virtio10Dxe", > + "VirtioBlkDxe", > + "VirtioGpuDxe", > + "VirtioNetDxe", > + "VirtioPciDeviceDxe", > + "VirtioRngDxe", > + "VirtioScsiDxe", > + "XenBusDxe", > + "XenIoPciDxe", > + "XenIoPvhDxe", > + "XenPlatformPei", > + "XenPvBlkDxe", > + "XenTimerDxe" > ] > }, > ## options defined .pytool/Plugin/CompilerPlugin >=20 Thanks Sean