From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.92.23.31]) by mx.groups.io with SMTP id smtpd.web12.7995.1607571569157979774 for ; Wed, 09 Dec 2020 19:39:29 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=kXd3gD3c; spf=pass (domain: outlook.com, ip: 40.92.23.31, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORxxXKnFKd9UUQbXUbedF9/HVWtyOkvLDFuR6qBuONZyOcN1upK263eB5RRArRjcLLithKs4Ja3K616ldCt0XCgBGcc2niIHqElJfK39zNSBvDXCBJPWYOSodTgQbWPnxYvU6opR3vZWofud2/5IGrINmPUr8qbkECvFSi6E0wj4PE/wfCYhB8ppEkgqWUXKD/prlFQPATDt2+AsiCtiwEh9kzIFXmaeI2k0Am5lsfJqc540OSqU24jERV/ZVTI/mZ2YXH+SOU3vdW1WSTiK5JpfJ9Wc6RjteDPWLVd4Xp89tVnNvY9X4yYtZx6TWzIkuUBgaH2JyfTYAgA3tH52cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oR0lZT/hgzltdtTjfPoe/1Xup8vs4lZs2CCCzd7Z+2s=; b=l+o4HjtOv0fKVxplGD0V8ZDPh7zOyHbmLJApd4GGCY55khId4x7jGjnp0IULPK/APp34sjl2iUqnYfQ3oSvSCpjCIxm3VZ6KJtUHprYhbCn4D+hSNLQh8z/L/tF2s+r5sTsH/wPf6x/JL0DEI6YizpNcG/i7dLSdS+ozIAfLrEKXCMJPNsOV58cSu8IJs/y9E7abQCEjsI4dFgIFhFmgi+nTvtm+KNR4hilfima//YModkmDKLfL4p6o9PFy3tONbntWGW+sLtSVWSZzviTPY+FHHVzYtJWcP31EhWfOVUnAqXnTp1O7Jn4DCgv8yNNj2lwqvw6YyE7lCGfc2RK9zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oR0lZT/hgzltdtTjfPoe/1Xup8vs4lZs2CCCzd7Z+2s=; b=kXd3gD3chcj1tPlXH62ipiJL23CQGvi+Hzalau9f3o9H12rUvZJRZdBy3culd/arIg0EMchd6ROZFgj3VgjMGiGRE3WEfAgaa6+iPr6OpVlNCDjWhYaIHZzQP/zehoeTfJbcDEfqvnhXJz4t0uwwg529Q7ECsKV0+FrQ9K4i4XK8Oic+8dI7wvLWVXN/3o6+RlHpIoGLGMbq9LVUouSBzsjUn4vOqjsxn66a11okSUyWvQ9jylg8FnUllPFV2i6ZebF/hewjs05auzm0GczNP1L3PRIlo7DrNQUMrv4/eeuxfmoafeY/rin0pmRss8pCMXZNSk6fBc49zhCnQ7Qqcg== Received: from MW2NAM12FT048.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::48) by MW2NAM12HT099.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::239) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.10; Thu, 10 Dec 2020 03:39:28 +0000 Received: from DM6PR07MB7180.namprd07.prod.outlook.com (2a01:111:e400:fc65::45) by MW2NAM12FT048.mail.protection.outlook.com (2a01:111:e400:fc65::215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.10 via Frontend Transport; Thu, 10 Dec 2020 03:39:28 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:1515C532593FE28A53946DC69805E7D3190C5BF8E39CF88137D340E1039298E4;UpperCasedChecksum:1A7B349AE1049CB4004326215C7E379D1E52CF83563F9BC3DA29A58B3E3164CA;SizeAsReceived:9165;Count:47 Received: from DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0]) by DM6PR07MB7180.namprd07.prod.outlook.com ([fe80::9d01:5510:6bd1:2de0%9]) with mapi id 15.20.3654.012; Thu, 10 Dec 2020 03:39:27 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiBbZWRrMi1kZXZlbF0gcGxlYXNlIGxldCdzIGRpc2FibGUgdGhlIEVDQyBwbHVnaW4gaW4gQ0ksIGluIGl0cyBjdXJyZW50IGZvcm0=?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, lersek@redhat.com, 'Michael Kinney' , 'Sean Brogan' , "'Ard Biesheuvel (ARM address)'" , "'Leif Lindholm (Nuvia address)'" , 'Andrew Fish' References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com> <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn> <004801d6ce94$9afef490$d0fcddb0$@byosoft.com.cn> From: "Sean" Message-ID: Date: Wed, 9 Dec 2020 19:39:25 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 In-Reply-To: <004801d6ce94$9afef490$d0fcddb0$@byosoft.com.cn> X-TMN: [9cLAm9ajIC37UANByZA93TWythNtMPbC] X-ClientProxiedBy: MWHPR20CA0029.namprd20.prod.outlook.com (2603:10b6:300:ed::15) To DM6PR07MB7180.namprd07.prod.outlook.com (2603:10b6:5:1e1::15) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <91dd9014-64e0-f0e2-0334-1d5bef936f00@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR20CA0029.namprd20.prod.outlook.com (2603:10b6:300:ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 10 Dec 2020 03:39:27 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 98317a79-9f09-47cc-18b2-08d89cbd3245 X-MS-TrafficTypeDiagnostic: MW2NAM12HT099: X-MS-Exchange-MinimumUrlDomainAge: groups.io#3685 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YurRjcKGaQyI30khzjiWWPA0+5Bl/JEWzMvle/y9i/MEx/n/LUuL1I/YRWWNxAwJ7ii3J28UNrksKdI7W+zo7yxXtzTj0jFZX6ZHf6Aw+6TsyZxJES/DWrjbN1zT4/NOxF8pcR7DGBy9H5HBKbk3d/9WddLgmoBrbdLo1s5kRsqoKJteGv8JifhqME5FiMUmHJIlZE8eYTdBWoYOlFibMj7vKEudu+bqoBhS33qnyt0S+dmSXQ+6RlyogjinM6XJ X-MS-Exchange-AntiSpam-MessageData: /2mDSrl5RVKuNHP/jC/+0WaxMc368jy+ihEcIIsGXpEF/ZTNISf89+mEFW/6tcnVSNISrfmA+1JF7tXCqDjk3rykkxukTUCQghed7bE9BX116E0aL/6dIS4C+G/y5EZxbF0hIVepME7d2QJxkcvSdA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2020 03:39:27.8314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 98317a79-9f09-47cc-18b2-08d89cbd3245 X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT048.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT099 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable I have been thinking about the idea of a CI plugin type that is provided=20 a file list and only operates on the supplied file list. Then during CI execution if a file list was provided these plugins would= =20 run and evaluate on that file list. In azure pipeline we already get=20 the diff between target branch and PR. We could then write that to file= =20 and pass that file into the stuart_ci_build process. Anyway if you have other ideas i'll leave it to you. Please let me know= =20 if you are interested, want to discuss more, or go in this direction. Thanks Sean On 12/9/2020 5:34 PM, gaoliming wrote: > Sean: > I will give the proposal to fix this issue https://bugzilla.tianocore.= org/show_bug.cgi?id=3D2986. In fact, we can enhance ECC to skip the folder = or files. >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Sean Brogan >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=889=E6=97= =A5 2:37 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.co= m.cn; >> lersek@redhat.com; 'Michael Kinney' ; 'Sean >> Brogan' ; 'Ard Biesheuvel (ARM address)' >> ; 'Leif Lindholm (Nuvia address)' >> ; 'Andrew Fish' >> =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] please let's d= isable the ECC plugin in CI, in its >> current form >> >> Liming >> >> I agree it would be great to get to a place where a package maintainer >> could turn this on but because of this bug >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2986 I think this need= s >> to be completely disabled until the above is resolved. >> >> Thanks >> Sean >> >> >> On 12/8/2020 7:38 AM, gaoliming wrote: >>> Laszlo: >>> ECC tool is not perfect. It is still helpful. I am OK to disable E= CC plugin in >> CI. But, I request to expose the option to enable it per package. If th= e >> package maintainer thinks ECC is valuable, he can enable ECC plugin in = one >> package. As MdePkg maintainer, I can help to resolve ECC issue in MdePk= g >> patch. So, I would keep ECC plugin in MdePkg. >>> >>> Thanks >>> Liming >>>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >>>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68414+4905953+8761045@group= s.io >>>> =E4=BB=A3=E8=A1=A8 Las= zlo >> Ersek >>>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=888=E6=97= = =A5 10:05 >>>> =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kinney ; Sean Brogan >>>> ; Ard Biesheuvel (ARM address) >>>> ; Leif Lindholm (Nuvia address) >>>> ; Andrew Fish >>>> =E6=8A=84=E9=80=81: edk2-devel-groups-io >>>> =E4=B8=BB=E9=A2=98: [edk2-devel] please let's disable the ECC plugin = in CI, in its current >> form >>>> >>>> Hi All, >>>> >>>> in my opinion, the ECC plugin in CI has not been productive or helpfu= l. >>>> The errors it reports are not convincing, and exceptions are difficul= t >>>> to add, or even express. I request that we disable ECC globally for >>>> edk2, or at least make it controllable through a github PR flag (not >>>> through CI metafile changes in edk2). >>>> >>>> (Metafile changes could be an acceptable way of controlling ECC if (a= ) >>>> they didn't have to go through review, (b) if technically such change= s >>>> would take effect in CI even if they were included in the patch serie= s >>>> subject to the CI run. Then a maintainer could evaluate and >>>> *immediately* suppress such ECC issues by adding the exceptions as a >>>> prepended patch, and force-pushing the updated branch to the same ope= n >>>> PR. But this would remain much inferior to simply disabling ECC, or >>>> controlling it through a PR label.) >>>> >>>> Thanks >>>> Laszlo >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >>> >=20 >=20 >=20 >=20 >=20 >=20 >=20