From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web08.4522.1632300620709913709 for ; Wed, 22 Sep 2021 01:50:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BxSJog2Z; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: xiaoqiang.zhang@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="210628766" X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="210628766" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 01:50:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="474437092" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 22 Sep 2021 01:50:03 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 01:50:02 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 01:50:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 01:50:02 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 01:49:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=St/XMFVrG68wivnPbozSjyTmB04UUwueZoJF8oW42fIvZd5zefvpl84wMAqOD3SoJGBRoS0nDSSH2ROtxyf6y0y3/l2kmqs9xvs3xOI0bw4hy0txd57FLBKAL+nVw0R4T62hCXcp9uNQpuWqFC0fGDIu/LIxPaOeaf6CxYhi4vVuKpUOT+jeZYVNb3hV/3X4TnE92zhQgKIu7oBGZdzzUwPhPP2v5x4adDRdfKHQ9gZeCuLuIHvKVLxObXFpAh3asZT54TVnzeqt7SXEEyTwDLmX/DVgAL963HihchmJNP21mUrz+D9Jm7VnYXnD/R11OzYcYyiZf7whiUG+9/wZVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LS5M6oixkWNtRCIKCUJd+QpIYVXZHho2bZ7QEbrbg3M=; b=fclQZivg1uD1gOG+P7ksDZrkLSOFzgn2EphC3X5N+62tu5cgwUkoMpwBYI/L+BysB4KEidg5n5cYC/+gP4c3xB1dC45CR0fliiWJsUGCPHjIDH7WzyQPMNfRtJMbQKUCO5uISblxIwfj4xat1OvIPn5XnnB0fhKYq/EuAfDB8ZHVh6jO3rkaRJa+6LN8Vsrav1B85czexXkiQAKvyJN9kv/Ho4DO+779bGIf49avXC3HNGKHaYuS+SY1GUOclqDzy1/ZRCMa+Psb0bAJoXXP63B/vjTYtkS8vsOw0nSvDQjdQknd6ZOAqDmfP4Av4dXvoJdhDbMIPXZeaeGPAxISkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LS5M6oixkWNtRCIKCUJd+QpIYVXZHho2bZ7QEbrbg3M=; b=BxSJog2ZquBNlKEtyNjedELSyGEnPDIxsrKrdU3Ey53Od769RZF1kz1+dofr8nORSlZPw5SrCzn/oZ8MIsG4vtLF/QuLuprACBiUnIM+NAD1FaX564GlWP8Hjyt10QExY9b4uic71vdzCsYbF2mPaX7LTOJzRfjCfnwrG7cV3w4= Received: from DM6PR11MB2538.namprd11.prod.outlook.com (2603:10b6:5:be::20) by DM5PR11MB1961.namprd11.prod.outlook.com (2603:10b6:3:107::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.17; Wed, 22 Sep 2021 08:49:57 +0000 Received: from DM6PR11MB2538.namprd11.prod.outlook.com ([fe80::4194:d852:a5e5:77d6]) by DM6PR11MB2538.namprd11.prod.outlook.com ([fe80::4194:d852:a5e5:77d6%7]) with mapi id 15.20.4523.020; Wed, 22 Sep 2021 08:49:57 +0000 From: "Zhang, Xiaoqiang" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly Thread-Topic: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly Thread-Index: AQHXqq07XGyoq8C95kKssHPUJaC0V6uvxVYAgAABhtA= Date: Wed, 22 Sep 2021 08:49:57 +0000 Message-ID: References: <20210916034447.771-1-xiaoqiang.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87239094-a752-4d77-d9cd-08d97da5f47f x-ms-traffictypediagnostic: DM5PR11MB1961: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:173; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kgSvep+g8/EsDWIm+hj33VDeZqmEKgb7jkRnTyEfZPkiQfcgsb7+NWUPmpNXASZl3f6m7FKD0CUOxQsb0CNML407zwviWJIVtL8sSxjiN0vDGen8y6w/qFZgpJHlGxz+gCpnQv4UO8OohEDg4bUtfaKZx3/w66avm02zx09kGlhuq8ajjYo8EsNDnyBRtt0uXod/LtM8fSdboEUHBk8VIcQKdZ4W6RMfsKxrYxutNS/kysVW+l/w3Q7+IlbEHi8nEDtHsgtxrd3p3W3DLfH+oqInPOII2l3vdlzqUDvkMpcaDhtst1flIyc9ye+YN5PkbB+weWt7Ro+Kna3laZSKebPFFBH+4dDU9i+yNn/Z7/okcCfcm8UKDEE0Sx1h0NkwSBci6G0pBNSJPGP8J/28wQVKrF6aajzLcxmLCLLPimM7yqY8XqN4WJUqL+uJwa6sXgQgm2QvE330pnd3UYy+dCUmw14hjvnnO4rCv9m9QdSP7eXSt4CGeZ8C2e2UB8GVWhSGteZco8Qr1VoS9N2azRWQv25UaMDYWqJ61L0wY/TxtFBIPfZYqohr6nDyKoNomVLwTfyEWphHr1yDwE4/KtXqoq82fMWTEireyoU7MTDAnG/LukjBphjojt5ZGCiGj+n851biVsSu4elASVL2pnC5cbV7gDHcTu/l8Wy3xU+df6ChlXIwpo68dSiEgZgjviZRGGWukexPQUeL1k9jUH60SoTPAJfukNQiCk8s8g5G44E+Xq5kMWDDkvEJRk/pxAgwlJuTbzQvnNlGesPmXezZcrIR2OySQmP/DCr9hYjkkGK2m99kxyZB8LS/aVh5H5hpqBStJAIZf5VtPD9ZiQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2538.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(8676002)(66476007)(66556008)(966005)(64756008)(19627235002)(508600001)(66446008)(52536014)(110136005)(122000001)(38070700005)(86362001)(2906002)(38100700002)(7696005)(83380400001)(33656002)(4326008)(316002)(107886003)(66946007)(71200400001)(54906003)(53546011)(6506007)(8936002)(186003)(26005)(9686003)(76116006)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LIulwxxQqr0ucKccQDKbxDhXeJg0CPYRVoVWhIDORitZDZeoZgxaZnARQK7M?= =?us-ascii?Q?IBjfkH2MRGbjmIumUEHBAHeDrNeiOFEStmj8YYKD7wpaEk8W8DnkW3sr1s7r?= =?us-ascii?Q?UgmL9K7EPW1Oqt/aCZwKQejaSnwVFQPY/sPtq5lWtlFvHssblZBb8js0IYI2?= =?us-ascii?Q?6UJHgIAI+MSXYTdlL43VlnCQyfhkJIw3SEG3XB5us5tdr0ZahHFGVfIMUciy?= =?us-ascii?Q?G4reNnZca+G5InQGcVmWOezNx1SHPz6MgJf7G5d5tCr5LTDKrCXLBdMQg8Il?= =?us-ascii?Q?C8/cpFS01E7zBIjazJfgpE0Ggps4c1EOLB7mQZiqkmFUGNOwy+OcoSGYxOjL?= =?us-ascii?Q?eXz/uzy41vFElGgi0LY1NI5v9Z0oof2XDnsPwZUKULQVq8/BqGF4K5AWMifi?= =?us-ascii?Q?YpBOGqmxKd6xw2RE5HGa3MSRygKnomq6+AGDYpcBtM9L6PRFG6790P3WV5VO?= =?us-ascii?Q?LoxIsgjd0gfIb12TukBgHhvh6eDXUeR32gDnV78nODfZi1OKT/CtbtVQ1LB1?= =?us-ascii?Q?fUTxJnffztAMSOd3Q9oQ6yv/78JJcXnnLM6G1T75a5ai6rb2shF6PcsTVBuV?= =?us-ascii?Q?xRJOpwxeF3/emkmJC6umDKFxkOkEnie8Yf2T6efDzEGCHTU/B3T73KgWXeV8?= =?us-ascii?Q?txVeVs5gJTKGE1zJbBL0Z42zXdCFOtKSNoBNTjlHHath9k9i564bCpSItxa+?= =?us-ascii?Q?dQHR5wO1MJAXESZfQH1gAAe36SsNlkKgaNCWvuTzGFoRUOHqV4rJpGYmA3M5?= =?us-ascii?Q?kaIQaq3Gm7Vvbv3en2OBeyes/s5Pcuy1n9dPtcY0PAxIrPnLL3dyXBUVRFha?= =?us-ascii?Q?t1O7zfXcsQxvNFBgO87MflyNhzxocpUxS4qqQN+W/u0uijZFxtlESDBtJtyY?= =?us-ascii?Q?sH0gUsUR05t2xeP89hwt6UhV/lI9f08c6g65MuPyMdMfzkGS+4zGMoYHEL9N?= =?us-ascii?Q?lhm8kkWjlrjqfmz7CP9w5dt4LA9OlvxifOGEO8M6EEZ0e5gNi0RzPlwQB8RS?= =?us-ascii?Q?REsQTinuN1HpmP+1kpteW3bH6agqTRHDBXJxrg2HCBsWa9TEqXTK1d7wDa8s?= =?us-ascii?Q?ekski2kZKqnsIKHJRb0QuYKPMxGKXxAZ8pq++B2B6n/siL1V/XqB3jC46boq?= =?us-ascii?Q?a2Ljpc//Y7O0mTAa7KjxzDGyaIZ9R41kh70b1GLyemJ3gU0GHe/enlD0pLtN?= =?us-ascii?Q?c2lHr5eg1keu1nsxeKE6wgMwQxDH8F2afzx8YqYkVFg7gufwvmGX5MVbsuzJ?= =?us-ascii?Q?+1v7oA3f7exzheZLSu7FN2sJlLJlPy05TNjEDf/KvJd5r5XpcS/GJ1ZnHKEn?= =?us-ascii?Q?dOQZb8nboFZVkfycU7Qc9SZh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2538.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87239094-a752-4d77-d9cd-08d97da5f47f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 08:49:57.3042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d3SO4S2Irsfp8gTFq0Gwg2Jj+WHWnayjx8UE2jDR685i+wpKZdBumUHZwKMwpcgCm1nb5q81/+zaTEifQ1UzG0ZntooZrLoOMPHkZd1FRvc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1961 Return-Path: xiaoqiang.zhang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Chasel! Best Regards, Xiaoqiang Zhang -----Original Message----- From: Chiu, Chasel =20 Sent: Wednesday, September 22, 2021 4:39 PM To: Zhang, Xiaoqiang ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynam= ic and set it accordingly Patch pushed: https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c76= 7c6614025aa2f802f9a4 Thanks, Chasel > -----Original Message----- > From: Zhang, Xiaoqiang > Sent: Thursday, September 16, 2021 11:45 AM > To: devel@edk2.groups.io > Cc: Zhang, Xiaoqiang ; Chiu, Chasel=20 > ; Desimone, Nathaniel L=20 > ; Zeng, Star > Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection=20 > dynamic and set it accordingly >=20 > From: Zhang Xiaoqiang >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3632 >=20 > PcdFspModeSelection will be used to set FSP mode. > Make PcdFspModeSelection dynamic and set it accordingly. >=20 > Signed-off-by: Zhang Xiaoqiang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > --- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index a3b9363779..b8dac1b574 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -82,12 +82,6 @@ > # @Prompt Skip FSP API from FSP wrapper. >=20 >=20 > gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x00000000|UINT32|0x4 > 0000009 >=20 >=20 >=20 > - ## This PCD decides how Wrapper code utilizes FSP >=20 > - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without=20 > calling FSP API) >=20 > - # 1: API mode (FSP Wrapper will call FSP API) >=20 > - # >=20 > - > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN > T8|0x4000000A >=20 > - >=20 > ## This PCD decides how FSP is measured >=20 > # 1) The BootGuard ACM may already measured the FSP component, such=20 > as FSPT/FSPM. >=20 > # We need a flag (PCD) to indicate if there is need to do such FSP=20 > measurement or NOT. >=20 > @@ -106,6 +100,12 @@ >=20 > gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x0000000 > 0|UINT32|0x4000000B >=20 >=20 >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] >=20 > + ## This PCD decides how Wrapper code utilizes FSP >=20 > + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without > calling FSP API) >=20 > + # 1: API mode (FSP Wrapper will call FSP API) >=20 > + # >=20 > + > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN > T8|0x4000000A >=20 > + >=20 > # >=20 > ## These are the base address of FSP-M/S >=20 > # >=20 > -- > 2.32.0.windows.1