From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.5933.1610648023237936149 for ; Thu, 14 Jan 2021 10:13:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nFHmgMqS; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: andrew.kim@intel.com) IronPort-SDR: bY721bM7oMXSYuQw/49chYqe1u0oSKQKYoROcBbQVY/EFhjDzyuAUD7kEjrXfeuTFwm8oGEFMG NBs1Z3P22Deg== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="157597313" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208,217";a="157597313" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 10:13:40 -0800 IronPort-SDR: 2f/3OoSkyyrq72xfOu1sqA5Io11uMFODzVk+/y6x/8ajZo08+ni52zW862XOwm6a6YVuHNHpRq 3tAlTSEXGgCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208,217";a="352577119" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 14 Jan 2021 10:13:40 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 Jan 2021 10:13:39 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 Jan 2021 10:13:39 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 14 Jan 2021 10:13:39 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 14 Jan 2021 10:13:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1eMgIvWQ5b2m9g1ydODYgdRB5rLDS5/svbP//InBKnLQgvFQOe+rpmp4XYALL8uNNrhjoPCE9A1WdwaFwXRO1drEkJ1o4z9g6K9eV8AB+2Rcphh4fmpesj2DLV0qsogZHRq12/+CupTOPZ7Vf66OeRXVllrJhKjyxQwy0OJ5wnDJrCygl9A1C0dF5VoM2gGdenTVsREC0knlqadmfWZiH/tpabDQht3YJGqmMlEG3J+mi5CHDtEbiKgh3vrSEVbDOd2vw932Sy5NOpzS14PrmnVCtZ/QGj71mI5GBhP4rFxB0i+ExJHYeqRQBwxvsMnWeMjhKDAcCEmpBnCacxv+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3J4G59/1hM3PK5l5cRTcgyfNHcybrK+VWhLGEF8hUMg=; b=E1sPhGyxd2iAHvNJWUlup0JJf0p4rp7SPzfICASa10sh7lZ+HLUhQjO0++08KuCF/tlTZFxI7ExCYA/A1v0WcdNAiXkvLgfAahYBTGrmIypwX/VPrOorbXQEUNXV46EB0cHx8i/Hb0UNs3hYdZKWmY4DGgWi67vGbNsrepPYjSxzwyvchf9i+238EswKcJwmfq6GVDsLor2sv3/NjGneJ8Mat7ULtypBQxmDzuITLV8lrl2TZchGHCsLOu5TkZf4q7Js78eIkFDEfmE8FidGFQP8AV4PcnzImhZC2qTyJ12h6iUDp72dAb3vRkL9SHAW7MUz3SdONZFDXfadNxlF2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3J4G59/1hM3PK5l5cRTcgyfNHcybrK+VWhLGEF8hUMg=; b=nFHmgMqSs1LTcohUVndzcjwp2gsUT2otClQQUAPDevjj2YNpcksyYOgBrMhJVE3hQI/odKxiQogQKiZ8k/LDaBleDn56+HOdi3r6S+yXUuspDEyBoPEeuzuYglJqn0Ybge1E/6ZnP06N27Ypx/cUbWj2d18BqVafVek6VZCiObk= Received: from DM6PR11MB2764.namprd11.prod.outlook.com (2603:10b6:5:bf::12) by DM6PR11MB4489.namprd11.prod.outlook.com (2603:10b6:5:203::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Thu, 14 Jan 2021 18:13:37 +0000 Received: from DM6PR11MB2764.namprd11.prod.outlook.com ([fe80::88f4:fba0:3381:d4e5]) by DM6PR11MB2764.namprd11.prod.outlook.com ([fe80::88f4:fba0:3381:d4e5%7]) with mapi id 15.20.3763.010; Thu, 14 Jan 2021 18:13:37 +0000 From: "Kim, Andrew" To: "Zhong, Zarcd" CC: "Wu, Hao A" , "Kinney, Michael D" , "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64. Thread-Topic: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64. Thread-Index: AdbifqrbMhe/1KwPTxui//AvwMCRQAG+ZBhAACnK61AABqDE4AABJCGQABb6sdAAAZOskA== Date: Thu, 14 Jan 2021 18:13:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: request-justification,no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [104.153.200.4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d1e6bfa-2170-4d00-3765-08d8b8b81d06 x-ms-traffictypediagnostic: DM6PR11MB4489: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dXhC1g9qhmf4/t8xLBUOQSREuVUKl+uz1xDUPwnyjpUX8zRwN1kpCGxvSiqnL6QOpHtsFP7PSMpYqAZM/zJXWsM2pQHXxPcnkREZF2FFmFwlpbz1AEMcT/jWMI+h/1YaRX3+S9toZQkrJWL5gX72kgUcdazRtgWt9KheEXMVtXZ1TcaMx6Rv9rAT1ViopIv9XoyJ77jCdjrWu/D+jxPYvKU/aL54+ABjMhFBsdJMt9qSIIFJtjdjhwwPzNGoKvbf7qpSgH35e+rnrMGmen+fCITwck3ZoMJrEd6aZTQf4ORFNnsRqIKAjzIXWze4JXekpKak8SV0fjSjMuKM1MVrEjPbVDv5F57kmmDpJ8END71F7Ziz0BVjIkkosfeurQKZQQy3gB1jX77ofjIcqFguRh/SyIgfx7V6D5bxe7u0hND+J7Cwq1Y421NTq+vty6S8XaMv8cS9K8QUQMo7mFBcsA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2764.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(6862004)(186003)(26005)(86362001)(8676002)(55016002)(4326008)(5660300002)(66556008)(9686003)(53546011)(2906002)(6636002)(6506007)(71200400001)(8936002)(7696005)(33656002)(83380400001)(66946007)(107886003)(166002)(966005)(52536014)(66476007)(478600001)(54906003)(316002)(2940100002)(66446008)(64756008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?DO9W4nQs8fqV9M3Cx1gi+WUwpPItPLmLepPFU15Nj14wvgcXZPvJQGAEx17h?= =?us-ascii?Q?WGNJYi4cSEyQQfSzrhUpnXH4eKJcKmY8KMd/wrwpHtfmUs5FEzZgUjU3QWZj?= =?us-ascii?Q?KGf7HduFOlOlKPeshsbq49UtgfoAQ8JEy8oPyDKOfgW11i5ySsjWaxDfMHSK?= =?us-ascii?Q?D4I8Y4vDpqE95tNYKjmNTAmkTAU+AskwuFeLAkgyVmg5CHajk7HP+fmMyypQ?= =?us-ascii?Q?ByfkcK3mO/46G/lhv9fqd0fdetnGUs4615VvAya+JZoVjC2ofLddzMarpCgD?= =?us-ascii?Q?ftnBSXioUOKMogGkRcKmA1NqG0zdFVINPiXSDDNTALh4ztpA73n/jQk+Yt4y?= =?us-ascii?Q?/0Q+KsH5ZVEuFrBp66JyJ+D26KhPwEtKSaQ+98+T7mVdx7EToIXoDYRV6382?= =?us-ascii?Q?OY4ytUHFTAg7yTbOk+WXgbowZPVPqoZG9+jZxey4MQlhRwDSDXc1okGu5jnf?= =?us-ascii?Q?++8jpRivxiCSqiVsJftsAs4zFJNqolK4uewo00w0xIdxznjStRD4uy9nFXS3?= =?us-ascii?Q?KIjh3THNE/CvN4yiYBzialsfhUIg7ETDB9lhhFU90XicJAg78AjOyk4Qn+uy?= =?us-ascii?Q?d1dz1iGBR9XfK+ZYYRNbqUiPhdAShSjArkmr12Jwdll7Cz2gEgyI8YflgGPL?= =?us-ascii?Q?Ntdpln6yhfGOhi/Q5L8MlxRsApTut1OhqaIKePDy3wA2QhrcNAjiUSnQZm7w?= =?us-ascii?Q?HlmXgJW96hfmPeIySgcwF5bdVsj6wKng7nBFRb8QHqAD70OgbtUbWmF6IjQA?= =?us-ascii?Q?xd/YA11LWIviu+od+ncPaq3qhW1lva/F9PQJEoXckHDcYHFjJ0Wm0qaF2nL6?= =?us-ascii?Q?8LJf3snz/PJdVtWSy8cNmwBAjFcxG8OnLnvPqgZaOxED+XnOVZfeGIbOYJOv?= =?us-ascii?Q?UFcUvU91aVIIruRwg4TI8W+CUQYjmstja7pB+8ywE021S9kq3U5JjR89DFRu?= =?us-ascii?Q?JEcNeWvZVRRS4zrbRKULks9eAYDF4VPnzIYWRnUUxA8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2764.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d1e6bfa-2170-4d00-3765-08d8b8b81d06 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2021 18:13:37.1556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tfNoGn9NE9P4nou30LtT0gj4xGBkPgHZNdD7q7xjr4qAaI0cMfrYsiuno9RlbvzXhGCT3i/YcIORtNoM8IgPVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4489 Return-Path: andrew.kim@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB2764D7404CC2E53333163F3285A80DM6PR11MB2764namp_" --_000_DM6PR11MB2764D7404CC2E53333163F3285A80DM6PR11MB2764namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable BTW, to be clear for this to try. Could you confirm if this is right update with your suggestion? if (EFI_ERROR (Status)) { PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown; return Offset + 4; } -Andrew From: Kim, Andrew Sent: Thursday, January 14, 2021 9:38 AM To: Zhong, Zarcd Cc: Wu, Hao A ; Kinney, Michael D ; devel@edk2.groups.io; Ni, Ray Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail= in high 32bit of MEM64. Hi Zarcd, Thanks for this update. Sure, I will let you know once it has been verified. -Andrew From: Zhong, Zarcd > Sent: Wednesday, January 13, 2021 10:32 PM To: Kim, Andrew > Cc: Wu, Hao A >; Kinney, Mich= ael D >; deve= l@edk2.groups.io; Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail= in high 32bit of MEM64. Hi Kim, Ray suggests a one line patch instead of google's solution. + PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown; Could you help to verify Ray's solution on that card? From: Ni, Ray > Sent: Thursday, January 14, 2021 1:59 PM To: Zhong, Zarcd >; dev= el@edk2.groups.io Cc: Wu, Hao A >; Kinney, Mich= ael D > Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail= in high 32bit of MEM64. Zarcd, I may not say very clearly. I prefer to just keep below line. Can you check= whether that can work? + PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown; Thanks, Ray From: Zhong, Zarcd > Sent: Thursday, January 14, 2021 10:48 AM To: Ni, Ray >; devel@edk2.groups.= io Cc: Wu, Hao A >; Kinney, Mich= ael D > Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail= in high 32bit of MEM64. Hi Ray, Attached patch is updated with below add. Thanks for your remind. PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown; From: Ni, Ray > Sent: Wednesday, January 13, 2021 3:01 PM To: Zhong, Zarcd >; dev= el@edk2.groups.io Cc: Wu, Hao A >; Kinney, Mich= ael D > Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail= in high 32bit of MEM64. Zarcd, I can understand that this patch is needed for some buggy pci devices whose VF bar behaves strangely. Incompatible PCI protocol can only deal with norm= al PCI bar. And this patch is just to enhance the error handling logic. Can you please use below code for error handling? + PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown I understand that your change is aligned to existing error handling in the = beginning of PciIovParseVfBar(). But that logic runs before PciIoDevice->VfPciBar[BarIndex].BarType is assig= ned. The key is to reset the BarType to PciBarTypeUnknown so that the resource s= ummary code doesn't count this bar. Thanks, Ray From: Zhong, Zarcd > Sent: Monday, January 4, 2021 5:48 PM To: devel@edk2.groups.io Cc: Ni, Ray >; Wu, Hao A > Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in = high 32bit of MEM64. >>From 7518212a85269e486d06dcea927a3d34e23372c2 Mon Sep 17 00:00:00 2001 From: Zarcd Zhong > Date: Mon, 4 Jan 2021 17:32:54 +0800 Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in = high 32bit of MEM64. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3149 Clear length and alignment for low 32bit of MEM64 BAR if sizing fail in= high 32bit. Cc: Ray Ni > Cc: Hao A Wu > --_000_DM6PR11MB2764D7404CC2E53333163F3285A80DM6PR11MB2764namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

BTW, to be clear for this to try.

Could you confirm if this is right update with your = suggestion?

 

 

      if (EFI_ERROR (Status= )) {

        PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBarTypeU= nknown;

 

        return Of= fset + 4;

      }

 

 

-Andrew

 

From: Kim, Andrew
Sent: Thursday, January 14, 2021 9:38 AM
To: Zhong, Zarcd <zarcd.zhong@intel.com>
Cc: Wu, Hao A <hao.a.wu@intel.com>; Kinney, Michael D <mich= ael.d.kinney@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.= com>
Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizi= ng fail in high 32bit of MEM64.

 

Hi Zarcd,

 

Thanks for this update.

 

Sure, I will let you know once it has been verified.=

 

-Andrew

 

From: Zhong, Zarcd <zarcd.zhong@intel.com>
Sent: Wednesday, January 13, 2021 10:32 PM
To: Kim, Andrew <andrew.k= im@intel.com>
Cc: Wu, Hao A <hao.a.wu@int= el.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Ni, Ray &= lt;ray.ni@intel.com>
Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizi= ng fail in high 32bit of MEM64.

 

Hi Kim,

 

Ray suggests  a one line patch instead of googl= e’s solution.

+        PciIoDev= ice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown;

 

Could you help to verify Ray’s solution on tha= t card?

 

 

 

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, January 14, 2021 1:59 PM
To: Zhong, Zarcd <zarcd.= zhong@intel.com>; devel@edk2.groups.io
Cc: Wu, Hao A <hao.a.wu@int= el.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizi= ng fail in high 32bit of MEM64.

 

Zarcd,

I may not say very clearly. I prefer to just keep be= low line. Can you check whether that can work?

+        PciIoDev= ice->VfPciBar[BarIndex].BarType =3D PciBarTypeUnknown;

 

Thanks,
Ray

 

From: Zhong, Zarcd <zarcd.zhong@intel.com>
Sent: Thursday, January 14, 2021 10:48 AM
To: Ni, Ray <ray.ni@intel.com= >; devel@edk2.groups.io
Cc: Wu, Hao A <hao.a.wu@int= el.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizi= ng fail in high 32bit of MEM64.

 

Hi Ray,

 

Attached patch is updated with below add. Thanks for= your remind.

 

PciIoDevice->VfPciBar[BarIndex].BarType =3D PciBa= rTypeUnknown;

 

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Wednesday, January 13, 2021 3:01 PM
To: Zhong, Zarcd <zarcd.= zhong@intel.com>; devel@edk2.groups.io
Cc: Wu, Hao A <hao.a.wu@int= el.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizi= ng fail in high 32bit of MEM64.

 

Zarcd,

I can understand that this patch is needed for some = buggy pci devices whose
VF bar behaves strangely. Incompatible PCI protocol can only deal with norm= al
PCI bar. And this patch is just to enhance the error handling logic.

 

Can you please use below code for error handling?

+        PciIoDev= ice->VfPciBar[BarIndex].BarType     =3D PciBarTypeUn= known

 

I understand that your change is aligned to existing= error handling in the beginning
of PciIovParseVfBar().

But that logic runs before PciIoDevice->VfPciBar[= BarIndex].BarType is assigned.

The key is to reset the BarType to PciBarTypeUnknown= so that the resource summary
code doesn’t count this bar.

 

Thanks,

Ray

 

From: Zhong, Zarcd <zarcd.zhong@intel.com>
Sent: Monday, January 4, 2021 5:48 PM
To: devel@edk2.groups.io=
Cc: Ni, Ray <ray.ni@intel.com= >; Wu, Hao A <hao.a.wu@inte= l.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing f= ail in high 32bit of MEM64.

 

From 7518212a85269e486d06dcea927a3d34e23372c2 Mon Se= p 17 00:00:00 2001

From: Zarcd Zhong <zarcd.zhong@intel.com>

Date: Mon, 4 Jan 2021 17:32:54 +0800

Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Han= dle BAR sizing fail in high 32bit of MEM64.

 

    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3149

 

    Clear length and alignment for lo= w 32bit of MEM64 BAR if sizing fail in high 32bit.

 

    Cc: Ray Ni <ray.ni@intel.com>

    Cc: Hao A Wu <hao.a.wu@intel.com>

--_000_DM6PR11MB2764D7404CC2E53333163F3285A80DM6PR11MB2764namp_--