public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ma, Maurice" <maurice.ma@intel.com>
To: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	Christian Walter <christian.walter@9elements.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
Date: Wed, 8 Jul 2020 17:46:26 +0000	[thread overview]
Message-ID: <DM6PR11MB27931048603D789315FE16E389670@DM6PR11MB2793.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB27937D3BA39002572367AB5989670@DM6PR11MB2793.namprd11.prod.outlook.com>

BTW,  I just noticed that not all package maintainers are on the CC list.    
For changed under UefiPayloadPkg,  please ensure you CC all UefiPayloadPkg maintainers listed in the Maintainers.txt under the root of the EDK2 directory.  

Thanks
Maurice
> -----Original Message-----
> From: Ma, Maurice
> Sent: Wednesday, July 8, 2020 8:25
> To: 'Marcello Sylvester Bauer' <marcello.bauer@9elements.com>;
> devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
> 
> Could you please add some commit message to explain what issue you are trying
> to address ?  Why is it required ?
> 
> Thanks
> Maurice
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Wednesday, July 8, 2020 7:09
> > To: devel@edk2.groups.io
> > Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> > <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> > <star.zeng@intel.com>
> > Subject: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART
> > defaults
> >
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Cc: Christian Walter <christian.walter@9elements.com>
> > Cc: Maurice Ma <maurice.ma@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > ---
> >  UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 2 +-
> >  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > index 0efcfa8fb2f4..0d8854810700 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
> >    # The following parameters are set by Library/PlatformHookLib
> >
> >    #
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
> >
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
> >
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
> >
> >
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > index d645d233cd08..34640b1fc1da 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
> >    # The following parameters are set by Library/PlatformHookLib
> >
> >    #
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
> >
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
> >
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
> >
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
> >
> >
> >
> > --
> > 2.27.0


      reply	other threads:[~2020-07-08 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 14:08 [PATCH v1 0/1] Remove x86 legacy UART defaults Marcello Sylvester Bauer
2020-07-08 14:09 ` [PATCH v1 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
2020-07-08 15:24   ` Ma, Maurice
2020-07-08 17:46     ` Ma, Maurice [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB27931048603D789315FE16E389670@DM6PR11MB2793.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox